Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp32904rdf; Thu, 2 Nov 2023 12:57:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEQI0YboZlvmSeECUw10hWbSYdhKHaKNtI8S+FjljG2vPYTeptYsoCY8XAbkDX8/o3K/wAx X-Received: by 2002:a17:90a:7563:b0:27d:853:9109 with SMTP id q90-20020a17090a756300b0027d08539109mr18189879pjk.20.1698955051416; Thu, 02 Nov 2023 12:57:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698955051; cv=none; d=google.com; s=arc-20160816; b=dKM+UDeqE8ir8Q6FBmJasSTQdkDjfsLuIJJtht1DFFbbjHc8/l21iV9ZhSLaqtMCu/ +Hm+8+WNDtmXc7iluR8ta/6cPCo+waYYgtOuI2wARmH4AMmzqnxRaBQxdyv31uUsI1dH e6VHsxv2DovvWFyeoH5IRm21m7V6OQI5ES6ot3FtFw4t9xZ8b0DZhCDreN9sewsTXiM7 8tcbAjmqE4uSVifykCrJODFmbkuOv047YDSrSFBxq85Cz645T+srxobg8ZqwCHz8AC1w 6p4AmrULAQWzM7+vm3Q8ktR0OpL1PPdUJTuNRWtrfUlecQysHIjYwgwA0fOHwVg4XxFK 2a1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=AW0JKODqEk596T2QEg4UZ2eLMTRAd63PvmKSuulbUwQ=; fh=MwuqABT3FHINnYiqByeb7bBxbROL4LDXA/Xq6xRxf4k=; b=LGrFYaysG1tWJg55hJKPgmyXAXLAkdjCIFWhjQQ8+HjTjx+xk6xKoKseHxHueN9i4F 7oQJOyjAM7+iED3+FOKw//44pQZB+iYyweY5dgqEUsUxCBaRYBsfD2/RcjUYj99IZbvY yoylwN3YWc6NIqjBRFHexAP64a+4qVwnoqu2z8ZZqlS7ZNEhftsMImghgVkscmLBrzZG F9WHAcsIPpFcTiHl0V1HZTbgQB6NSola4a3hcUnq2KRbdXNr6GSe7vucK9VTqPBbO3ny 11iYeAm3gGwe/GUBjtpfnBvYXy7vfp+oGCowUhWU1htZUHsngiZJeg+Or967Wi5ouRkp YcGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=ibpfBYhI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id o17-20020a17090ac71100b00262f937bf93si232698pjt.77.2023.11.02.12.57.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Nov 2023 12:57:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=ibpfBYhI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 5E60B838F065; Thu, 2 Nov 2023 12:57:21 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234422AbjKBT5A (ORCPT + 99 others); Thu, 2 Nov 2023 15:57:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229550AbjKBT47 (ORCPT ); Thu, 2 Nov 2023 15:56:59 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D59EE19A; Thu, 2 Nov 2023 12:56:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=AW0JKODqEk596T2QEg4UZ2eLMTRAd63PvmKSuulbUwQ=; b=ibpfBYhILmLn39D7AlH28340n3 XLifNeoA3ngYepC9tqOP+n25UgJ1gaMVEaLMugYVPXmyavS2HYTe/AHVSWTa01L5LFC1qPjw1Htk/ 2KXsfghHYH4qrb5QS8256r06TCsUgebHwiX4EfUC7HcUBDNGaBmBPJBfX0AHR3/ikaTQ=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qydn8-000mGi-5t; Thu, 02 Nov 2023 20:55:46 +0100 Date: Thu, 2 Nov 2023 20:55:46 +0100 From: Andrew Lunn To: "Kiyanovski, Arthur" Cc: Justin Stitt , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "Agroskin, Shay" , "Arinzon, David" , "Dagan, Noam" , "Bshara, Saeed" , Rasesh Mody , Sudarsana Kalluru , "GR-Linux-NIC-Dev@marvell.com" , Dimitris Michailidis , Yisen Zhuang , Salil Mehta , Jesse Brandeburg , Tony Nguyen , Louis Peens , Shannon Nelson , Brett Creeley , "drivers@pensando.io" , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Ronak Doshi , VMware PV-Drivers Reviewers , Andy Whitcroft , Joe Perches , Dwaipayan Ray , Lukas Bulwahn , Hauke Mehrtens , Florian Fainelli , Vladimir Oltean , =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , Daniel Golle , Landen Chao , DENG Qingfang , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Linus Walleij , Alvin =?utf-8?Q?=C5=A0ipraga?= , Wei Fang , Shenwei Wang , Clark Wang , NXP Linux Team , Lars Povlsen , Steen Hegelund , Daniel Machon , "UNGLinuxDriver@microchip.com" , Jiawen Wu , Mengyuan Lou , Heiner Kallweit , Russell King , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , Nick Desaulniers , Nathan Chancellor , Kees Cook , "intel-wired-lan@lists.osuosl.org" , "oss-drivers@corigine.com" , "linux-hyperv@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mediatek@lists.infradead.org" , "bpf@vger.kernel.org" Subject: Re: [PATCH net-next v4 3/3] net: Convert some ethtool_sprintf() to ethtool_puts() Message-ID: <0df2daf8-9707-4859-b4c2-5c3c2ef2f8cd@lunn.ch> References: <20231102-ethtool_puts_impl-v4-0-14e1e9278496@google.com> <20231102-ethtool_puts_impl-v4-3-14e1e9278496@google.com> <75bf36b5eef9487794c11a45cb25f155@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <75bf36b5eef9487794c11a45cb25f155@amazon.com> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 02 Nov 2023 12:57:21 -0700 (PDT) > > + vmxnet3_rq_driver_stats[i].desc); > > } > > > > for (i = 0; i < ARRAY_SIZE(vmxnet3_global_stats); i++) > > - ethtool_sprintf(&buf, vmxnet3_global_stats[i].desc); > > + ethtool_puts(&buf, vmxnet3_global_stats[i].desc); > > } > > > > netdev_features_t vmxnet3_fix_features(struct net_device *netdev, > > > > -- > > 2.42.0.869.gea05f2083d-goog > > Thanks for submitting this. > For ENA driver > > Acked-by: Arthur Kiyanovski Hi Arthur Please trim emails when replying. Andrew