Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
MIME-Version: 1.0
References: <20231102192134.53301-2-pstanner@redhat.com> <20231102201424.GL1957730@ZenIV>
In-Reply-To: <20231102201424.GL1957730@ZenIV>
From:   David Airlie <airlied@redhat.com>
Date:   Fri, 3 Nov 2023 06:24:09 +1000
Message-ID: <CAMwc25rgdNt3oO3Yf=v05AWOSgN5W4j=ST=Y9qikeBrNTqqW2w@mail.gmail.com>
Subject: Re: [PATCH] drivers/tty/vt: copy userspace arrays safely
To:     Al Viro <viro@zeniv.linux.org.uk>
Cc:     Philipp Stanner <pstanner@redhat.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Kefeng Wang <wangkefeng.wang@huawei.com>,
        Tony Luck <tony.luck@intel.com>,
        Ard Biesheuvel <ardb@kernel.org>, linux-kernel@vger.kernel.org,
        linux-serial@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Nov 3, 2023 at 6:14=E2=80=AFAM Al Viro <viro@zeniv.linux.org.uk> wr=
ote:
>
> On Thu, Nov 02, 2023 at 08:21:35PM +0100, Philipp Stanner wrote:
> > The functions (v)memdup_user() are utilized to copy userspace arrays.
> > This is done without overflow checks.
> >
> > Use the new wrappers memdup_array_user() and vmemdup_array_user() to
> > copy the arrays more safely.
>
> > @@ -644,7 +644,7 @@ int con_set_unimap(struct vc_data *vc, ushort ct, s=
truct unipair __user *list)
> >       if (!ct)
> >               return 0;
>
> > -     unilist =3D vmemdup_user(list, array_size(sizeof(*unilist), ct));
> > +     unilist =3D vmemdup_array_user(list, ct, sizeof(*unilist));
> >       if (IS_ERR(unilist))
> >               return PTR_ERR(unilist);
>
> a 16bit value times sizeof(something).

So since it's already using array_size here, moving it to a new helper
for consistency just makes things clearer, and so you are fine with
the patch?

Otherwise I'd think you are been a snarky asshole to a coworker.

Dave.