Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Received-SPF: Pass (mail2-relais-roc.national.inria.fr: domain of
  julia.lawall@inria.fr designates 128.93.142.36 as permitted
  sender) identity=mailfrom; client-ip=128.93.142.36;
  receiver=mail2-relais-roc.national.inria.fr;
  envelope-from="julia.lawall@inria.fr";
  x-sender="julia.lawall@inria.fr"; x-conformance=spf_only;
  x-record-type="v=spf1"; x-record-text="v=spf1
  ip4:128.93.142.0/24 ip4:192.134.164.0/24 ip4:128.93.162.160
  ip4:89.107.174.7 mx ~all"
Received-SPF: None (mail2-relais-roc.national.inria.fr: no sender
  authenticity information available from domain of
  postmaster@zcs-store9.inria.fr) identity=helo;
  client-ip=128.93.142.36;
  receiver=mail2-relais-roc.national.inria.fr;
  envelope-from="julia.lawall@inria.fr";
  x-sender="postmaster@zcs-store9.inria.fr";
  x-conformance=spf_only
Date:   Thu, 2 Nov 2023 22:27:55 +0100 (CET)
From:   Julia Lawall <julia.lawall@inria.fr>
To:     Anton Eliasson <anton.eliasson@axis.com>
Cc:     nicolas palix <nicolas.palix@imag.fr>, cocci <cocci@inria.fr>,
        linux-kernel <linux-kernel@vger.kernel.org>, kernel@axis.com
Message-ID: <978265928.4471013.1698960475973.JavaMail.zimbra@inria.fr>
In-Reply-To: <20231003-coccicheck-v1-1-07d2d900a52a@axis.com>
References: <20231003-coccicheck-v1-0-07d2d900a52a@axis.com> <20231003-coccicheck-v1-1-07d2d900a52a@axis.com>
Subject: Re: [cocci] [PATCH 1/2] scripts: coccicheck: Return error from
 run_cmd_parmap
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Thread-Topic: scripts: coccicheck: Return error from run_cmd_parmap
Thread-Index: /FuP+QpGx8nmd9ShkUiiXS4mQsbSqA==
Precedence: bulk


----- Mail original -----
> De: "Anton Eliasson" <anton.eliasson@axis.com>
> =C0: "Julia Lawall" <Julia.Lawall@inria.fr>, "nicolas palix" <nicolas.pal=
ix@imag.fr>
> Cc: "cocci" <cocci@inria.fr>, "linux-kernel" <linux-kernel@vger.kernel.or=
g>, "Anton Eliasson" <anton.eliasson@axis.com>,
> kernel@axis.com
> Envoy=E9: Mardi 3 Octobre 2023 16:25:14
> Objet: [cocci] [PATCH 1/2] scripts: coccicheck: Return error from run_cmd=
_parmap

> Exiting on error breaks the chain mode. Return the error instead in
> order for the caller to propagate it or in the case of chain, try the
> next mode.
>=20
> Signed-off-by: Anton Eliasson <anton.eliasson@axis.com>
> ---
> scripts/coccicheck | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/scripts/coccicheck b/scripts/coccicheck
> index e52cb43fede6..95a312730e98 100755
> --- a/scripts/coccicheck
> +++ b/scripts/coccicheck
> @@ -153,7 +153,7 @@ run_cmd_parmap() {
> =09err=3D$?
> =09if [[ $err -ne 0 ]]; then
> =09=09echo "coccicheck failed"
> -=09=09exit $err
> +=09=09return $err
> =09fi
> }
>=20

I tried disabling OCaml in my version of Coccinelle and then ran make cocci=
check with this patch.  But I didn't see any improvement.  On the other han=
d, it keeps going if I just remove the exit line entirely.  Is that what is=
 wanted?  One can still see the coccicheck failed message.

julia

> --
> 2.30.2