Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <3ca2b0ed-6732-4fc4-a5fe-1846b873b02c@intel.com>
Date:   Thu, 2 Nov 2023 14:34:19 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] x86/resctrl: Fix unused variable warning in
 cache_alloc_hsw_probe()
Content-Language: en-US
To:     Tony Luck <tony.luck@intel.com>, "Moger, Babu" <babu.moger@amd.com>
CC:     "Yu, Fenghua" <fenghua.yu@intel.com>,
        Peter Newman <peternewman@google.com>,
        "x86@kernel.org" <x86@kernel.org>,
        Shaopeng Tan <tan.shaopeng@fujitsu.com>,
        James Morse <james.morse@arm.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "patches@lists.linux.dev" <patches@lists.linux.dev>
References: <20231031220534.37730-1-tony.luck@intel.com>
 <d47235e0-7ecd-483e-82c3-78f13c77df67@amd.com>
 <SJ1PR11MB6083C14236AC0AFCB49DFB15FCA7A@SJ1PR11MB6083.namprd11.prod.outlook.com>
 <9e6a979a-48db-4b25-884f-ac8d4c2bb078@amd.com>
 <ZULCd/TGJL9Dmncf@agluck-desk3>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <ZULCd/TGJL9Dmncf@agluck-desk3>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YzBER0RHNlJoa2tGV1RPUjVsbk5tUGJCYVNJSTg4aC9GRnBHam8ySjVhQTRv?=
 =?utf-8?B?c1VkbzVLTHFJUmEvZXBZam1TK3JyNXRmSmREOHpINmpnaDdPUGhtU0hyd1dm?=
 =?utf-8?B?RFA4OXNqa1hXcTBlYTZycDRxQTRTbzRhdFpkV3h0aThzT2NhVHZwdTB3cklO?=
 =?utf-8?B?YlNwUy81b2pSYU5QU3h2aFY3VHFHNjhBQnBMRnA4VXMwQzZwTkZzSTFodmtz?=
 =?utf-8?B?Z1Y4SEp0dlpvb2hndmRZTWdrMTNDdHVGd0lweEdHZ3oyYzZWanYzcFFwdVRD?=
 =?utf-8?B?U1Z4WXp3bVNONUhNeUJ2WGRuODRkYkllVWNhcnhjb1NlVFZpYzN4Q1M3MENp?=
 =?utf-8?B?SGEzVjhub2VNbThvNGxnbzZNcnNwa2gyQ3Q3YWp6V2Jma1BnN3pEM3JUVlNI?=
 =?utf-8?B?eE4yb1VJZllsc25nM01PUnc0VCtqd0xoWE5xR0Jvb2tCTU5JTGxUb0E5alVq?=
 =?utf-8?B?QUZIdzF1Z1QzYloyNjhYaFRpeGNadkhON2ZnK1NZN0hvY3M1WWdEWDNQSzNk?=
 =?utf-8?B?UW55K0lnNVkzcDJFbDV2WkdUNnAvT1NVWm4vSlJha3lTTkZRc0lsV3BncUJy?=
 =?utf-8?B?WDhLbWFQc0NXUlFFUzFtZWNSenlPa2dydkVCRllyOTZWaTlJOCt5WndONk5M?=
 =?utf-8?B?K2ZON2k4N2V0ZEliMWk1V3F6SU8yeXNETitmcFg3UlpFRmZsT1ZrVy9GbGVu?=
 =?utf-8?B?dVRDSERQanF4YitSdkVBa3lFUWkvWFVYdVpsS0d3Q3NocHByQzh3VVZqSTFI?=
 =?utf-8?B?RTlQKzNnWnJHK0txQlphU1MwWko5M2xMQU1aYVNlVU90d1VNOUhlSStlNHRL?=
 =?utf-8?B?MkpiZW1MM2sxbCsvNm15dFN4Y3J0K2FqVDBac3ZpdmJKNGl5cUtrSjZ0cjh5?=
 =?utf-8?B?dzNYUUc5V0NZMG91bnIzU2VxT0p1SHBXcnRQd2tHeXplWVJrUjQ5TmZzWGNR?=
 =?utf-8?B?NDVHUWxSK2xsYnk3b21oZUxuY3hDMXFSaUFmWmsrak52UGVoUnhiUDNhMnNM?=
 =?utf-8?B?STJCcXBlNTZ0bzR6SkcrSlBnU3JwOHU5K1JRR1VnVDZIajM2NFNLdUhyTk9z?=
 =?utf-8?B?Y2VoTEthT0c2eUd0UmpwMGpKZjViOWx6OUsrYTB3YnMwbC8zem10N2JvbHlF?=
 =?utf-8?B?bWVLWDJKRGx6ZWFhaFJ4ckdKVHIxWXB6SnFGNWZLR1QwTU1KTGxXR3Q5WUVK?=
 =?utf-8?B?MzFKSmVvTGZYWmQxenlMTmJRQWszbFpKRWRsNFQzUXNBNkpvTTVqUEdDQ2d5?=
 =?utf-8?B?OGdsQW1xSlRSZWEwYXc2RzhPNCtSLzNrSVVGeUl5VGcxYkNYUys3NDNUT01m?=
 =?utf-8?B?clNXY3EzNUlPL29qMitWckR6VUpVdUdDN3JiNE5sdk5wOUl1STRpY1VOc293?=
 =?utf-8?B?cmtEeU8rYlpSTGh1RUN5NVc3TEVjQkJIWlAyd0pkWFNwOHowTnNmc3U0SGd5?=
 =?utf-8?B?MmczdHk3M3UyMXUzcENvVjVZYnBZZ2RWVzZ4eXNEbFlDZGwwRWw2RDBNWmFr?=
 =?utf-8?B?cFE0b0o3QVVzMW56WGx1SzFYQjJ4ZFpQWXZWcFpQZGFwd0dlYjRCS1RPUUJt?=
 =?utf-8?B?ZWVmNW5mM3kyRnB3ZkhjYlg4UVBIQzkzd3lXYWc5T284R0FhN1djVTZWZHd4?=
 =?utf-8?B?dEMzc0tnUmsrbWpJNGF3djFkVUFsRjVrQXVMUFMxUEIzeVZQdEFIK2pNN01v?=
 =?utf-8?B?eXlhZ1FpMkNQOU1ud0hNa0tJTUcvMXNBR2hON3ZVT3pjZjJtWUc5ak1CUjNv?=
 =?utf-8?B?elhOTVNxRy9BYjJMb3JzV0NXUjgybGRDM0ZMcnU4K3YyZDBtVWF3ZmEvYlVK?=
 =?utf-8?B?N2gydERiQ3JvTjFvcDE2MElSR1ZhSmZhWXZkMDNRM0RmUzkrR1l5Y2FtbmZM?=
 =?utf-8?B?SFNUV3pDTGFxai9DTVM3VERkdzFQTnEvUGlqQmhlb2tibHZ3eGJXZDl2TVVO?=
 =?utf-8?B?RHpaalVMNFBjS2Urc01hQVBmOHF4Qy9JelBCOVpjWXRtMmRCT21FbHpuNVRq?=
 =?utf-8?B?djBuTHY5V0lsZGJhbFZpM0UrU3pIZjd3Z3ozcHdNVEZMa3pBZzA3SElNNmFw?=
 =?utf-8?B?R3ZGaUE1Ri9tYzVoWnJTZ2N5NzNWMUJ4YlBNc20zZXpaWWxDTG9nT3NadWlQ?=
 =?utf-8?B?c0FzUk01WERlc1JvaGJnNEtIZ3JOU21PTmNZMy9jNjg1N3lSTm1NTmdYSmZp?=
 =?utf-8?B?OXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 323f930f-4f46-4b03-550c-08dbdbeb79f4
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2023 21:34:21.5331
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VDMFjET3ENiVpxhTgkTi82R8KZPr96/oypX/jY9+uD8GVOk1Ry2saI7NG+hDqXT4kjNeMxcHItpIWaRBqLj0DWsFGzLPgA/rzV/t3WBbZ+s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR11MB5619
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 02 Nov 2023 14:35:33 -0700 (PDT)

Hi Tony,

On 11/1/2023 2:26 PM, Tony Luck wrote:
> In a "W=1" build gcc throws a warning:

This is strange, I am not able to encounter this warning. Is my gcc perhaps
too old? I know there were some specific versions needed to reproduce similar
warnings with clang (see reference commit 793207bad71c ("x86/resctrl: Fix a silly
-Wunused-but-set-variable warning")).

> 
> arch/x86/kernel/cpu/resctrl/core.c: In function ‘cache_alloc_hsw_probe’:
> arch/x86/kernel/cpu/resctrl/core.c:139:16: warning: variable ‘h’ set but not used
> 
> Fix by switching from wrmsr_safe() to wrmsrl_safe(), and from rdmsr()
> to rdmsrl() using a single u64 argument for the MSR value instead of
> the pair of u32 for the high and low halves.
> 
> Signed-off-by: Tony Luck <tony.luck@intel.com>

I do not know if all the text from that reference commit applies here, but
for what it is worth:

Acked-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette