Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Fri, 3 Nov 2023 06:11:46 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Marian Postevca <posteuca@mutex.one>,
        Syed Saba Kareem <Syed.SabaKareem@amd.com>
Cc:     <broonie@kernel.org>, <alsa-devel@alsa-project.org>,
        <Vijendar.Mukunda@amd.com>, <Basavaraj.Hiregoudar@amd.com>,
        <Sunil-kumar.Dommati@amd.com>, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Yang Yingliang <yangyingliang@huawei.com>,
        Venkata Prasad Potturu <venkataprasad.potturu@amd.com>,
        V sujith kumar Reddy <Vsujithkumar.Reddy@amd.com>,
        ye xingchen <ye.xingchen@zte.com.cn>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Regressions <regressions@lists.linux.dev>
Subject: Re: Regression apparently caused by commit
 088a40980efbc2c449b72f0f2c7ebd82f71d08e2 "ASoC: amd: acp: add pm ops support
 for acp pci driver"
Message-ID: <ZUQssoD2rUHSYQ2v@debian.me>
References: <87a5v8szhc.fsf@mutex.one>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="co0Oi2OYqTcTDchu"
Content-Disposition: inline
In-Reply-To: <87a5v8szhc.fsf@mutex.one>
Precedence: bulk


--co0Oi2OYqTcTDchu
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Aug 03, 2023 at 10:22:07PM +0300, Marian Postevca wrote:
> I'm trying to develop a sound machine driver based on the acp legacy driv=
er.
> The first version of the driver was sent for review on the alsa mailing l=
ist this
> spring: https://lore.kernel.org/all/20230320203519.20137-1-posteuca@mutex=
=2Eone
>=20
> I'm trying to fix some of the issues that were brought up during the revi=
ew back then,
> but when I ported the patches to the latest commit on the for-next
> branch, I noticed a regression where I couldn't hear any sound at all.
>=20
> So I started a bisect session and found that the first bad commit is:
> ASoC: amd: acp: add pm ops support for acp pci driver
> commit 088a40980efbc2c449b72f0f2c7ebd82f71d08e2
> https://lore.kernel.org/lkml/20230622152406.3709231-11-Syed.SabaKareem@am=
d.com
>=20
> If I revert this commit sound works as expected. So I started tinkering a=
 little bit
> with it and I believe that what happens is that the acp pci driver
> enters the autosuspend state and never leaves this state at all.
> I noticed this because if I increase the autosuspend delay to a much
> larger value, then the sound works until that delay passes.
> I added traces and I can see that when the delay expires the suspend call=
back snd_acp_suspend()
> gets called, but the resume callback snd_acp_resume() never gets called.
>=20
> I'm no expert in runtime power management (though I did read a bit on it)=
, so I don't understand
> all the things that happen underneath, but one thing that is not clear to=
 me is who's supposed
> to mark activity on this device and keep it from entering autosuspend if =
the user wants to play
> some sound? Shouldn't there be some counterpart that calls pm_runtime_mar=
k_last_busy() ?
> I looked through the code and can't find who's calling pm_runtime_mark_la=
st_busy().
>=20
> Some help here would be welcome. Is there something missing in my machine=
 driver code, or
> is the runtime pm handling in acp pci driver wrong?

Thanks for the regression report. I'm adding it to regzbot:

#regzbot ^introduced: 088a40980efbc2

--=20
An old man doll... just what I always wanted! - Clara

--co0Oi2OYqTcTDchu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZUQsrgAKCRD2uYlJVVFO
o679AQCRW7cp+WmNFpWYM+EUDNsuXCHFeqjx5LAQzKMRfXv97gD+MuJIGeWYvJ0F
aDSiN4Lbm1Fo2OmQtJcQmT3DZSQ5CAM=
=uyFI
-----END PGP SIGNATURE-----

--co0Oi2OYqTcTDchu--