Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <81376530-ecc7-4457-bfed-2e8b65f69f4e@amd.com>
Date:   Thu, 2 Nov 2023 18:24:33 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] cxl/pci: Change CXL AER support check to use native AER
Content-Language: en-US
To:     Dan Williams <dan.j.williams@intel.com>,
        Alison Schofield <alison.schofield@intel.com>
Cc:     vishal.l.verma@intel.com, ira.weiny@intel.com, bwidawsk@kernel.org,
        dave.jiang@intel.com, Jonathan.Cameron@huawei.com,
        linux-cxl@vger.kernel.org, Smita.KoralahalliChannabasappa@amd.com,
        rrichter@amd.com, linux-kernel@vger.kernel.org
References: <20231102155232.1421261-1-terry.bowman@amd.com>
 <ZUQEa1q/R2KBF/3W@aschofie-mobl2>
 <65441103b3b1b_44d229485@dwillia2-xfh.jf.intel.com.notmuch>
 <65441514c8494_244c8f294af@dwillia2-xfh.jf.intel.com.notmuch>
From:   Terry Bowman <Terry.Bowman@amd.com>
In-Reply-To: <65441514c8494_244c8f294af@dwillia2-xfh.jf.intel.com.notmuch>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZG9NM25xdllHL3loZ0RoSi9TdVEzZWVFRDV5QlBjRHgvM045Y2JhOVJvNGkr?=
 =?utf-8?B?WVBBODBrT0NBWlh1dTVQL3VXVGk1M20vTEpXYTk0M2loN0k3R0UvdW1QRStU?=
 =?utf-8?B?ajlRY21RQTVubEpJL2tEVm9aYjMyTzBXUTloMHlQK05zY2JrVEQ4K01zR1Jn?=
 =?utf-8?B?TlJKOXJrZ0lmMnM1SlNaQ05oMnhMQ1hDSkk3aW5pbDUwT0FMdVVFQXk4djZX?=
 =?utf-8?B?REpTUkJpVytNL0pzYlNjTlJYQlpjdnBQSjRoWThvc3poZSs1N2hQWVN2QjlZ?=
 =?utf-8?B?WUVjemRsWGRSTlZvSkhVWXZKanY1TkdCVFJ6UDRRT25odExvQTZDVXQ4WHE1?=
 =?utf-8?B?Y2lmZWRiMEFucGVTQlJEWFN4dTJXNmRlSnJIWVNEa0l1WlltUGJPUlBUcnlV?=
 =?utf-8?B?ZDhHcmxOV3YrcFNBMFFKR1haQjlZY1QrS0lmTUgrTEoyNmtmcWlOMC9NMEc0?=
 =?utf-8?B?VnpLaFdabDVWTTdHTkgzeUZVYzlYOUlqQWlrWHc4VGVWVUVDL2k5ZjExZXJl?=
 =?utf-8?B?SGJqUnZBZDFiYmdEc1RZRDhuNVlQdXJHelNQSTRNelJBdHV1WXpzVkplYWdz?=
 =?utf-8?B?bTdzWU1xbmpyYjBHM3Q4UXZwTm1KcWExcFExZjZKUmtRcUFvUEhjSjRnakNC?=
 =?utf-8?B?SXFFemgzaXlmNUhjNi9ZY0RsZjIva1ZEMjBESzhhSkpCT244NlFvSkU1VlFV?=
 =?utf-8?B?eEJ5M1lPMU9MMURDQjQyRTVLaWNyb2pxZ0d5NWxJK2dIYVpaT1RuOVN6bHVH?=
 =?utf-8?B?N1o4LzE2RktaVjJqMjViWWhtRWlRbUdGVDUwK0R1bEtDalRDMCtaa1NKSU5I?=
 =?utf-8?B?RSt0RjNxZ1I4RkRwQ09oMWRueU9JdU5hYUVYc3llRXNzQnVPNzNvUVNOZXVG?=
 =?utf-8?B?SjhRR3plQWp3SGV1TWxlN1BqTnk3Z2ZVVjN4N1Zka1I5Q1lIUDROVHg2NEtZ?=
 =?utf-8?B?bzdHUDdRaU5oZ0p6SGVVMjVtOUFKWUIzUkxmN0tGSGVRYnBLV0trWWNIeDkr?=
 =?utf-8?B?azRqdGc0ZXN5VjM3cW5mWnE0V3N3UW9jbXlFTXF4QWZMbXdJY0s0THNrdUkv?=
 =?utf-8?B?REdvWCtYMHNJb0RVY2VJV1RhWVpGV2FHOUtoanhhQVZjTzd4UGVNL0p2NWoy?=
 =?utf-8?B?NzBvckJlcnZOdlhBUG96SW1JZ2tmSStQVzNwZXhlOGtlRVpQcjNxaDNaWERU?=
 =?utf-8?B?YzNPSFc4SWZQMU9waUlBdFFTcjFsbzNFRU01RGI4d043YVNNSkJmSWZHb2hL?=
 =?utf-8?B?WlF6Qi9tLzdtNFRUeTlURThxNCtJeThPWUdxbjZvZHBxUTc1aGFIT1IzdENl?=
 =?utf-8?B?WFp6bUFqNnkrSDRpUWsvSkg2NnhkRkhVMWJkWllzZ3pHTTJuWDhlWEtDZHMv?=
 =?utf-8?B?eC9rbmVMN2k1cWxjeHhBeklFR0RFYm1yNzlacTB2T01KQnlwcHBPYkhNcE5a?=
 =?utf-8?B?TURmZXg5d21pTEpNWXgzaldmSGh4THJnVGtGU1Z1VHlGakVSQmt3ZmpmR3ZU?=
 =?utf-8?B?SC9vUGVQNWJUdWhlOWI5bCt0M2NnNm5WaDY1UUJJdHB5VmJienZlSlRnK3lR?=
 =?utf-8?B?bTlGNVF3QUZHOXpmNFhvTUdTbXZmclhOTzdvMFZ3SmpUaHVScytEYTlDZGhW?=
 =?utf-8?B?ZTNud3poMFlTSHVqNnhRVk05T0FhK0RDZmNaYWxzVWszUkJtZ0FNZU13YkFF?=
 =?utf-8?B?R0F5dTkxWm5WQXJpMFpYSy8zRzR5V0NramZtdjVCT3lqaVdnd1I4TXFVZ0p2?=
 =?utf-8?B?SE02NTJyMHJ1NHcvQjAzeUs4b05PNkF2eFpUVHBDcUppZGg3dUFHMW4rcm9N?=
 =?utf-8?B?U1IwRCtDY1RiVXNOUElNMFJ1NTdvbmo3cG0reWlKc0RWY3dwTFdXZlQxUlNX?=
 =?utf-8?B?aDlLQkpJclBIOFc5VXU5K0Qzd2JKWWVzN0VxSkZwc3dkakZ5UzVYRytFWHNh?=
 =?utf-8?B?S2hIek4zWkRNaEdldjRFZTQxR2loY1F3SGRlWFBWYlpmaUloVkhlU2ZCZnNS?=
 =?utf-8?B?SytQdTVkU08yUUN6ZldTTlUvM3h1QUFPMEMrZ3pSRDdUZ3ExZ3BVQ0lYeWNJ?=
 =?utf-8?B?eGVzcjRBU2QzMXI0UG1LNjRaSnpXWlBYb3dlL1h3SHZtSk0xdGozcDU5Z3hk?=
 =?utf-8?Q?JWG5qe+g6YY4fN8BS4iC0lSDb?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2946139f-8289-48fa-dc4f-08dbdbfae042
X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6390.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2023 23:24:35.5737
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WmJsqVYfrqHa4aOkY9ZZoCKmrHlbPVIJt95em3esUHUeMs97QUkiD+op4Bp3Ove/Q+KnB+YJOenitobIfSMZoA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4099
X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,
	URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 02 Nov 2023 16:30:27 -0700 (PDT)

Hi Dan and Allison,

On 11/2/23 16:31, Dan Williams wrote:
> Dan Williams wrote:
>> Alison Schofield wrote:
>>> On Thu, Nov 02, 2023 at 10:52:32AM -0500, Terry Bowman wrote:
>>>> Native CXL protocol errors are delivered to the OS through AER
>>>> reporting. The owner of AER owns CXL Protocol error management with
>>>> respect to _OSC negotiation.[1] CXL device errors are handled by a
>>>> separate interrupt with native control gated by _OSC control field
>>>> 'CXL Memory Error Reporting Control'.
>>>>
>>>> The CXL driver incorrectly checks for 'CXL Memory Error Reporting
>>>> Control' before accessing AER registers and caching RCH downport
>>>> AER registers. Replace the current check in these 2 cases with
>>>> native AER checks.
>>>
>>> Hi Terry,  Does this have a user visible impact? 
>>
>> Saw this after I applied it. It is good feedback in general.
>>
>> The reason I did not ask for this clarification was that this is fixing
>> brand new code and was just using the wrong flag, so I had the context.
>> A backporter will never need to make a judgement call about this patch.
>>
>> The end user impact is that CXL protocol errors that could be handled by
>> AER will not be handled if Linux failed to negotiate memory error
>> handling. Memory errors are strictly related to memory-error-record
>> events, not protocol errors.
> 
Right, end user impact is RCH error handling will require using native 
memory error/event _OSC control inorder for protocol errors to be logged.

> However, to that point the "Fixes:" tag looks wrong, it should be:
> 
> f05fd10d138d cxl/pci: Add RCH downstream port AER register discovery

Correct, it is f05fd10d138d.

Regards,
Terry