Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <272c0cfc-188a-41c7-9ba1-e1ba0f996298@gmail.com>
Date:   Fri, 3 Nov 2023 09:09:28 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] docs: translations: add translations links when they
 exist
To:     Vegard Nossum <vegard.nossum@oracle.com>
Cc:     alexs@kernel.org, carlos.bilbao@amd.com, corbet@lwn.net,
        federico.vaga@vaga.pv.it, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, siyanteng@loongson.cn,
        src.res.211@gmail.com, Jani Nikula <jani.nikula@linux.intel.com>,
        Akira Yokosawa <akiyks@gmail.com>
References: <20231028162931.261843-1-vegard.nossum@oracle.com>
 <0e003343-3c64-4fee-a56f-987a4ef6e336@gmail.com>
 <378b0571-a89b-43a2-8921-3f23afa0f254@oracle.com>
Content-Language: en-US
From:   Akira Yokosawa <akiyks@gmail.com>
In-Reply-To: <378b0571-a89b-43a2-8921-3f23afa0f254@oracle.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 2023/11/02 20:07, Vegard Nossum wrote:
> On 01/11/2023 15:56, Akira Yokosawa wrote:
>> It looks like this introduces hysteresis in successive runs of
>> "make htmldocs" and "make latexdocs".
>>
>> Steps to reproduce
>>
>> =C2=A0=C2=A0 1. Run "make cleandocs"
>>
>> =C2=A0=C2=A0 2. Run "make htmldocs"
>>
>> =C2=A0=C2=A0 3. Run "make latexdocs"
>>
>> This aborts with the message (under Sphinx 7.2.6):
>>
>> =C2=A0=C2=A0 Extension error (translations):
>> =C2=A0=C2=A0 Handler <function process_languages at 0x7f122f343420> fo=
r event 'doctree-resolved' threw an exception (exception: 'LaTeXBuilder' =
object has no attribute 'templates')
>> =C2=A0=C2=A0 make[2]: *** [Documentation/Makefile:128: latexdocs] Erro=
r 2
>> =C2=A0=C2=A0 make[1]: *** [/linux/Makefile:1695: latexdocs] Error 2
>> =C2=A0=C2=A0 make: *** [Makefile:234: __sub-make] Error 2
>> =C2=A0=C2=A0 Command exited with non-zero status 2
>>
>> If I run "make latexdocs" in step 2 and "make htmldocs" in step 3,
>> both runs complete successfully, but html pages don't have the
>> expected links to other translations.
>>
>> All I can do is to report the symptoms.
>> Vegard, can you look into them?
>=20
> Thanks for testing this out and reporting!
>=20
> I think we can fix this by moving the "is this html output?" check from=

> the TranslationsTransform into the 'doctree-resolved' handler (which, a=
s
> far as I can tell, runs after the doctree has been serialized to disk
> but before output is generated).
>=20
> I've attached an incremental patch, does that seem to work for you? I> =
test both (clean/html/latex + clean/latex/html) and it seemed to work her=
e.

Yes, it works here as well.

        Thanks, Akira

>=20
> I had a look at using a custom "visit" callback that would just render
> the HTML in place instead of manipulating the doctree, but it also
> doesn't feel right as then you need to specify callbacks for every
> output writer; there doesn't seem to be a way to ignore the node by
> default. Maybe I should ask on the Sphinx/docutils mailing lists what
> the "proper" way to do this would be.
>=20
> Thanks again!
>=20
>=20
> Vegard