Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <bd888ca8-39e8-0e68-9bb5-566ef91cee24@amd.com>
Date:   Thu, 2 Nov 2023 17:30:51 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH RFC v3 5/6] firmware/efi: Process CXL Component Events
Content-Language: en-US
To:     Ira Weiny <ira.weiny@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Jonathan Cameron <jonathan.cameron@huawei.com>
Cc:     Yazen Ghannam <yazen.ghannam@amd.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Dave Jiang <dave.jiang@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Ard Biesheuvel <ardb@kernel.org>, linux-efi@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org
References: <20230601-cxl-cper-v3-0-0189d61f7956@intel.com>
 <20230601-cxl-cper-v3-5-0189d61f7956@intel.com>
From:   Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
In-Reply-To: <20230601-cxl-cper-v3-5-0189d61f7956@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MWYrYU9NWi9Oc2xhWHlZZ1hwRzJWNkplcjNqdmg4K2hMVzQvRHR1cnIzVFd6?=
 =?utf-8?B?dmMyZExvNlRMUElUbGxZdG5uUU1EMU5ibDUxazZMazVJQ0g4MzRLWmVCYlJJ?=
 =?utf-8?B?Z0R0OGM0MlNtOTlMWlZQUjFValdYcEhKTGo2QTZiNlQwV2VFWmVqbC94TkNm?=
 =?utf-8?B?YkRrUVdkRWJTank5YS9OcGZGbGl5aWlNbytkNFVTZGtrWjErQURBWmY3bkJP?=
 =?utf-8?B?RFl2VHhvUVd0TE0rcGxRcUJ2NTJEM2xlQTBqL21yc2hEQWV1eFU0eStoUGlw?=
 =?utf-8?B?a2FweWJuTTAvZ3gwS2RJYUJCdFR4bXY2S3JOZHpuYTU2eGphTE5ld0JjeEVt?=
 =?utf-8?B?azFiUEVYdHpMUlpWQThtMys2alhDTFRNQzBvRXZONi9DVitsclhPTnBSdmxX?=
 =?utf-8?B?aUl1emhJUnVrZWNOTENZd2ZrdnBUQ3NHbFBUQTVSZ2dCdXBiMktGT3FrN2pU?=
 =?utf-8?B?ZTRYbnNQVTFsdFgzVFJxUUxUNTFRMi9hb293UlhXR2dyK1ZyQ1NrSkdOenZX?=
 =?utf-8?B?MmNjNUJrZmdTQTRmNzgwaXlsZXpHYzVsd3ViV2Z6NkZDRXE1WUNWMysvUlZY?=
 =?utf-8?B?b1lNQUxrSndVWGtnZWpxMHFvT0hOaFFJUEMzUTRZVWQxdWJKNEVTSm1CQWR1?=
 =?utf-8?B?WHdiUkVzam1wS0x5cFozMGFsZ09LV1h4SkJOT0pRVVduL3FmV1F1TjJtRExz?=
 =?utf-8?B?TEMvNDNXMU0yZHQrY3B0MkgzRVREMkREV2VHTXdCazR2bTIzeGxBQkJDd0la?=
 =?utf-8?B?Q3pBMVJQSGdxMWd1Sk4vNUJVbnJDNzhybWlFcytxZUkzeFpuZjdzbE1XTE55?=
 =?utf-8?B?dURhdmR4WG90SmU5L205M0MvWGRvMnROSk41eVRVL1NTbmdKQ3cwM0dURCtG?=
 =?utf-8?B?ODNqVDJyaWxEQjIzdVhZL1ZLS053VTh0ekdLcnJXZWVjL0l2MnZEK0N1ZUdm?=
 =?utf-8?B?SVRxOFhkYUszQUg0emJtQnpOUkpEMzloRitQc0c2Szgzd1QyMU00MVBoY3BP?=
 =?utf-8?B?SXExM2I3Wk14OWk5Znc3RjlDekU5MWxlUVN0SG01RE5WTTNiQ0cxNFFPTUZt?=
 =?utf-8?B?ZE8xYkU2c2xkWnR6dmkwUEtFWExGbXh6YytvZktCUEJRNktzRlFCT2Vta1Q5?=
 =?utf-8?B?M0xTbi9idXZEaFgrMDN2YVpGZTBpWVJoUmdIN1JBenBQRGhLdjNsZDdtVEhX?=
 =?utf-8?B?Mit6R0Z4MHZLSlZUMENpNkV5a05QR29kU0MvaHYwVWFaUXN4OFhwc2E2azM2?=
 =?utf-8?B?dThFcTJjV1RWUzJvUFppaEZnb2oxYzVacGpzVUlXOHd6ZmZvVVhXOUh5TkZJ?=
 =?utf-8?B?Sy9WSUxXREJjVDFWM2ptY0h3ME1vMnJ5bG1QSjRmL3pnT3VpQWdnNDM0QStq?=
 =?utf-8?B?d05zRndMSVU4dFowMkxrSFIvUUlMa3VzOUxWRkNMdFNTRzRCVU9ZTjIzZTRQ?=
 =?utf-8?B?UHo2SDBvWkJoVk1mSGVTdFlTVXQzN3ZqTHJFOWovcjVicXJGK0NKd3hZL0Jy?=
 =?utf-8?B?LzJUcVZmVUJDei9yMEFoTUl5MnhiVzNPaUlhb2l0M3FkTXNDeGR3bzFaZTdK?=
 =?utf-8?B?d3A3TSttSnFoQnpYTkM1UCs2YnNud2NRaEhSakNaZTZ0UzlUWGJucFgvdG1H?=
 =?utf-8?B?Z0ZJTW50aTNtdEJsOFlEaG4yRTQ5bXA1ZFR3a1l1QTNWaEIyM2I3dTIxN2hn?=
 =?utf-8?B?VHp4cUtLOEJ4UWxoQTBRWHdBdEFWWlJNT1FURWhkb2xYNi9IN25vMWpMSW9p?=
 =?utf-8?B?aldkdTNCU1VTYlQrYkJjejdCTWhtS1V6cU1DaUd0MGNOT2IrT2xXYS81RUtH?=
 =?utf-8?B?NXVaYUlHTStZbDk4UVZsTGovSDdaNEFlRFROMC9SMFQ1OU8wWENuVUhoZmdD?=
 =?utf-8?B?L1Fmb1hlTnVTdEdpd21SWmlFWWVKdUdsTE1hSDNlcGdaS2J2eFAveFZmQlNF?=
 =?utf-8?B?cmo3ci9nZEJLL1ZSaC8rc1h6dk5WYWFhNUNTMVdyVmNkdW1mSENkMUNZVXdl?=
 =?utf-8?B?MnhTekp1QTU0L2VnMlhtMy9qRTRiWG9IS0tqaitQZE9vWWVHR3dTUDhLTVlj?=
 =?utf-8?B?SGNqSmVGQmE5ekl5TmJrcmlOZGhuS2JmU2t0dmI3SGY4VUE1TEwrV21ST2Rt?=
 =?utf-8?Q?UeTaDoQVCOcdhccLE9bttIL/0?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 652ec45d-1115-4d21-1f20-08dbdc042337
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2023 00:30:53.4121
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mPhZjM3+qDDFHdEIMdeFUfBtCj1FfuEeKMTX4wSsW76NpVJC013FTYC/Z0+JO2CDbsSnjsiCJhj0BDqUcYsdOg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7010
X-Spam-Status: No, score=-5.0 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 02 Nov 2023 17:31:25 -0700 (PDT)

On 11/1/2023 2:11 PM, Ira Weiny wrote:

[snip]

> diff --git a/include/linux/cxl-event.h b/include/linux/cxl-event.h
> index 6b689e1efc78..2bdadde80f1a 100644
> --- a/include/linux/cxl-event.h
> +++ b/include/linux/cxl-event.h
> @@ -108,4 +108,53 @@ struct cxl_event_record_raw {
>   	union cxl_event event;
>   } __packed;
>   
> +enum cxl_event_type {
> +	CXL_CPER_EVENT_GEN_MEDIA,
> +	CXL_CPER_EVENT_DRAM,
> +	CXL_CPER_EVENT_MEM_MODULE,
> +};
> +
> +#define CPER_CXL_DEVICE_ID_VALID		BIT(0)
> +#define CPER_CXL_DEVICE_SN_VALID		BIT(1)
> +#define CPER_CXL_COMP_EVENT_LOG_VALID		BIT(2)
> +struct cper_cxl_event_rec {
> +	struct {
> +		u32 length;
> +		u64 validation_bits;
> +		struct cper_cxl_event_devid {
> +			u16 vendor_id;
> +			u16 device_id;
> +			u8 func_num;
> +			u8 device_num;
> +			u8 bus_num;
> +			u16 segment_num;
> +			u16 slot_num; /* bits 2:0 reserved */
> +			u8 reserved;
> +		} device_id;
> +		struct cper_cxl_event_sn {
> +			u32 lower_dw;
> +			u32 upper_dw;
> +		} dev_serial_num;
> +	} hdr;
> +
> +	union cxl_event event;
> +};

Do we need pragma pack or similar for alignment here?

Thanks,
Smita

> +
> +struct cxl_cper_notifier_data {
> +	enum cxl_event_type event_type;
> +	struct cper_cxl_event_rec *rec;
> +};
> +
> +#ifdef CONFIG_UEFI_CPER
> +int register_cxl_cper_notifier(struct notifier_block *nb);
> +void unregister_cxl_cper_notifier(struct notifier_block *nb);
> +#else
> +static inline int register_cxl_cper_notifier(struct notifier_block *nb)
> +{
> +	return 0;
> +}
> +
> +static inline void unregister_cxl_cper_notifier(struct notifier_block *nb) { }
> +#endif
> +
>   #endif /* _LINUX_CXL_EVENT_H */
>