Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754368AbXKXPgR (ORCPT ); Sat, 24 Nov 2007 10:36:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751938AbXKXPgD (ORCPT ); Sat, 24 Nov 2007 10:36:03 -0500 Received: from relais.videotron.ca ([24.201.245.36]:47532 "EHLO relais.videotron.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751312AbXKXPgB (ORCPT ); Sat, 24 Nov 2007 10:36:01 -0500 MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: TEXT/PLAIN; charset=US-ASCII Date: Sat, 24 Nov 2007 10:35:44 -0500 (EST) From: Nicolas Pitre X-X-Sender: nico@xanadu.home To: Pierre Ossman Cc: Andre Haupt , lkml , kernel-janitors@vger.kernel.org, Andre Haupt Subject: Re: [PATCH] sdio_uart: fix sign of paramter status in sdio_uart_receive_chars() In-reply-to: <20071124153650.27a572a6@poseidon.drzeus.cx> Message-id: References: <11956448251191-git-send-email-andre@bitwigglers.org> <20071124153650.27a572a6@poseidon.drzeus.cx> User-Agent: Alpine 0.99999 (LFD 814 2007-11-14) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 839 Lines: 26 On Sat, 24 Nov 2007, Pierre Ossman wrote: > On Wed, 21 Nov 2007 12:33:45 +0100 > Andre Haupt wrote: > > > I think, the status paramter should be unsigned. Is this correct? > > This also fixes a sparse warning about different signedness. > > Only compile tested, because i do not have the hardware. > > > > From: Andre Haupt > > Signed-off-by: Andre Haupt > > Nicolas, does this seem correct to you? I'm not familiar with the > serial stuff. Yes, that should be fine. Acked-by: Nicolas Pitre Nicolas - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/