Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   Besar Wicaksono <bwicaksono@nvidia.com>
To:     Ilkka Koskinen <ilkka@os.amperecomputing.com>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Robin Murphy <robin.murphy@arm.com>,
        Will Deacon <will@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Raag Jadav <raag.jadav@intel.com>
CC:     "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] perf: arm_cspmu: Reject events meant for other PMUs
Thread-Topic: [PATCH] perf: arm_cspmu: Reject events meant for other PMUs
Thread-Index: AQHaDescIVtwfbYixEa1fBHa2Td+xbBn2knA
Date:   Fri, 3 Nov 2023 02:14:27 +0000
Message-ID: <SJ0PR12MB5676C2514A46721EB8D60505A0A5A@SJ0PR12MB5676.namprd12.prod.outlook.com>
References: <20231103001654.35565-1-ilkka@os.amperecomputing.com>
In-Reply-To: <20231103001654.35565-1-ilkka@os.amperecomputing.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3muSJm/EBwBanmb17f+kUK0Eed6DbYVcXvzN7RZusUpdewDXxIHEF/4A4UXX?=
 =?us-ascii?Q?0v+Lhu0zh+AIn0bKxCAC2OfqoNqe0LfNwibNpMtXiZkSes3Gr+IFy141ev/U?=
 =?us-ascii?Q?cdN7O0dsjQMbYIFAzeL47rcuIAoRWL51iOWWDB6ZYRrzYK+lgPcXO2Sm6vdV?=
 =?us-ascii?Q?Un91o7/fE7jdyATEoIAw8NzlcyZ3VAaYqjcesdJKOSZAJDC6PJ7ZnbJbjggr?=
 =?us-ascii?Q?DLWIkJzSTfGYl47lolRnxePc1n6euvXGRhjwLZQI2AyFSOBmihTYAbK1wUHt?=
 =?us-ascii?Q?+4ODbdPEWROk41ZZ4EWlmtZzUUBw4mlTcfXJiVJvEYaLpeS1e9zK97tQdpF1?=
 =?us-ascii?Q?XeLCEZDzPneUI43lGCKdPm9XgOWxNHNGu82kOXYpff+7TDEyr8yOIBhRKuQ6?=
 =?us-ascii?Q?TwnHQ9rkxfIovQX/M6HJpUrwg2p5zXtvkcDNRJz5CeKK+hKfF00YjeeJwMYd?=
 =?us-ascii?Q?OtMi00d8xVnKJRP7WXL+Z+mFmEosg2cjPm3HzlG8L3jRxHnZqrxTAsZ603/W?=
 =?us-ascii?Q?oaw8EOzAofW6hrsmKzbggbLUqUG8eCoEnNNPnhcieXrqC5AdsI+/JgEl/HcC?=
 =?us-ascii?Q?Ai5Nefv2R8kyQeDdP5+ZmfgRy9hXFRqLlH5svkz+21gU7jxKDh+g++2BTQWO?=
 =?us-ascii?Q?1SrYH0fqWgOarpiAcOaACch3Exn+39+9KoxpYihG8MvDnPptqJ3JarMqZbW0?=
 =?us-ascii?Q?yhQte8vJOxHBDVfeXTQR5yq9K+qwEVgnJDXj14xOUP9tIsEDbHXSz10G8q7w?=
 =?us-ascii?Q?rWqB2VDMA7hQ7trmynb4FlYn2ZD7TwSGPYMCC0JRFoto4Nh2VP5NvXeg50st?=
 =?us-ascii?Q?VJ1FzsxDgxF4p0Z0HJMb8FUh7KJV6HYWPkScVXF+U7W1RJ7Wcywcl+9vHO3c?=
 =?us-ascii?Q?jRDcrT8qU0tL3QDX9afCUmSQLAko5KN4XihU0vt9v7gl9cRJluX0vL0doBjn?=
 =?us-ascii?Q?1BAyuUrGyLx5ZlcFr/ILSXVhOG+gsPd7b+vLe/5u/CT4b0ELLHcD4tqc/+qE?=
 =?us-ascii?Q?3XkffA9nFOoDo2raf6CMckH/IK4lMrd27/p457gGAfHOJ4tn4a3rgU5ONyiv?=
 =?us-ascii?Q?pQmyDoISnObOh31ZfLIWG/tku4LNRNGIN1HLUQ85MxnHnIjRLR1+hDmjX0XV?=
 =?us-ascii?Q?op3XxuewCMsV+tQavlzkstcl+jJtjvfJ7s/uZMvGVN3E66Z9Xr8nBPXx2gT8?=
 =?us-ascii?Q?+Wh8/Tdl6DFLrNm9Erl79WbgqgTKQ6xWGBilIuKFQZbRlrofg/03WYzzmAkj?=
 =?us-ascii?Q?LPNcYUkBYKJuWFzZWFhog26JeZdh9M3zpwKTbfqhss5/BPNhWmImgo/5qt+g?=
 =?us-ascii?Q?+jLO3CzYTnxrqNCBoBKfaLqrq5t1CtzWoF4eQ5PHjZdRlx57mJqjJ32COOpQ?=
 =?us-ascii?Q?jaO8i3EU+quMhnsOJ/7AAm4VERHi+S3OzaMIWq2MQHOLE3KYMckbb5huMcKB?=
 =?us-ascii?Q?yvdpYeIqtd1bzIAxqsMEZMW3jr/VZcIkGqZYV/uLGlGETfyaCcYhA5RYPJp5?=
 =?us-ascii?Q?f3TZDN4hmSyGdxjO5BP5PilLdn34p+ZmP+klUVvYOjuED/5qXMS/j0XedlZJ?=
 =?us-ascii?Q?2WWcLKAa1W4kNrLNSQA1TdgZdkNnWMP0qZcZY7um?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR12MB5676.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b7ec6963-1455-402f-9a42-08dbdc129b93
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2023 02:14:28.0397
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bOk0wbAgqdiBFSjZGIxYpbG4N/6xKhgT5CEAqB+KezNiChUvoZj57t9+ECqN7PMFLxdbUGdKM5BNRVfs2E/kfw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6752
X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 02 Nov 2023 19:14:39 -0700 (PDT)

Hi Ilkka,

Thanks for fixing it.

Reviewed-by: Besar Wicaksono <bwicaksono@nvidia.com>

Regards,
Besar

> -----Original Message-----
> From: Ilkka Koskinen <ilkka@os.amperecomputing.com>
> Sent: Thursday, November 2, 2023 7:17 PM
> To: Besar Wicaksono <bwicaksono@nvidia.com>; Suzuki K Poulose
> <suzuki.poulose@arm.com>; Robin Murphy <robin.murphy@arm.com>; Will
> Deacon <will@kernel.org>; Mark Rutland <mark.rutland@arm.com>; Raag
> Jadav <raag.jadav@intel.com>; Ilkka Koskinen
> <ilkka@os.amperecomputing.com>
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] perf: arm_cspmu: Reject events meant for other PMUs
>=20
> External email: Use caution opening links or attachments
>=20
>=20
> Coresight PMU driver didn't reject events meant for other PMUs.
> This caused some of the Core PMU events disappearing from
> the output of "perf list". In addition, trying to run e.g.
>=20
>      $ perf stat -e r2 sleep 1
>=20
> made Coresight PMU driver to handle the event instead of letting
> Core PMU driver to deal with it.
>=20
> Cc: stable@vger.kernel.org
> Fixes: e37dfd65731d ("perf: arm_cspmu: Add support for ARM CoreSight
> PMU driver")
> Signed-off-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>
> ---
>  drivers/perf/arm_cspmu/arm_cspmu.c | 3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/drivers/perf/arm_cspmu/arm_cspmu.c
> b/drivers/perf/arm_cspmu/arm_cspmu.c
> index 42b72042f6b3..2cc35dded007 100644
> --- a/drivers/perf/arm_cspmu/arm_cspmu.c
> +++ b/drivers/perf/arm_cspmu/arm_cspmu.c
> @@ -676,6 +676,9 @@ static int arm_cspmu_event_init(struct perf_event
> *event)
>=20
>         cspmu =3D to_arm_cspmu(event->pmu);
>=20
> +       if (event->attr.type !=3D event->pmu->type)
> +               return -ENOENT;
> +
>         /*
>          * Following other "uncore" PMUs, we do not support sampling mode=
 or
>          * attach to a task (per-process mode).
> --
> 2.40.1