Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp202877rdf; Thu, 2 Nov 2023 19:33:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE/qarjfkjIYkTE/agEZObm6H5ZgesBU/mXVQOrcuCMW9tnENvwb57lXnKjau0tPpeKz2Cw X-Received: by 2002:a05:6808:4d2:b0:3a9:9bb6:811 with SMTP id a18-20020a05680804d200b003a99bb60811mr18563296oie.57.1698978813685; Thu, 02 Nov 2023 19:33:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698978813; cv=none; d=google.com; s=arc-20160816; b=a2e98y+25bK4BSXxXPLfPzekaPUd22PesdzSbSR9RCXafUQ6oc7fyF1TAGs8Uw2Nx5 LAz0sRnMDMaor3gvILil8yQE4csq38s/Z36LUwn1buBzC4tCWvzlnQ0nEzDWxd02aBZc PjngSVeOI8xy2cT7rJ1QYYC+nMxCnrqWKwzVqj5cDgyysenNz/WEYBzItIzG6tRM2k1Z lkn59a+BBsolt43uuGbYjzgYUtav3Pk88JuHoTvdze2PkBxh5u0egFk2hSc3l/F+JEBO WiAkhYKSTeVulw+uJFThJqNo1c5Vqp+RnQUvc3ZTHvGNI0EeVUJCZp4SxAQ/h5JgpcnG 4RNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=GRW9zG0IB/fSGCtCbLC+3PQfEOZlH8101jC5mptPKFs=; fh=G4F3UhRisIagsSxDGzsAU7cNBL74FaQmb6eEpiCgTpY=; b=N9p7w3gTtd7Xzz3n/kUozIAGp24RWxkWPJUHxuBlZ6JZcrbRFTL3GYUP67jZh/qErw L/F/K4NbMvfMbhxf5EuZY+M1RAZsRTAduyaRDexA6DYna63WHdJFPt9GOrQzna/h8Q/w DzKTYx2FNEhPZm5sseMxorWA4vJN0DBp6aYZTdxGqsjxFNqyCAoldyiH9BdNJAoWG90a LVNVE7b9wGzbx7pTqopy10nH4yU2y4tNq60lJ1LLuooWPa8IqiMLOz7r0N2iFudSF1l/ 8tQc6YhEzm4FHmSj+rUMURZlHtDRtM/Q6lj3KMaB0LCgedJrYasGXkAJGQQAcx9PHznu czAg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id q23-20020a63cc57000000b0056569ee3ae6si636727pgi.798.2023.11.02.19.33.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Nov 2023 19:33:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 4414D8160382; Thu, 2 Nov 2023 19:33:31 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234788AbjKCCdZ (ORCPT + 99 others); Thu, 2 Nov 2023 22:33:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230190AbjKCCdX (ORCPT ); Thu, 2 Nov 2023 22:33:23 -0400 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4A661A3; Thu, 2 Nov 2023 19:33:15 -0700 (PDT) X-UUID: a1b81360ae14479ebb8ae7d3bb98ee0b-20231103 X-CID-O-RULE: Release_Ham X-CID-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.32,REQID:6ab78e64-c05c-4841-bd7d-646fd518aa52,IP:10, URL:0,TC:0,Content:-5,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACT ION:release,TS:-10 X-CID-INFO: VERSION:1.1.32,REQID:6ab78e64-c05c-4841-bd7d-646fd518aa52,IP:10,UR L:0,TC:0,Content:-5,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:-10 X-CID-META: VersionHash:5f78ec9,CLOUDID:38acf594-10ce-4e4b-85c2-c9b5229ff92b,B ulkID:231103103311LO8N2NZS,BulkQuantity:0,Recheck:0,SF:66|24|17|19|44|102, TC:nil,Content:0,EDM:-3,IP:-2,URL:1,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0 ,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI, TF_CID_SPAM_ULS X-UUID: a1b81360ae14479ebb8ae7d3bb98ee0b-20231103 X-User: chentao@kylinos.cn Received: from vt.. [(116.128.244.171)] by mailgw (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 885977007; Fri, 03 Nov 2023 10:33:08 +0800 From: Kunwu Chan To: tvrtko.ursulin@linux.intel.com Cc: airlied@gmail.com, alan.previn.teres.alexis@intel.com, andi.shyti@linux.intel.com, andrzej.hajda@intel.com, chentao@kylinos.cn, chris.p.wilson@intel.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, jani.nikula@linux.intel.com, jonathan.cavitt@intel.com, joonas.lahtinen@linux.intel.com, kunwu.chan@hotmail.com, linux-kernel@vger.kernel.org, robdclark@chromium.org, rodrigo.vivi@intel.com, stable@vger.kernel.org Subject: [PATCH v2] drm/i915: Fix potential spectre vulnerability Date: Fri, 3 Nov 2023 10:32:57 +0800 Message-Id: <20231103023257.58199-1-chentao@kylinos.cn> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 02 Nov 2023 19:33:31 -0700 (PDT) Fix smatch warning: drivers/gpu/drm/i915/gem/i915_gem_context.c:847 set_proto_ctx_sseu() warn: potential spectre issue 'pc->user_engines' [r] (local cap) Fixes: d4433c7600f7 ("drm/i915/gem: Use the proto-context to handle create parameters (v5)") Cc: # v5.15+ Signed-off-by: Kunwu Chan Suggested-by: Tvrtko Ursulin Reviewed-by: Tvrtko Ursulin Link: https://lore.kernel.org/all/20231102101642.52988-1-chentao@kylinos.cn --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c index 9a9ff84c90d7..e38f06a6e56e 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c @@ -844,6 +844,7 @@ static int set_proto_ctx_sseu(struct drm_i915_file_private *fpriv, if (idx >= pc->num_user_engines) return -EINVAL; + idx = array_index_nospec(idx, pc->num_user_engines); pe = &pc->user_engines[idx]; /* Only render engine supports RPCS configuration. */ -- 2.34.1