Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Fri, 3 Nov 2023 10:18:34 +0530
From:   Wyes Karny <wyes.karny@amd.com>
To:     Doug Smythies <dsmythies@telus.net>
Cc:     'Peng Liu' <pngliu@hotmail.com>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, liupeng17@lenovo.com, lenb@kernel.org
Subject: Re: [PATCH] tools/power turbostat: Fix Bzy_MHz calculation equation
Message-ID: <ZUR7oh8oWyn7/mz2@BLR-5CG13462PL.amd.com>
References: <TYCP286MB214616F6AE3E088C5D781A2EC6C8A@TYCP286MB2146.JPNP286.PROD.OUTLOOK.COM>
 <TYCP286MB21465F970BF56AAE5D0CEB72C6A1A@TYCP286MB2146.JPNP286.PROD.OUTLOOK.COM>
 <002801da0da1$adb83fc0$0928bf40$@telus.net>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <002801da0da1$adb83fc0$0928bf40$@telus.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?w77XORuvM5dmY4dA6G0SkTchdMtBS6wNaDroyJ1+QfjjGbd09o+lEjTDIhlw?=
 =?us-ascii?Q?XAu4axmwWp6EwPD60UY1Pw2a5YXopj4K9g65jXVezl1osrJ9pJKpDXBSKfBr?=
 =?us-ascii?Q?OvUERLEbNEWN1ewVpcaYbtLJyVmmQpgME9z7KGtohOvkiWouTb39setdAvok?=
 =?us-ascii?Q?TaeYRJvCDmknAutROo6XK1tn9ApDqV3xjMOcMIONCC0rSIwYSMiLm408jDPH?=
 =?us-ascii?Q?izVPeB1sipVKDX+suNQRdJmDEcVRxAShFfaxC3TqOiigHpvemVmLV2fwS3JV?=
 =?us-ascii?Q?w8a+JRuRQnwVSadQHmtwjBmNGDZKXBMagxeLDWOCAQfTERykwPrnoMvsSCtw?=
 =?us-ascii?Q?EPIGFpxkx5UBbpvjzqwQtaJGZsigI1Re6Kwqg8Nmw+523viTTUF4CmEL2Qww?=
 =?us-ascii?Q?pRCXwoOGoJwfVoKBO42kt+Y3qcTE3VmiCwBJiF8bNVTKhSZ6Sjc/6By7NiMa?=
 =?us-ascii?Q?fzLPUBpa1HTUMGEBfpxQl4HR36GgcF0zCzAFCt84OrhlVFBgx984oKqdwaMI?=
 =?us-ascii?Q?H2QrdaCDcHlVwmtyj9NzCmW8pW9TDEK6Kbx7FwslFNugqKEBtDe6nQBJOjKX?=
 =?us-ascii?Q?pSf+YjhjofLHpKkSohUzTvfG3o/n8dOXbMexVyM6oAUI2iZtzc7SNTcGEFtt?=
 =?us-ascii?Q?vdFR3WihqM7OyBGpOb+eOtNMzzkKxjbbGz+9/r/VGY/cGe1q2Xbs3+tKUgf+?=
 =?us-ascii?Q?SgooKU7fohCPQ5seAgmu68bedo6aZSvtPALCMtAM3OZzFgM5F1QdLRltljEV?=
 =?us-ascii?Q?sQss5uxOcgcPG/VZlWukMthah6KN3BJtDXaoQmZDKYkK4Q8F+eptmtfC2JXA?=
 =?us-ascii?Q?D06fAzPPO3jHyJyethXz4HZXGILjAJGXaiIedfS43v6VDwMm2Av/zyx2UdA2?=
 =?us-ascii?Q?SMFlfCcc51zjugq+Faa4q6emrUdXtcA35fmtKE10U9lYUAOdJvxXvfGrl3kv?=
 =?us-ascii?Q?DHwWrd/0v/yn+aNt2Cm+c1hGzPMe5PTgw/3JSl8yXe46gLKylY8qabuCZEMs?=
 =?us-ascii?Q?zHRYhCZqYBrtrp9MC3aqpvrqOmg8TNUua2Mev3An+vLY1mK+5jORj1PTHyv3?=
 =?us-ascii?Q?sCHKADp5AAgjeDB5FQ7EEDzIkM2FbT+LzWR/dg+KsZ7FavW6mHa38t63zMsa?=
 =?us-ascii?Q?5e+D8BcXIU9LaSgPbO1PVYVDKapj8tNVD5a9QOiMKSQRDc34UZpYU2lsbXmQ?=
 =?us-ascii?Q?Ht/76Z1coc3T1IBfvfQtKgLT+yZ4yxQpQlRoLiNoWTYsFLpWwyyuT7sIyBNY?=
 =?us-ascii?Q?YIGKrwBtBs6RcBr1Nw95RrpI5YBrQ+57FAksdsXTD0Q8hS/MW0olc7gHnxtq?=
 =?us-ascii?Q?Fjg3ZiWirBmGrDnXryYWdufLu7CN9xGTT6fBsTawZI/zqJ+JR7HmsDqFZbbf?=
 =?us-ascii?Q?RXWQXXAXDhV/kWeFZiBwoI0hgIwVFKPY1VOAaJ2XbFyKUFapcLMaAftUYurk?=
 =?us-ascii?Q?UFU8fg/crmOvQZSJGr4p9gtkY8LZkEEgufEVjhoQWvP1OokqK7wXbjLj2SgY?=
 =?us-ascii?Q?zopFLyZ35nA3wDkKaTCfJcTfJqz7c8rh1CiYjUAGGDFqOfQ21xXhgCGmuJqY?=
 =?us-ascii?Q?fe7dY5y6wxwtIBKytHP7megL3PZWYfk5WLYbNnFe?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f00c2d0-ddf3-49ea-8781-08dbdc282999
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB3876.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2023 04:48:46.1387
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IKldDXhT3gYLcr63utoEs4XvMa52gJwU1zyTDQmDPDqrDgfzfp9ItL6Wmnw4ypAyiLGDjn9589NO3l7kJhT/3w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7343
X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 02 Nov 2023 21:49:15 -0700 (PDT)

On 02 Nov 08:31, Doug Smythies wrote:
> Hi Peng and Wyes,
> 
> Just for your information about your recent "ping"s about your turbostat patches:
> 
> Please be aware that there is rarely any reply. There tends to be about 2 turbostat updates released per year. Your patches are in patchworks [1], as are some others, including an old one of mine from 2023.04.03
> Eventually there will be an update, and hopefully it will include all our patches.

Thanks Doug for the information.

Regards,
Wyes
> 
> [1] https://patchwork.kernel.org/project/linux-pm/list/?series=&submitter=&state=&q=&archive=&delegate=107
> 
> ... Doug
> 
> On 2023.10.29 08:12 Peng Liu wrote:
> 
> > Ping
> >
> > On 2023/10/7 13:46, Peng Liu wrote:
> >> From: Peng Liu <liupeng17@lenovo.com>
> >>
> >> To calculate Bzy_MHz, TSC_delta should multiply APERF_delta instead
> >> of dividing it.
> >>
> >> Signed-off-by: Peng Liu <liupeng17@lenovo.com>
> >> ---
> >>   tools/power/x86/turbostat/turbostat.8 | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/tools/power/x86/turbostat/turbostat.8 b/tools/power/x86/turbostat/turbostat.8
> >> index 8f08c3fd498d..1ba6340d3b3d 100644
> >> --- a/tools/power/x86/turbostat/turbostat.8
> >> +++ b/tools/power/x86/turbostat/turbostat.8
> >> @@ -370,7 +370,7 @@ below the processor's base frequency.
> >>   
> >>   Busy% = MPERF_delta/TSC_delta
> >>   
> >> -Bzy_MHz = TSC_delta/APERF_delta/MPERF_delta/measurement_interval
> >> +Bzy_MHz = TSC_delta*APERF_delta/MPERF_delta/measurement_interval
> >>   
> >>   Note that these calculations depend on TSC_delta, so they
> >>   are not reliable during intervals when TSC_MHz is not running at the base frequency.
>