Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp286222rdf; Thu, 2 Nov 2023 23:53:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGu5BluX20yKw3kVf+FnF33nxIvYwRyL5OO5pbZIvLqKZSKMKusUm7nH7FvqtXWz1yogR9y X-Received: by 2002:a05:6358:94a9:b0:169:845b:3441 with SMTP id i41-20020a05635894a900b00169845b3441mr14892450rwb.22.1698994391239; Thu, 02 Nov 2023 23:53:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698994391; cv=none; d=google.com; s=arc-20160816; b=evxh17g4JbMP+N9MxHSwuKmlP3oNMKgmq+mDmTqNFmjVi6Fl/M3i+BAqhiz0YuqQ08 RJGG5Xzt5JPCzo00e3Lw/l1jsVEeGb5CKeTov5fkJqE79uC5vSfUqwJcIDtaDvP1ElGH xTWEozKnvSDXtfX/eTUnnFn83Oye79gzH/3a6UV4t5UKfvVg17SAh4WMpx0rQLWv0vjq sIPckaccmn/M7Qlf9srujLfQhPlfTJqU9egIALB7x8qur415+2mpi/ayLiX5FqnuVFo4 U9Eg6aDhubpI79sJXYC43CBxwpOc8bb4Tr43M3ErqBJIyqufcQHSk+7SWy/e1VUCANbR pGbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=1DW8wTULyGAnyPBIiNHYRVhm2XRpuOZrSGHTaAuCNVs=; fh=w1SX2EbC4OZTTncuk8qJmhKXjkYtLX0r3g/qmctfLR8=; b=MH4GBMjRlv/Jm7HLZkn2M7O5pH8W1jLLTfhWysvOkUS+RuU2/SnyI/QueNNHd/ShbT vzWs1GjO9piZ86/JYzkogVvWiPqP/2nEVuZMiEvDRvTvJiH6g1dauIH0tp/wARQPhHwM 31hLMCAMTMScidZH1sPfqNhV1YCMAmlqJnaD/sTAIXGanbkrnENkqxWryigkkQ576CnS wrV+3pJQlNz4+TT6Z2kLh9pCkLKmBAbUIrNuR3WAey0EXauGofkKpDaOMhMcCNBDKLPa R6iRzGUgxKnkzUXr9gNDgqYNx9U9Ku9scIUz3TGZwOUtUxR6T5Gw55WbDlD8u8Z6DQCr EVKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pNwHUexF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id s192-20020a6377c9000000b005b9658763f9si1058728pgc.541.2023.11.02.23.53.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Nov 2023 23:53:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pNwHUexF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 3F6898093790; Thu, 2 Nov 2023 23:53:08 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231712AbjKCGxD (ORCPT + 99 others); Fri, 3 Nov 2023 02:53:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231905AbjKCGxC (ORCPT ); Fri, 3 Nov 2023 02:53:02 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 250C9131 for ; Thu, 2 Nov 2023 23:53:00 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC548C433C7; Fri, 3 Nov 2023 06:52:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698994379; bh=zp7GrPGXdsStz32UXCzDWjHX1vrt915ND20H+YhMA7k=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=pNwHUexFiDJtQMpGT71dKooTxXYEOq8zqhpk4QcV7ocJsbx1bLRPXAr7fSaktu4On 49Ks9ok3Yw0+um88DFGiiVbE11WIJg+sU38+bOSD84/HCCnFHJp9PSUW8iyJ91iPV4 90zL7+8KphvfW7alDfED3xo0JM7QpjIzgzUUxupWC3VexLzNqt4iWQGPe/980nJlqq c2+wCJ/3nf9Il5ZgR2K/ZcOu92rN2ehcTi9nO9226qjB66AixHP43RpapTXEUw4qT1 Wknbn+Fw0Gge0EFA0d6qLxjL/YEUfh9IzjMPqiTB7kvpFGbU0Ryz0FvnfzzwGdTrFe W8aZH8oKKZuWQ== Message-ID: Date: Fri, 3 Nov 2023 07:52:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8] rtc: tps6594: Add driver for TPS6594 RTC Content-Language: en-US To: Esteban Blanc , a.zummo@towertech.it, alexandre.belloni@bootlin.com Cc: andy.shevchenko@gmail.com, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, jpanis@baylibre.com, jneanne@baylibre.com, u-kumar1@ti.com References: <20231102132616.1130960-1-eblanc@baylibre.com> From: Krzysztof Kozlowski Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20231102132616.1130960-1-eblanc@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.6 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 02 Nov 2023 23:53:08 -0700 (PDT) On 02/11/2023 14:26, Esteban Blanc wrote: > TPS6594 PMIC is a MFD. This patch adds support for > the RTC found inside TPS6594 family of PMIC. > > Alarm is also supported. > > Signed-off-by: Esteban Blanc > Reviewed-by: Andy Shevchenko > Acked-by: Alexandre Belloni > --- ... > + > +static struct platform_driver tps6594_rtc_driver = { > + .probe = tps6594_rtc_probe, > + .driver = { > + .name = "tps6594-rtc", > + }, > +}; > + > +module_platform_driver(tps6594_rtc_driver); > +MODULE_ALIAS("platform:tps6594-rtc"); You should not need MODULE_ALIAS() in normal cases. If you need it, usually it means your device ID table is wrong (e.g. misses either entries or MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute for incomplete ID table. This applies also to your other driver: pinctrl. Maybe to all your drivers... Don't use MODULE_ALIAS() as substitute for missing tables. Best regards, Krzysztof