Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp321398rdf; Fri, 3 Nov 2023 01:24:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFu0KWYm2usyU+Dvwfvci7WmYbMHBR6H2EEFGtVjpJrcoIHaYVpjnXRwbb1uCexJ9pye87/ X-Received: by 2002:a92:c8c8:0:b0:359:4d0a:e5de with SMTP id c8-20020a92c8c8000000b003594d0ae5demr5449666ilq.16.1698999844636; Fri, 03 Nov 2023 01:24:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698999844; cv=none; d=google.com; s=arc-20160816; b=KIXIiroGrvW/6FrsAVZ78XQwb88LZxjjV9Sk/IXVUtzD3+CUI8ETmFUP1stcMQpzXi 2b03GqRclyt6LEUbbpoEnyTna9d57JKCgUiTQGbFsEi5f/oe9sAAjqh49lOD0662JzYB b+DuUWTsD9zxwfkG/jHcXowM9+JlAb2wpxbg7/y6WlCWpdWEGa21c8CRCYFIeHaQr88y dcjS4vzcwtCn3lUm8FALCdrN9HSqcO90OtVGI8fkANZbNaN5Y11DTVHA3sXFGC8ujCu+ h2oTJtqiYnqA0hXHeKOk2PKaHrjHgWdVtyH4X4AAAf61roF96cBAMWCvA+Ag4epQCWG/ v/ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:dkim-signature; bh=Q6tkvBaYOd/p0ccPPilmEYZxFlUrwaRz6L4g8Xag+Ck=; fh=YM7jJG84Jp6Rn7y6JEh4EXTvqwuHNvkLrrlP0Qw9bTc=; b=Of52saCYETt631363m4ztvp4YS1JgPKcSCl4xBFaZH6QK539iqZpRdGsIR6c+2GPC3 S8UE0bIROW8rrKQDm1dE9idlU4rwhAmpR3yg1YwqNb33TVtfukBs16yVgIXjgFqCBIcw VZaZYb+UFNDfR2zbcq8M4pzeBOSc4dPdR575glxQ+D7aA1fIMa1iJ1DCU610BimNYkzn If+RTv0BRw5HSqxIDRPaXbd6rFX1xy6Mb9Z8yhHu9sePHSUxFZX8XONNT80skoQWyg+y 2Y/46ZT3cRUgvpp5Zx49Rpjct1ivP38S0YhIPMdWlVxdgOtDUtGqctqQGHxUQzkcouHz at5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="Mg0/0Nx2"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id i18-20020aa787d2000000b006c33f9a91aasi1109284pfo.371.2023.11.03.01.24.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 01:24:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="Mg0/0Nx2"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 02423826BBA3; Fri, 3 Nov 2023 01:24:00 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235862AbjKCIXr (ORCPT + 99 others); Fri, 3 Nov 2023 04:23:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235607AbjKCIXq (ORCPT ); Fri, 3 Nov 2023 04:23:46 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBCDD1B4; Fri, 3 Nov 2023 01:23:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698999818; x=1730535818; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=+kaMKIAxrDUWFRDqMEzckWhttZfmRsKXnzhvNoQg/D0=; b=Mg0/0Nx26tpqX+4tvXwu9Xc3RAFtX4Nt3TDqA9FvsT+ZD3LOKki+sM0o v9DnpUighJIKR9/bS+52VZfWs4NXIkMiFB6usoiloi5CKhiKmNqGev3iQ 7idrIUEnl/hbHkJYXuvB44ff1CzzGsNpk/4ZUcagEoM6lAwHNQ1VdWo7J RPSqapRDdCn6cCyfdpg5EZ3tCJAPaDhaQ3OKD0cYHcLHIB1iU0GhG8ZlJ bQGesFRJO27dvAdwYzFT7w43eEJ2SI/Li1TXalHYyJDjrPmapSPlyALTs k59rOhpuW4rhlrcof58ucoixNwWW8sxHuQXjV7mYRUPyN1y20h+L4CWg2 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10882"; a="475141674" X-IronPort-AV: E=Sophos;i="6.03,273,1694761200"; d="scan'208";a="475141674" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2023 01:23:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10882"; a="827417641" X-IronPort-AV: E=Sophos;i="6.03,273,1694761200"; d="scan'208";a="827417641" Received: from sdobbela-mobl.ger.corp.intel.com (HELO [10.213.223.51]) ([10.213.223.51]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2023 01:23:35 -0700 Message-ID: <7ce9eaf8-bb3e-489e-bb62-e99504ebd3df@linux.intel.com> Date: Fri, 3 Nov 2023 08:23:33 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] drm/i915: Fix potential spectre vulnerability Content-Language: en-US To: Krzysztof Kozlowski , Kunwu Chan Cc: airlied@gmail.com, alan.previn.teres.alexis@intel.com, andi.shyti@linux.intel.com, andrzej.hajda@intel.com, chris.p.wilson@intel.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, jani.nikula@linux.intel.com, jonathan.cavitt@intel.com, joonas.lahtinen@linux.intel.com, kunwu.chan@hotmail.com, linux-kernel@vger.kernel.org, robdclark@chromium.org, rodrigo.vivi@intel.com, stable@vger.kernel.org References: <20231103023257.58199-1-chentao@kylinos.cn> <3d633ff6-e5e9-46bc-941a-258540ebbfc4@kernel.org> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc In-Reply-To: <3d633ff6-e5e9-46bc-941a-258540ebbfc4@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 03 Nov 2023 01:24:00 -0700 (PDT) On 03/11/2023 06:56, Krzysztof Kozlowski wrote: > On 03/11/2023 03:32, Kunwu Chan wrote: >> Fix smatch warning: >> drivers/gpu/drm/i915/gem/i915_gem_context.c:847 set_proto_ctx_sseu() >> warn: potential spectre issue 'pc->user_engines' [r] (local cap) >> >> Fixes: d4433c7600f7 ("drm/i915/gem: Use the proto-context to handle create parameters (v5)") >> Cc: # v5.15+ >> Signed-off-by: Kunwu Chan >> Suggested-by: Tvrtko Ursulin >> Reviewed-by: Tvrtko Ursulin > > Where did you receive this tag? There is nothing under link below. >> Link: https://lore.kernel.org/all/20231102101642.52988-1-chentao@kylinos.cn It is fine, I gave the conditional r-b in https://lore.kernel.org/all/d300506c-ab82-4cc1-b750-61e54ec2ad9e@linux.intel.com/. Suggested-by I did not and it is not true so I can drop it while applying. Regards, Tvrtko