Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Fri, 3 Nov 2023 17:59:58 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     "Jain, Ayush" <Ayush.Jain3@amd.com>
Cc:     "rafael@kernel.org" <rafael@kernel.org>,
        "viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
        "Yuan, Perry" <Perry.Yuan@amd.com>,
        "Karny, Wyes" <Wyes.Karny@amd.com>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH] amd-pstate: Only print supported epp values for
 performance governor
Message-ID: <ZUTEnneqNcosb/1R@amd.com>
References: <20231103094815.16141-1-ayush.jain3@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231103094815.16141-1-ayush.jain3@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vjAA2hMZ+0nUblTqxuD+mhGvb3AWbrxgMJ+88OxpEo4OuTLCtAlV80sajIsd?=
 =?us-ascii?Q?Ro+bHNT9D7GJU+jvp/eUjwcQHps3M9jIF9g1y6/jJhHdTUUTbNA2tyMDXgFD?=
 =?us-ascii?Q?S3BFPB45sMulnfEd7AYoTTe/npoKHk59Al2I/kr/JS82Xs9qhQeFNjRQyHF6?=
 =?us-ascii?Q?7KxSPKNkxcIrko1YwLcYQ80LVuacfpnt/JN9+gEvv6T04OXP1C5wc3esHi06?=
 =?us-ascii?Q?TfPGhpqzggJ9H47b+1IL2pdX0b0h8FDWqMMKZ6DL1UZn6O5WYBo+QNIbfX+m?=
 =?us-ascii?Q?1LtV4Sa9Y9RPj6HR0rv7QmbzCMWLUjz1FDHoaS2PCj9U0BLaCnbT5hHMy4Al?=
 =?us-ascii?Q?cg1q+XtpbtP3aCLdvkk2ktBGo0EzWt0BoJwYX6RmA/VHLuniNBn+9b+dV9du?=
 =?us-ascii?Q?Gk3K6x5lntARr71xMQhrpdHPfznFmrp3wqVlcoR9162zg/1aX/ShbN0dgX00?=
 =?us-ascii?Q?xbfhQahd5J8B8sZwmGV4WLDV3lhiE1ZC8EN6H7F634qEcvRmfIVza/o8SO17?=
 =?us-ascii?Q?nTZEXUJSWx/I9hLsA/98RsSh4voikTsfdY1BxjDS9Uxj52e9QBg1RdwxRTXa?=
 =?us-ascii?Q?uHLNz6t7+rRd9vY08Tt4dZVH/xfKBpFskRP37NkDDs1GOFcTJs3Oe7ODaGpB?=
 =?us-ascii?Q?m1NikH5n86V4sPd4mSYy7Ox2S6Cvcr5xIzPStzEYuzauqyjD7egI4o4pesP6?=
 =?us-ascii?Q?aN2fx8cvFpRP7rNz0w++Toxr4odfMuj+6vwKJQI00f0i6T59cApTZziG1947?=
 =?us-ascii?Q?X9XavBlBjP9qOka3MuM1vZQ4Vw/q7vA7nd+ZnYyhdzZL17MaaaKFjfsCBIN/?=
 =?us-ascii?Q?9FxtLyrmg35O9pUQBs88Iz0qpD8KLuzMJusQuYTxCCagkzvXPKKZIF/nT4W8?=
 =?us-ascii?Q?L7DwfnvPkccRaBRPCInDAkHSEEGobIeSnDmpHw9XaGbvCohumI9zKGaRuj2S?=
 =?us-ascii?Q?O43PKXeET4m/ZIWo67/h6gQ9VW6Q+MYV0UeffA8yRNxuLgqs59rJ0P51bHeD?=
 =?us-ascii?Q?EAFFhzxbmEfwlsyzoKU40+n7v15zHbqoUsIPAkjWO2BHrTZcXgLXTC2L3bGw?=
 =?us-ascii?Q?sMfHeoygnDQ1m+inP59AgK8pnDkI1tI86nMmek7BMwnOjft33nEmWmXLltf1?=
 =?us-ascii?Q?uv7dx+6RauXMqhqKlb2neUHjTPb3rjbBGeEmRFcSIhSFAl77/LlwDVvbVW4m?=
 =?us-ascii?Q?kCr8Zc1Ao2c9rmnajh8AaTz451oSX3F+rqT0JW4MXb8nObc7xWlvEACGUov/?=
 =?us-ascii?Q?u8jlYwJh5biuf4oRLXBlLxSS8IFZ6JmGhdnPGZAtFmyv9HjftvC7CFIx5sqd?=
 =?us-ascii?Q?EmvzemtwdBJBGJg3OWaEwS9yBxTFm1LRwZdNgCLy8Ghx0mftUdur8g+oAkeb?=
 =?us-ascii?Q?UCKYzYiU1zgicrDBpKL6XQeJR9W6/5zvzJ+SpzCO+mPz9tA/599yHY8gYPQT?=
 =?us-ascii?Q?JekhNH5oW7eWN2t4YipJxvlxXA7BnveTjpChRT5ay5oWYzz3Zp4aYEXXT5+z?=
 =?us-ascii?Q?pTqK85yCP2yHT7ROv2k02qTrVGMHW6Mh1keHQRH88SeQtoZLJAJxNDHmub4K?=
 =?us-ascii?Q?hzCC9pmh+pwKColyLD1VvgVoQGMFSQbQghII679j?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a2b68d36-4c94-4b7f-a634-08dbdc53af56
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8690.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2023 10:00:18.6464
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vYoBIBB5O7FqNS1kvtEdBI22iReq75ZR/0GUChCCiyg9HyBoULZaJ5UE75NnE3npDqa4bWNfHyg5NNiFfNt+lQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4037
X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 03 Nov 2023 03:00:35 -0700 (PDT)

On Fri, Nov 03, 2023 at 05:48:15PM +0800, Jain, Ayush wrote:
> show_energy_performance_available_preferences() to show only supported
> values which is performance in performance governor policy.
> 
> -------Before--------
> $ cat /sys/devices/system/cpu/cpu1/cpufreq/scaling_driver
> amd-pstate-epp
> $ cat /sys/devices/system/cpu/cpu1/cpufreq/scaling_governor
> performance
> $ cat /sys/devices/system/cpu/cpu1/cpufreq/energy_performance_preference
> performance
> $ cat /sys/devices/system/cpu/cpu1/cpufreq/energy_performance_available_preferences
> default performance balance_performance balance_power power
> 
> -------After--------
> $ cat /sys/devices/system/cpu/cpu1/cpufreq/scaling_driver
> amd-pstate-epp
> $ cat /sys/devices/system/cpu/cpu1/cpufreq/scaling_governor
> performance
> $ cat /sys/devices/system/cpu/cpu1/cpufreq/energy_performance_preference
> performance
> $ cat /sys/devices/system/cpu/cpu1/cpufreq/energy_performance_available_preferences
> performance
> 
> Fixes: ffa5096a7c33 ("cpufreq: amd-pstate: implement Pstate EPP support for the AMD processors")
> 
> Suggested-by: Wyes Karny <wyes.karny@amd.com>
> Signed-off-by: Ayush Jain <ayush.jain3@amd.com>
> Reviewed-by: Wyes Karny <wyes.karny@amd.com>

Nice catch, thanks for the fix.

Acked-by: Huang Rui <ray.huang@amd.com>

> 
> ---
>  drivers/cpufreq/amd-pstate.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 9a1e194d5cf8..e6c5a57662e4 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -850,11 +850,16 @@ static ssize_t show_energy_performance_available_preferences(
>  {
>  	int i = 0;
>  	int offset = 0;
> +	struct amd_cpudata *cpudata = policy->driver_data;
> +
> +	if (cpudata->policy == CPUFREQ_POLICY_PERFORMANCE)
> +		return sysfs_emit_at(buf, offset, "%s\n",
> +				energy_perf_strings[EPP_INDEX_PERFORMANCE]);
>  
>  	while (energy_perf_strings[i] != NULL)
>  		offset += sysfs_emit_at(buf, offset, "%s ", energy_perf_strings[i++]);
>  
> -	sysfs_emit_at(buf, offset, "\n");
> +	offset += sysfs_emit_at(buf, offset, "\n");
>  
>  	return offset;
>  }
> -- 
> 2.34.1
>