Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <AS8P193MB1285D01DE5EEB31FC2A9B928E4A5A@AS8P193MB1285.EURP193.PROD.OUTLOOK.COM>
Date:   Fri, 3 Nov 2023 11:45:19 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] net: stmmac: Wait a bit for the reset to take effect
Content-Language: en-US
To:     Paolo Abeni <pabeni@redhat.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <AS8P193MB1285DECD77863E02EF45828BE4A1A@AS8P193MB1285.EURP193.PROD.OUTLOOK.COM>
 <5a265e5541ab1de2258a6e61bd672ef5fb6be65f.camel@redhat.com>
From:   Bernd Edlinger <bernd.edlinger@hotmail.de>
In-Reply-To: <5a265e5541ab1de2258a6e61bd672ef5fb6be65f.camel@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: AS8P193MB1285:EE_|PR3P193MB0847:EE_
X-MS-Office365-Filtering-Correlation-Id: 10331e06-eefe-41b7-fd21-08dbdc59f0ee
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: F6bo0K0BSbyUI49OYY14HSQL7XJwm/nfWZH9aBJXwtVgAOQ9cGSPHdjVJ6rYANgvPSLlR8Drh0VVkyQa9LHDVmQxZpj2MJbMcQPMgTSmwTugPXrkA4KNNfPB2jMLAXjs6n496OlDaE5KuU/xt0e1W23AsGUZNvGVLb1MBrXQETfFYlkWjCeYDR89GD+liDbk0bfzYQvT3z+EAB0Gb01D8dPEPZJfXfhle5etayRnBPprEHjvdpT7tcOMKw8MweMb2m9AEqR1zQSh02VTDHC1ASuKmwUrVg0Myl+ZbrBWl1RKgq63vzxEj+6kbNRvjUqebBRIPChaEv+eAdi1J/yE8IKAzFnSZatpOuia/9SO0IK3bYjaUUleNoDmkj3WUuXp027nKSDETidcyvusUXdf8NdY8f7W2zretdVJl2tz68tD+WHA83X76yAZ5Z0KU6QUDp8hiFQI963BjI+bdGzq9KjRq1a5zW3Acgy6pC6quvqJsbfh9OeDev2CQtKmeS500DiCX6xCboZIqW/lwPEMdqVXpnJY29FZIGElXj4gU/nRD44/2ke7SrEG1CDlzPqR
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXpBYnBYL3RUeExTVXh0YmFETTZDYTZBTmxsMEllYnZrYW1oQVZZQmVoaEhi?=
 =?utf-8?B?NEFRSW82ZU1LYnBkUnE4UExYYUU0QTBTYnJWVGlVMjFCUjBrWXhEWTAzQ3pI?=
 =?utf-8?B?bERORGdlaklpUDVLSGlzeGYrRjJWZFp6VGVIeFZpWm53U1N0RjlqWmJZcTlF?=
 =?utf-8?B?ck4rTlN6N2FaUWxZOEFpVmUzbExHS3lnVTdVOTZFWCtJVlZ1TDFwZStuaVFQ?=
 =?utf-8?B?T0k4aDQ0YXQvYWhvN0ljQzEwREo0T3N0MTZzZTZUUmNESWVQN3o3WUJWa1Jk?=
 =?utf-8?B?NVIzOEVpQXUrZk1KN0FNQzI2d2ltK3hySmg0Rk1IcXJRZlFCSERMN1FCQVoy?=
 =?utf-8?B?TmQydVBLV2JvT2FjZGRaZGN4VHQ1UU4rZk5CQkt6OXI1SlA4Uzk2UU44MXYy?=
 =?utf-8?B?OHZtK1pjRGI3VEFoYm5SV21scXZxZy96MmlOMEZvczBjZ052bXVmRUVadmpE?=
 =?utf-8?B?SXh6RHJXeUZ0SjdBdXVMQlRQWFpoV2V0TjhXdDkvTS9KWUNhaWowdS9zNFEx?=
 =?utf-8?B?b3RKV09vK1pTUVhXOFpJYlNXa0lzdkNUZ0hYQTNRSHpSYWE2OGhaeU5HVFpp?=
 =?utf-8?B?L0tCVENaemp3RE9VMGhEc1Q5THV1bEZ1bSsxanhyUWhMWWhWWnNKRnFKZHRx?=
 =?utf-8?B?YVQ0eXhuRkpnOTk4ZzhxcWZIcE9kbTF4cDRSUlNzbUFGc0s5VkxuOTc1WHpH?=
 =?utf-8?B?dmFqTHRHSmZKajRqYzdqdTU3UkRYOGtVZnVOdXgwNTQrNkllQjFGVHdJT1Jh?=
 =?utf-8?B?bmJaRW5uSjdPam4vaVBtWVZReDBvSEwwdFhwbmg5NHhackhZYWJmak9XSi93?=
 =?utf-8?B?c3dtemhqK0ZmZGozbFhFOVFpUHkxaFJDNTZQcXBPVHArMU4wRHZ1RkRIL1dk?=
 =?utf-8?B?QjMxakM4TVZIYUxvUFB1bmptMnFOQTlqa0F4Vmk1Z1JvVnM1a3ZzOUt4eCsx?=
 =?utf-8?B?SXJ1Mml3alY3b1F4TG1nY0dMMzJENnQzdnNVNEl0dUhwdUhVS1V3ZjJqeW9M?=
 =?utf-8?B?dEVxTVM2UjNNd0J0THkybm9zanBHMGlzVk8yVXFrS1VGYkg2ZFVKMzdBQ2lN?=
 =?utf-8?B?S2RCUzZFUi8wU1RaR0VjYW1lVThPenQrV1c5d3o3eG5INW1NcHR4Slk5Z1FP?=
 =?utf-8?B?ZkV3aGdqU1JMUkg5dU1SUUFPNmhPeENYQ1hCN1lvM3Ezb2lrZ1lRYW5zMk41?=
 =?utf-8?B?RHp5NThiVDBzckM5RFlhSU56NUtDWnZJcFF0Sy9TcCtyQU9ObFljQ040dTFG?=
 =?utf-8?B?SmVrZjZOY1VLbzlJRHhQTlhpNlFpSm45K0s1VXQ0NElEYTAwaU8zL1F1WTZG?=
 =?utf-8?B?R3owWTJlNFZ4cEFGejVqZ21tRGdsaWZKRDJOUkV6a0tuT01aeVRBQnRjcWhS?=
 =?utf-8?B?eDJpVkovOUcxMldNWWVZRmdEeGxYUStzbWg1eko3VmpRZXNUSmJjRzdyM2ha?=
 =?utf-8?B?OFJrVFh5bGsxSHU3aDRRYXpaWXphZ3RjVUtYaDlMSnlCWWtjdTc5VVB4dFRO?=
 =?utf-8?B?TDhEenpZS1J4aVB0d1FyYndTM2EzOHZKL0srY1luNmlUbUVNZzJ0ekhhZkZB?=
 =?utf-8?B?L0hLVTNCMmI4WG0xVEFvMHNacENlSlRXWWNJMCtBT0NSdVF3S01JTGlRck5V?=
 =?utf-8?B?MU9yaDJVL21XZnBweWJQNTdZMSt2akE5VnpQUi9ZclhzaStmbCtCelJ4MlhC?=
 =?utf-8?B?MWhFUzJ5bzFHd0JGdklYUmZzRTcxckloM0NsOHBEdFI5U0JhT2QzSjVJWXp0?=
 =?utf-8?Q?DnUPmjGjNYLPtECnG4=3D?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-80ceb.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 10331e06-eefe-41b7-fd21-08dbdc59f0ee
X-MS-Exchange-CrossTenant-AuthSource: AS8P193MB1285.EURP193.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2023 10:45:06.0869
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P193MB0847
X-Spam-Status: No, score=1.1 required=5.0 tests=FORGED_MUA_MOZILLA,
	FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 03 Nov 2023 03:45:21 -0700 (PDT)
X-Spam-Level: *


On 11/2/23 12:25, Paolo Abeni wrote:
> On Mon, 2023-10-30 at 07:01 +0100, Bernd Edlinger wrote:
>> otherwise the synopsys_id value may be read out wrong,
>> because the GMAC_VERSION register might still be in reset
>> state, for at least 1 us after the reset is de-asserted.
>>
>> Add a wait for 10 us before continuing to be on the safe side.
> 
> This looks like a bugfix: you should target explicitly the 'net' tree,
I dont understand, did you mean to add "net:" to the subject?
It is already "net: stmmac: ..." or did you mean to send this message to
another mailing list?

> adding such tag into the subj. More importantly you should include a
> suitable 'Fixes' tag.
> 

You mean an informal description of what this fixes?
like
Fixes: Randomly occurring "Version ID not available" messages.

Or do mean to pick a commit where the error was introduced?  I doubt
I am able to do the necessary bisection steps, as this seems like an
issue that was introduced by the initial design.  And I also doubt that
it can only affect the GMAC_VERSION register.
To make that clear, the issue is totally harmless, maybe some performance
degradation but I became aware of it only because I was trying to solve
a totally different issue, and therefore I have looked very closely at the
printk messages, so I spotted the anomaly to tracked it down the reason for
this flaw.

Thanks
Bernd.

> Please send a new revision with the above changes. You can retain the
> already collected reviewed tags.
> 
> Thanks,
> 
> Paolo
>