Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Fri, 3 Nov 2023 18:47:34 +0800
From:   Crescent CY Hsieh <crescentcy.hsieh@moxa.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Jiri Slaby <jirislaby@kernel.org>, linux-kernel@vger.kernel.org,
        linux-serial@vger.kernel.org
Subject: Re: [PATCH v2] tty: serial: Add RS422 flag to struct serial_rs485
Message-ID: <ZUTPxkEbmF3jajQg@moxa-ThinkCentre-M90t>
References: <20231101064404.45711-1-crescentcy.hsieh@moxa.com>
 <2023110127-wireless-candy-c298@gregkh>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2023110127-wireless-candy-c298@gregkh>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yaL4WOO5B/Dl5H+zGGHCNuq0Vr3Ja32gO/MCgs5wGMjhKlAfVqbiRexOZkOj?=
 =?us-ascii?Q?ZSw9lDF/xuTd3UIkICnBmnzVngm2woKYjsLRrEO2d9FSdtxzsfbBQ1/Ob653?=
 =?us-ascii?Q?guMpSJ7wjyRvo8hVrjMMhaQdICt2wWU5RU4ak4iS2d7X0F8giiJQBhJAgvH+?=
 =?us-ascii?Q?6kT39cGHQJcRegyrGkfFvydJD+EQ49serUwQrDBd07HW5aZNrwDvUO+c92V0?=
 =?us-ascii?Q?FoC0+TzRMmVoCucKVQ8HSC/86AUplAYa1nyLuiiGqb3u47yxUVJbfIPmiAA3?=
 =?us-ascii?Q?wdd5xS8DyzL9WXLxR3V8P5IeiivbELRID1gmfb3uXE9ukl9P7+Jjpss9Zm4k?=
 =?us-ascii?Q?d/9venDtpZw5GRWfBGBol3W5G0NAjHsWQ9kaSqFaURd8cIHtBlzSoF2kquqC?=
 =?us-ascii?Q?b2Eb6ghPlwp8inN8CvmSQmmnD4hz4nMqUx76Lkm/CJAl7t1HelhT6I5LboMU?=
 =?us-ascii?Q?i84McGLQUCKPNgFYiaXlcEhforooltpnKKw5+Edb2Mj1ahWpUcaxd2bbSVXo?=
 =?us-ascii?Q?yUSTcgxJyl2lz/Qt/HcnAFcQ5S+FDosmgOC7KOCwqIat1XKGNcOQTJ4mkwth?=
 =?us-ascii?Q?4RFGBaxe6Efr4t+JjO1tG+X6BrxP9umBc/wBwHGguCRh9DhTO9EhH9M0/Mkw?=
 =?us-ascii?Q?0lj3vpkOrgthdi2IRaMDzGoQEjNkHXvBLtgoUK2NegZV+8A9WuJSqhqEh6Qb?=
 =?us-ascii?Q?j/DIwtlESKfGsDG23rpgk8FVxMyaKXuyLKJSGww1Q3moYqoyI3sJZt2XNYD6?=
 =?us-ascii?Q?LuEIlB5z+AYoSqoe157ED1lJo0/QDa84kIvuufM8bWndW4jVtBWgTGeXtT6F?=
 =?us-ascii?Q?Z+PW3/b2x3DFS+feb4u27n4g+4NoHSwaIRanZy2stk+lVYG6Ax7xuWdj18BF?=
 =?us-ascii?Q?fT6QwYrShpuTovtg+BRElTMXFELHhQ8Y0kfLM2vo9wNHjAMxH5/haIgM98ZN?=
 =?us-ascii?Q?nI63zqnX2TOGMnuWHxXu5lPRFIXJHgBdAfptKY2GSAwqQJ38Yd3ebhBkfh2f?=
 =?us-ascii?Q?OGTPtw5H4Pm2kDIztjMMCb1nmb4b/tisSVgDRis95+rHfN76/4Kg4ovnhok9?=
 =?us-ascii?Q?F8wQ0UZRM+uL9MRNKYRONG5ITqmTBC3/qxSqvc9cCUHQYa7Rx+Y/cUrjNMaO?=
 =?us-ascii?Q?ElbEfRXcPL4uyRitpSyr9ERn5aeZtEpCwA55rSRkaSydbxiwmGb08N4CH+5v?=
 =?us-ascii?Q?v9l2ceEZwmJOPkEWPXZZeuf9+1Nd4jDWD9GmWr38PEVTUFn0k9yF9LU1WiyG?=
 =?us-ascii?Q?ErNt0bl+P2Srn7mSHNRvDrUd9Nu+jfphLlkeIdyvQYtkiOhazkBWIc1jYbxQ?=
 =?us-ascii?Q?Rv2bMOL5InsYb8/8K56phf2pARfwbuJiF75PBf0vF9JbbwcOFOSIcprQoIhx?=
 =?us-ascii?Q?ZR7Rcg8vnsPBYow36wE8Ux6Be8JdMSIm1Pnl/sPvIIEnIfPiC7T0QPAP5y+s?=
 =?us-ascii?Q?Xth0Y6D8r8+yHEPws9cv+8jCgJwgt5J4Xly8rsZFbnp27/vR/IXIwKZOElkl?=
 =?us-ascii?Q?MS+wxVXA6HvAZlVkxByhwHh0r3EzzmgEgGzOairHx4ystGGwXwS128+5o0aV?=
 =?us-ascii?Q?v5gcsrmKceKjoK3A5hx5nU6XI2urB+Lbcqq26K9gVan3e4pWbOwUOBpYtqMG?=
 =?us-ascii?Q?Xw=3D=3D?=
X-OriginatorOrg: moxa.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d0c7b049-34d7-4ee3-d32e-08dbdc5a4c2e
X-MS-Exchange-CrossTenant-AuthSource: PUZPR01MB5405.apcprd01.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2023 10:47:38.7741
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5571c7d4-286b-47f6-9dd5-0aa688773c8e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eIs0W2wzLLDYjKZmkaR2RTDurPLQH3/nX/L7kvt1Dm89tyvIKFtPgaK+vDAmtoDL0MtQeEtQmfUojpYzSei3DEivSfSCLUemd1vPIC9dYg8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR01MB4578
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 03 Nov 2023 03:48:05 -0700 (PDT)

On Wed, Nov 01, 2023 at 07:49:48AM +0100, Greg Kroah-Hartman wrote:
> On Wed, Nov 01, 2023 at 02:44:04PM +0800, Crescent CY Hsieh wrote:
> > diff --git a/include/uapi/linux/serial.h b/include/uapi/linux/serial.h
> > index 53bc1af67..427609fd5 100644
> > --- a/include/uapi/linux/serial.h
> > +++ b/include/uapi/linux/serial.h
> > @@ -137,6 +137,8 @@ struct serial_icounter_struct {
> >   * * %SER_RS485_ADDRB		- Enable RS485 addressing mode.
> >   * * %SER_RS485_ADDR_RECV - Receive address filter (enables @addr_recv). Requires %SER_RS485_ADDRB.
> >   * * %SER_RS485_ADDR_DEST - Destination address (enables @addr_dest). Requires %SER_RS485_ADDRB.
> > + *
> > + * * %SER_RS422_ENABLED		- RS422 enabled.
> >   */
> >  struct serial_rs485 {
> >  	__u32	flags;
> > @@ -149,6 +151,8 @@ struct serial_rs485 {
> >  #define SER_RS485_ADDR_RECV		(1 << 7)
> >  #define SER_RS485_ADDR_DEST		(1 << 8)
> >  
> > +#define SER_RS422_ENABLED		(1 << 9)
> 
> Why the extra blank line before this?

The extra blank line is for the clarity, to seperate RS422 flag from
RS485 flags.

> Also, what userspace code is going to use this?  How is it tested?

This flag could be used when user tries to switch serial interface into
RS422, just like the original flag "SER_RS485_ENABLED" can also be used to
switch serial interface into RS485 with some RS485 configurations.

---
Sincerely,
Crescent CY Hsieh