Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   Finn Behrens <finn@kloenk.de>
To:     Alice Ryhl <aliceryhl@google.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        =?utf-8?b?QXJ2ZSBIasO4bm5ldsOlZw==?= <arve@android.com>,
        Todd Kjos <tkjos@android.com>,
        Martijn Coenen <maco@android.com>,
        Joel Fernandes <joel@joelfernandes.org>,
        Christian Brauner <brauner@kernel.org>,
        Carlos Llamas <cmllamas@google.com>,
        Suren Baghdasaryan <surenb@google.com>,
        Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
        Boqun Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>,
        =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>,
        Benno Lossin <benno.lossin@proton.me>,
        Andreas Hindborg <a.hindborg@samsung.com>,
        Matt Gilbride <mattgilbride@google.com>,
        Jeffrey Vander Stoep <jeffv@google.com>,
        Matthew Maurer <mmaurer@google.com>
Subject: Re: [PATCH RFC 03/20] rust_binder: add threading support
Date:   Fri, 03 Nov 2023 11:51:07 +0100
Message-ID: <62F430CC-9980-4779-9D43-7D561D322C9B@kloenk.de>
In-Reply-To: <20231101-rust-binder-v1-3-08ba9197f637@google.com>
References: <20231101-rust-binder-v1-0-08ba9197f637@google.com>
 <20231101-rust-binder-v1-3-08ba9197f637@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On 1 Nov 2023, at 19:01, Alice Ryhl wrote:


> diff --git a/drivers/android/error.rs b/drivers/android/error.rs
> new file mode 100644
> index 000000000000..41fc4347ab55
> --- /dev/null
> +++ b/drivers/android/error.rs
> +
> +impl core::fmt::Debug for BinderError {
> +    fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Resu=
lt {
> +        match self.reply {
> +            BR_FAILED_REPLY =3D> match self.source.as_ref() {
> +                Some(source) =3D> f
> +                    .debug_struct("BR_FAILED_REPLY")
> +                    .field("source", source)
> +                    .finish(),
> +                None =3D> f.pad("BR_FAILED_REPLY"),
> +            },
> +            BR_DEAD_REPLY =3D> f.pad("BR_DEAD_REPLY"),
> +            BR_TRANSACTION_COMPLETE =3D> f.pad("BR_TRANSACTION_COMPLET=
E"),
> +            _ =3D> f
> +                .debug_struct("BinderError")
> +                .field("reply", &self.reply)
> +                .finish(),
> +        }
> +    }
> +}
Renaming the debug_struct itself feels like it will make it harder to fin=
d later, as I would expect that a debug implementation names the struct i=
ts from.
Also this has the fallback in CamelCase and all defined cases as SCREAMIN=
G_SNAKE_CASE. Maybe rather in the defined cases something like f.debug_st=
ruct(=E2=80=98BinderError=E2=80=99).field(=E2=80=98reply=E2=80=99, =E2=80=
=9Cname=E2=80=9D)?