Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp402801rdf; Fri, 3 Nov 2023 04:27:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFE7yowYInBXlzv91Caqzd52HUNhG66eTMoX6sK69Tu14xD7zywJd674aqm3MNEtk9UvVUK X-Received: by 2002:aa7:88ca:0:b0:6c3:4458:ad12 with SMTP id k10-20020aa788ca000000b006c34458ad12mr3831387pff.5.1699010829823; Fri, 03 Nov 2023 04:27:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1699010829; cv=none; d=google.com; s=arc-20160816; b=Xt4cMLSUE1A1ZfllHVhMzmcFThUUtjZEmCRegl8CMpo73skAdtgVXIhSQF55bWB1iU +KBLcQ3blyIDBlGwM9iRaxJoQzVh6a9YrFIdaLDv7v4TqsEb/tQVSM2e9WEjhkbJln7t 4/xsWXy3WYe7DAJNAx4L3LeuGzmFOfmV+LDe0bjHtQJEWVx2ikricev4ocayPe3QptUn 4bl353FStaEf82vBPUQEKSKQg2AY8TbNNSC7gZ0yyKE1Ohyq3ThDUm9aNwmkQkQttpFa 72Hx0TzN2zRbYeSELC7DoRCV/vFSeQ7K0NYw2sOdzWfjuodHq2UKlCNEoYRJQKLylnAg Y7uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:to:content-language:subject:user-agent:mime-version:date :message-id:dkim-signature; bh=lfQIATagDXr/IHl018bEVxuu1E+1OhBeQ1S0dtuTD7U=; fh=E5MBYSBr1EB3nQ02R3tszf1pPuVlUKQ0xSrm2BEy6uw=; b=gX59/J+Q9MwotjMgNsvYGPvz5bz5+4tyfoyOSJPDTOiTBETwEKORCL4XZnSXFLrVaj g3q07BGx6A8l3ud3QYvrQmk4uvCDvk17AKak9BNiCpFgmf44SsQ3zpFrHOuE3xUAC1// ZLZALNpnHhHCFlU/OUlbi1V7zEXcFMS93CeF55Fbe2AsmLPs02ieqkQkc5Sc7k73Bdmc BifZivJgom3H6iLIcXG/7rgPVbIztn9ug4WKERoCd9nfJNOHlyVK9Be4v/bkDStH08QD +w3tIg+3/08LUFxtJMzHjc0HURoIC9Y0eWK/xitu1rqv/913X4LPhtm5YKPZbaftrVcQ 06Qg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=Wkxl8puX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id s189-20020a635ec6000000b005ac8d44bad4si1304697pgb.592.2023.11.03.04.27.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 04:27:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=Wkxl8puX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id E1C9681D2D3E; Fri, 3 Nov 2023 04:27:04 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229984AbjKCL0t (ORCPT + 99 others); Fri, 3 Nov 2023 07:26:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbjKCL0s (ORCPT ); Fri, 3 Nov 2023 07:26:48 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA2C7134; Fri, 3 Nov 2023 04:26:42 -0700 (PDT) Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3A3BApAX021726; Fri, 3 Nov 2023 11:26:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=lfQIATagDXr/IHl018bEVxuu1E+1OhBeQ1S0dtuTD7U=; b=Wkxl8puXjlYAzj4Ieivbx7VPVNi5cMv7U0Dz3OdlbtfIF8kIv0o1qaoZ8kRbYjRLFYGm m+B+W8vDhRMX8BTZtAghu/Z7DLNKpqzkXzLZ8UlPNwdnA5o4lsoJPxOtvumUWtUe5ovQ Nig6XYuhWkPR4lSKvEIVM/I2r9x5RvKnWNGgieXoR0bAI7LGLYZcj5/ekdNhAJ+vW9vu Mo4f2/fjUPdTvArWmm5yJyvmAyJxQTDqmxuHxk186F09m5h1Or9mWsaZwkUcV/TTJtu4 Y8AH466xorSLTzurkd9bl6XkiZ9ZonYnrVH5SDkDzXLkFsAm7AG12YrEM2c4FH5xJjiU Sw== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3u47dy31jf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 03 Nov 2023 11:26:27 +0000 Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3A3BQQJg016440 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 3 Nov 2023 11:26:26 GMT Received: from [10.216.26.1] (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Fri, 3 Nov 2023 04:26:20 -0700 Message-ID: <0140b8b9-0043-4cf4-0704-7727774dba0f@quicinc.com> Date: Fri, 3 Nov 2023 16:56:17 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [RFC PATCH 2/5] arm64: dts: qcom: ipq9574: Add ecc engine support Content-Language: en-US To: Konrad Dybcio , , , , , , , , , , , , , , , , References: <20231031120307.1600689-1-quic_mdalam@quicinc.com> <20231031120307.1600689-3-quic_mdalam@quicinc.com> <873c1b14-5b7c-4fb1-8f09-6344a4bf901b@linaro.org> From: Md Sadre Alam In-Reply-To: <873c1b14-5b7c-4fb1-8f09-6344a4bf901b@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: ZK53JGex603L5pTAe7eCzW7u4s1svBif X-Proofpoint-ORIG-GUID: ZK53JGex603L5pTAe7eCzW7u4s1svBif X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-03_11,2023-11-02_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 phishscore=0 impostorscore=0 mlxscore=0 mlxlogscore=798 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2310240000 definitions=main-2311030096 X-Spam-Status: No, score=-4.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 03 Nov 2023 04:27:05 -0700 (PDT) On 10/31/2023 8:53 PM, Konrad Dybcio wrote: > On 31.10.2023 13:03, Md Sadre Alam wrote: >> Signed-off-by: Md Sadre Alam >> Signed-off-by: Sricharan R >> --- > Hello, > > you're missing: > > - dt-bindings (make dtbs_check is unhappy) > - a commit message > - Co-developed-by for Sricharan > > status should read "okay" instead, but in this case it's unnecessary > as you're defining the node and lack of the status property also means > that device is enabled > > however > > this ECC engine seems to be a part of the NAND controller, so it's > unlikely that the DT maintainers will agree for it to have a separate > node > Will drop this patch as this was NAK-ed QPIC controller has the ecc pipelined so will keep the ecc support inlined in both raw nand and serial nand driver. Regards Alam.