Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Adrian Hunter <adrian.hunter@intel.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        =?iso-8859-2?Q?Kornel_Dul=EAba?= <korneld@chromium.org>,
        Radoslaw Biernacki <biernacki@google.com>,
        Gwendal Grignou <gwendal@chromium.org>,
        Asutosh Das <quic_asutoshd@quicinc.com>
CC:     Chaotian Jing <chaotian.jing@mediatek.com>,
        Bhavya Kapoor <b-kapoor@ti.com>,
        Kamal Dasu <kamal.dasu@broadcom.com>,
        Al Cooper <alcooperx@gmail.com>,
        Haibo Chen <haibo.chen@nxp.com>,
        Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>,
        Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>,
        Victor Shih <victor.shih@genesyslogic.com.tw>,
        Ben Chuang <ben.chuang@genesyslogic.com.tw>,
        Thierry Reding <thierry.reding@gmail.com>,
        Aniruddha Tvs Rao <anrao@nvidia.com>,
        Chun-Hung Wu <chun-hung.wu@mediatek.com>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH V2 5/6] mmc: cqhci: Warn of halt or task clear failure
Thread-Topic: [PATCH V2 5/6] mmc: cqhci: Warn of halt or task clear failure
Thread-Index: AQHaDjLZw7S/sDZV6UOnOsoxT8d19LBofX1w
Date:   Fri, 3 Nov 2023 11:58:18 +0000
Message-ID: <DM6PR04MB6575C0C38B7675957B2C0B7BFCA5A@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20231103084720.6886-1-adrian.hunter@intel.com>
 <20231103084720.6886-6-adrian.hunter@intel.com>
In-Reply-To: <20231103084720.6886-6-adrian.hunter@intel.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-2?Q?rw/87TY+7gqP1Hf2UxdPCNsV0as3g+QObhl9kuuOYRkjfVRGbU95IVQb9X?=
 =?iso-8859-2?Q?v+qAETzI1Pczq6BjdVb0b8HBPlIVQOdVawOUczOMQmpXlje8enbJEeK3u0?=
 =?iso-8859-2?Q?3Y5QjDBBQVMhYWdQ0qy+ta3bMEjJ05mEwZODhq9tzX6EZ2FJviKXvU+7Yk?=
 =?iso-8859-2?Q?04uQUVUUXEOnLkFRx+/Vm9i4bR3NzjAFH+/ierbT5bWs/pF87TCOEJlzb5?=
 =?iso-8859-2?Q?8AgGa+IQJMWJw6vaKN+UWUfyaNldcTytp/wIILp30XSrowniP2V9mmnAiy?=
 =?iso-8859-2?Q?Tm0evaJMkOWTkCWRsc1uV0W9u5BNpI9Ygio0hvLw5lz1lg1T3Yb71Sy4qy?=
 =?iso-8859-2?Q?nHgT3fQlEUjy/T+jtBQEHmk+G89hVtLFpqKgsyEOSWxqEQ4BaKhynyOCAQ?=
 =?iso-8859-2?Q?dBygL88uWyZoAD9+rqkmwDJMdWpO3dHTGi6ZivZlnak03q31MN1rDkSzEC?=
 =?iso-8859-2?Q?tJE1FF7toaKyE+8qLlB/XiBcxU0KWXU6/LYNljMGjVNHj5L0MrE38hzIJD?=
 =?iso-8859-2?Q?9AscVqkoPd3qi8Clb/92vm3fKVFA7YqS7UF30qOle48VtdzZQxcDRhB+7L?=
 =?iso-8859-2?Q?5dHYMryba0SG2wO64d7of4FYpgTdWXOUcpKku1DOVE5qJTKrkcRwnra0Tz?=
 =?iso-8859-2?Q?kbkX/Rr2cBHI8gxXTrRGXB7klhul8N1dX46PyEEDChUJhBvbXxvSGpW/M7?=
 =?iso-8859-2?Q?vWgYruayjdB40VYICONTI9QzO75RLniz7Cwh+DqrySRe2ilFNunuEIXGIB?=
 =?iso-8859-2?Q?ddNAqi/s6/HACzbBM8NH0aayZva5S0ALhPbLC+HiE75TzSMSoUfcV3BOsr?=
 =?iso-8859-2?Q?CJNZIdZeILR4nah7EX8bxWb+/ja5QyyRW09YtJypieCBtE99EtfTqHfz/3?=
 =?iso-8859-2?Q?bpTCYS0N9op4Lio04Aq/Pf5C/+a4sHltexh59dJIi5nkCciOJmrpVLxXxC?=
 =?iso-8859-2?Q?w/fVvbtvuvhrwoosylQP19CO44xC0XXdcZZVBdiS/uA4UUKCMVE47loQiw?=
 =?iso-8859-2?Q?pQtXjahF00YVe5+7ss3MIbPmRA6pb5/Qv8B37Vb/LW1TkihNUNR70sCLhg?=
 =?iso-8859-2?Q?Tbfc2tVy4O4aowZ10/F0cNknjUFjULCigvdQTnlMzkI8U5Lpsjuz5lLvQc?=
 =?iso-8859-2?Q?QIJibPjRq7zf/R5hl3GPpBY5hvk3EDAkamR7YDC3k+sxYn4KUhbyx5bZ4u?=
 =?iso-8859-2?Q?Pzc8L80oRf5uNl5kD0FFkGE6uXwrMU/yNzt73d+rhZA9Ii2PW46TqCP3QN?=
 =?iso-8859-2?Q?y/cUkFSxuW0f0ou/KXU726N4Nrm9kTC039AqVAH2lo9hgzyQiRPZyZ2QUu?=
 =?iso-8859-2?Q?VcfUs0vOGoVEh8UzIvUzoN9kBzevT2C/WfMzlv2zrAbRK96iwi5MUKd1ym?=
 =?iso-8859-2?Q?IXlEa89m39zQy+Wl5mwbJ09lNNKmiPkYZFodN0tmV25NLf6p4WEwD/En+R?=
 =?iso-8859-2?Q?rIFzSmIpeDPiFj37cbky9HxvIlUZB7JIBH7MCPBl1APzOQPDdZTwJwG8ts?=
 =?iso-8859-2?Q?SNUkHnQjbINt04rU7jsIYcwQ0Sn8epwQXzawfuCmB03yiWjxWiwyLwj6w/?=
 =?iso-8859-2?Q?wOKqZXnznzrgsChrEMF8BrUIGbXuq4nhgaE5rMhq2YEDCZHiheSgwnsO9j?=
 =?iso-8859-2?Q?FazkPq6nVw6cYqCHPpchVp1hmjhHpua5KL?=
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?iso-8859-2?Q?nYSbZGpFRiHCReKPx8XBs935dhdLq4eXgjGb0GGgonv5vrRkFjMO6BTrKV?=
 =?iso-8859-2?Q?FIdYBICXQ//eC8nlewD88eXiX8TUM0RmjO3+OqjfjnDgxOpWfq43F2KKJg?=
 =?iso-8859-2?Q?8kXeL5ePqious5dSn9riIBX12Z5HXosNfWvnKp3K0M35SvvwoYU4cpp+ng?=
 =?iso-8859-2?Q?8kigcrcn9vI1kPK9eFOuvp+9GoF1u0YkwlCZeP70er4dwYc+UvjGjZpDUw?=
 =?iso-8859-2?Q?SuwMn8eYZ1ZZDiKC2pDntPmB6phJE4DqooXYuSbTEvB/K9hWVn/JkrNXMn?=
 =?iso-8859-2?Q?TuZ2YveXBLHOZjPusY0g30BRRlgW2SWwqt/36EW2c1P+MLQJTgyzhcjr2+?=
 =?iso-8859-2?Q?FbVUAGdimYxOTnUsWMpbIfHkQbBh/RQWbAE8uUZhLhjZkuWlDt9UtvUkZS?=
 =?iso-8859-2?Q?zR/AcL3VHs2ocJwp8muUL74eidRwIqUXLnisCTL5lSPMdmDpC7oH4k2scC?=
 =?iso-8859-2?Q?4k/wwFRq6uen4EGgth4xyLJ/b6+nAfcodQM/2Hlj7qRpHaC5aXE0wEZnGU?=
 =?iso-8859-2?Q?JiG1uv9O2+6t5FBrVq2yMgblR/f/AwOtfY5ZGutwHGdKkjUAyFiqwZI+Hp?=
 =?iso-8859-2?Q?m5cIuxVoUkMMfAICttRpfZiiRFjauVWYPQx1+FsygkJ0sVH4XGgXeU76dR?=
 =?iso-8859-2?Q?ePFbTtDfQ5tRQ0CrKSjihORfWkUysMCayDrQo354I1upqTjZg8S+OCByRd?=
 =?iso-8859-2?Q?90aC4gwjofJU0k/8IMztfLRsK2t8LldYOFrefEMI/Kgrv4EKNOzXQ7f1+W?=
 =?iso-8859-2?Q?GnAX79e/BQSj/ohdWzbgtPC94TXukxoMEc7H2FpvlZSR/CIT7MnL9LAJnr?=
 =?iso-8859-2?Q?iKtls4t/LNn8vKppf/SefWNZftc83KSPKcl+/44idM0CUnQ28qHG4tEvJN?=
 =?iso-8859-2?Q?APnXqDNdeppQi837oND7JI6KusAuYdJZ2atC85l0vF28iiMh+q7HullAUP?=
 =?iso-8859-2?Q?8gYJLrIFlRFi6ySKGOT6vAi97Zw7+Fd5XUy7GuvSnYRqefzOyUyDupOpCt?=
 =?iso-8859-2?Q?MQhX1FRNDVd0NQdbipi8kNAM10vD0R4mqhRRZgYDhCdfSfCQGGFU8Gertv?=
 =?iso-8859-2?Q?bOeATxy6FA+PJ8yOWvW6uqT7ipmnoGfUECi15PbXvluHUQVIUy2CTINlvI?=
 =?iso-8859-2?Q?VeC4B6eL6EhoIoUHv0R2UV4iJWBpkPMmj02delXw26nzKZzMoffUyBCX4d?=
 =?iso-8859-2?Q?s08x6l4jUcTId7OC/wTBhY+DUVWJMatlMz0=3D?=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4675eddf-b5b8-4f31-0df7-08dbdc642b3c
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2023 11:58:18.3050
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Y87ziAiAjdLbtMkPh59FdXdjk6VlJBIuHi8Wt22cQ6xpp1UJZ/M9+5VExvzHSMg68KDO0jVKO2G04EcMZ73Nsw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR04MB7237
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 03 Nov 2023 04:58:46 -0700 (PDT)

> A correctly operating controller should successfully halt and clear tasks=
.
> Failure may result in errors elsewhere, so promote messages from debug to
> warnings.
>=20
> Fixes: a4080225f51d ("mmc: cqhci: support for command queue enabled
> host")
> Cc: stable@vger.kernel.org
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>

> ---
>  drivers/mmc/host/cqhci-core.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/mmc/host/cqhci-core.c b/drivers/mmc/host/cqhci-core.=
c
> index 15f5a069af1f..948799a0980c 100644
> --- a/drivers/mmc/host/cqhci-core.c
> +++ b/drivers/mmc/host/cqhci-core.c
> @@ -942,8 +942,8 @@ static bool cqhci_clear_all_tasks(struct mmc_host
> *mmc, unsigned int timeout)
>         ret =3D cqhci_tasks_cleared(cq_host);
>=20
>         if (!ret)
> -               pr_debug("%s: cqhci: Failed to clear tasks\n",
> -                        mmc_hostname(mmc));
> +               pr_warn("%s: cqhci: Failed to clear tasks\n",
> +                       mmc_hostname(mmc));
>=20
>         return ret;
>  }
> @@ -976,7 +976,7 @@ static bool cqhci_halt(struct mmc_host *mmc,
> unsigned int timeout)
>         ret =3D cqhci_halted(cq_host);
>=20
>         if (!ret)
> -               pr_debug("%s: cqhci: Failed to halt\n", mmc_hostname(mmc)=
);
> +               pr_warn("%s: cqhci: Failed to halt\n",
> + mmc_hostname(mmc));
>=20
>         return ret;
>  }
> --
> 2.34.1