Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Fri, 3 Nov 2023 12:28:47 +0000
From:   Matthew Wilcox <willy@infradead.org>
To:     Kefeng Wang <wangkefeng.wang@huawei.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-mm@kvack.org, David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH 4/5] fs/proc/page: use a folio in stable_page_flags()
Message-ID: <ZUTnf/hnbPqI9HSB@casper.infradead.org>
References: <20231103072906.2000381-1-wangkefeng.wang@huawei.com>
 <20231103072906.2000381-5-wangkefeng.wang@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231103072906.2000381-5-wangkefeng.wang@huawei.com>
Precedence: bulk

On Fri, Nov 03, 2023 at 03:29:05PM +0800, Kefeng Wang wrote:
> Replace ten compound_head() calls with one page_folio().

This is going to conflict with Gregory Price's work:

https://lore.kernel.org/linux-mm/ZUCD1dsbrFjdZgVv@memverge.com/

Perhaps the two of you can collaborate on a patch series?

>  	u |= kpf_copy_bit(k, KPF_SLAB,		PG_slab);
> -	if (PageTail(page) && PageSlab(page))
> +	if (PageTail(page) && folio_test_slab(folio))
>  		u |= 1 << KPF_SLAB;

This doesn't make sense ...