Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp442202rdf; Fri, 3 Nov 2023 05:33:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGbgsAUPdFiHHidnDOiBINQBCn6/dSTbSNsV9sHqIaNuQpB0S8B+kjvtrO+JRMnKVCSuWNj X-Received: by 2002:a05:6a20:daa0:b0:181:b0e9:63c1 with SMTP id iy32-20020a056a20daa000b00181b0e963c1mr5016939pzb.30.1699014833989; Fri, 03 Nov 2023 05:33:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1699014833; cv=none; d=google.com; s=arc-20160816; b=lPeDxWb9A259/ZnY5TWLjba/qx9zw075UD+euCi0NVwMTgyXRympFo8YPVNzOBz+Fg cyxyl5fIvGXMaEBa5/fnhZc9a8c5cIXwDfU/Ps3jImrNCiZXKQPiz3yd7sN2rrn7iD9X 4nwOVL5Rf1qH8KaxHwcgT0XNrmEWF8ug/V5v0+sHFoHaq4AQkLv/8fyrle9CbIhPQspx ooi+gFFclzjrpIOveCobLsccncIlme7tJT+NYH/PewqQbUz1CNrJs18QLVaZeIR+0nZU drtSuOM003Vn3dEkQBmhvdlNsmmmcF++92J/yRU6SK0j+ySQIPbl4l6kFCCbFhvoXSA0 Kexg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=0KSdt9VlChlmft/PeayCtTjiy1+VOgZbmeLdttQHlx4=; fh=tIXv/zuLO3492dfLXU/ghZ2Zi/sOj8OLNiq6nRqZEQc=; b=lMYPStlG7kUIZAs0nk8CIWWfH9ZHXxzWdxVbQtGzKqV+wt/qvZhpj9h6307ytOCVr4 8JQzp/jQ42G5L776ZyJqYENTfCsaMOiHW3gQ7gWQb0J4/BRf7IdI9eOgCTdfLQX+iXPl m1zXPgGXpcxLWG5NMdpZxu18Dv7wkGcY02Q4W8yBUh0PnBQfvCu2SzC3uhUNolAufB5w mkhAFPVAlH4IefUg3+jHt7Hht0ptEAl2bVQ95jcKx7h11n3XCWDoc740KjfzkhL56myB a28Wdro/bXn+Oq0RU/56KxDtxIsf/NhjCO+dRzuWP2D84YDpC7XlCmACXwnNpjVd12bw wKiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qVavNsf6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id t27-20020a056a00139b00b006c0fe935fa1si1512682pfg.181.2023.11.03.05.33.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 05:33:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qVavNsf6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id EA21E8200C9E; Fri, 3 Nov 2023 05:33:46 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376461AbjKCMdV (ORCPT + 99 others); Fri, 3 Nov 2023 08:33:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376439AbjKCMdT (ORCPT ); Fri, 3 Nov 2023 08:33:19 -0400 Received: from mail-yb1-xb2b.google.com (mail-yb1-xb2b.google.com [IPv6:2607:f8b0:4864:20::b2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68BD71A8 for ; Fri, 3 Nov 2023 05:33:12 -0700 (PDT) Received: by mail-yb1-xb2b.google.com with SMTP id 3f1490d57ef6-d9ace5370a0so1963212276.0 for ; Fri, 03 Nov 2023 05:33:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699014791; x=1699619591; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0KSdt9VlChlmft/PeayCtTjiy1+VOgZbmeLdttQHlx4=; b=qVavNsf6R5tGiIFh2DHtt2MHsD/PkKUwA5bXN5V+1iF7mYBPlpD+mu55qZycKQ2CbO IjZMyr28OX7hQCSjUNcP+aqkqNklnHze54YOOQTYqzF48qYg2Hy/XM7Ky9U/JZgN2nAJ OEjnPJ1HHYXJGpxG+gCC7RonbGRWPAx+bLjN6Ao60EYRKtgoBkx3RnmOtt5WZGhlHJX6 ji2lijccQnPuBjs4Nhmyr4KeFrrWxp8ltxpIGbIqAzsc76PIf/hRXLbM5Gd+dTKmFvfS RH+qO17tBxZzCJKq4eN4Ts+E8N0n+cZP8Ugxk1coGOoxUCTyGZ5iDTzpGk7VaLuacCxo aqFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699014791; x=1699619591; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0KSdt9VlChlmft/PeayCtTjiy1+VOgZbmeLdttQHlx4=; b=ChHgCHRJecKyi6MYMT2KIxvVRFQWjyxvgaDRmGst+u99dPVMZ1dOsCb396h1rSCi1c YG1AyXT31VN2kInLs9f5bY4Rt3H78/8fcZ/EDEumcEhnGbgrx8AFa+0BMQAA/CDsOlOn UPJe3a99OCi9ZLGQ9LOFc+KydzuTdVpj0+/OkV3nF5l+mxgHcJX/EPrYfH2X/iiPqewG RZulqj5usJh4hhyPJRJdbS+9FT79hU13sHRt4GCH+u+veNJZxzzks26e5iALbaimj20q 0m5uyw6GZkK4zcDEGwrB8pwWNpk9pnzNw4g++jt+lEPPtTR5PlIt14MsU1d1ILehPM0A dSuw== X-Gm-Message-State: AOJu0YwHWrS3E972H40VVij6D4i0Fp9ie1VKY53mi8C/dzstzddiHcYd mwn4/4F0BjbL8dZzmhgtNRMIpoV34tyQDDBNLZdGDw== X-Received: by 2002:a25:37c6:0:b0:d9c:2b72:4fa5 with SMTP id e189-20020a2537c6000000b00d9c2b724fa5mr15696344yba.48.1699014791460; Fri, 03 Nov 2023 05:33:11 -0700 (PDT) MIME-Version: 1.0 References: <20231031120307.1600689-1-quic_mdalam@quicinc.com> <20231031120307.1600689-2-quic_mdalam@quicinc.com> <553c1373-c9a0-b2af-2286-058824e31bad@quicinc.com> In-Reply-To: <553c1373-c9a0-b2af-2286-058824e31bad@quicinc.com> From: Dmitry Baryshkov Date: Fri, 3 Nov 2023 14:33:00 +0200 Message-ID: Subject: Re: [RFC PATCH 1/5] mtd: nand: ecc-qcom: Add support for ECC Engine Driver To: Md Sadre Alam Cc: Krzysztof Kozlowski , agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, broonie@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org, quic_srichara@quicinc.com, qpic_varada@quicinc.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 03 Nov 2023 05:33:47 -0700 (PDT) On Fri, 3 Nov 2023 at 14:25, Md Sadre Alam wrote: > > > > On 10/31/2023 10:41 PM, Krzysztof Kozlowski wrote: > > On 31/10/2023 13:03, Md Sadre Alam wrote: > > > > Eh? Empty? > > QPIC controller has the ecc pipelined so will keep the ecc support > inlined in both raw nand and serial nand driver. > > Droping this driver since device node was NAK-ed > https://www.spinics.net/lists/linux-arm-msm/msg177596.html It seems, we have to repeat the same thing again and again: It was not the device node that was NAKed. It was the patch that was NAKed. Please read the emails carefully. And next time please perform dtbs_check, dt_binding_check and checkpatch before sending the patch. It is perfectly fine to ask questions 'like we are getting we are getting this and that issues with the bindings, please advise'. It is not fine to skip that step completely. > > > >> Signed-off-by: Md Sadre Alam > >> Signed-off-by: Sricharan R > >> --- > >> drivers/mtd/nand/Kconfig | 7 ++ > >> drivers/mtd/nand/Makefile | 1 + > >> drivers/mtd/nand/ecc-qcom.c | 198 ++++++++++++++++++++++++++++++++++++ > >> 3 files changed, 206 insertions(+) > >> create mode 100644 drivers/mtd/nand/ecc-qcom.c > >> > > > > ... > > > >> + > >> + return 0; > >> +} > >> +EXPORT_SYMBOL(qcom_ecc_config); > >> + > >> +void qcom_ecc_enable(struct qcom_ecc *ecc) > >> +{ > >> + ecc->use_ecc = true; > >> +} > >> +EXPORT_SYMBOL(qcom_ecc_enable); > > > > Drop this and all other exports. Nothing here explains the need for them. > > > >> + > >> +void qcom_ecc_disable(struct qcom_ecc *ecc) > >> +{ > >> + ecc->use_ecc = false; > >> +} > >> +EXPORT_SYMBOL(qcom_ecc_disable); > >> + > >> +static const struct of_device_id qpic_ecc_dt_match[] = { > >> + { > >> + .compatible = "qcom,ipq9574-ecc", > > > > Please run scripts/checkpatch.pl and fix reported warnings. Some > > warnings can be ignored, but the code here looks like it needs a fix. > > Feel free to get in touch if the warning is not clear. > > > > Checkpatch is preerquisite. Don't send patches which have obvious issues > > pointed out by checkpatch. It's a waste of reviewers time. > > > >> + }, > >> + {}, > >> +}; > >> + > >> +static int qpic_ecc_probe(struct platform_device *pdev) > >> +{ > >> + struct device *dev = &pdev->dev; > >> + struct qpic_ecc *ecc; > >> + u32 max_eccdata_size; > >> + > >> + ecc = devm_kzalloc(dev, sizeof(*ecc), GFP_KERNEL); > >> + if (!ecc) > >> + return -ENOMEM; > >> + > >> + ecc->caps = of_device_get_match_data(dev); > >> + > >> + ecc->dev = dev; > >> + platform_set_drvdata(pdev, ecc); > >> + dev_info(dev, "probed\n"); > > > > No, no such messages. > > > > > > > > Best regards, > > Krzysztof > > -- With best wishes Dmitry