Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp523410rdf; Fri, 3 Nov 2023 07:31:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHc43RmqE7xJC8V2L5hvYfp7qNX0TEtdbCPAkDhhCRoAEz7augET8Ug44elbvab6l/9qcns X-Received: by 2002:a92:c541:0:b0:351:5b29:8a57 with SMTP id a1-20020a92c541000000b003515b298a57mr27624595ilj.13.1699021903622; Fri, 03 Nov 2023 07:31:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1699021903; cv=none; d=google.com; s=arc-20160816; b=cePafygWtZNhFj65qKYt++wcvk62dh/IiVL6vp/wTHu6gqgi5cio9hWaHsCHWEUa98 Q4OoSOi5OuNSBzZZlBwSbLj5qZGTlMkIx5D5WW+rn+f/w0Sq53r/EDF2uy9W3yuVZQm5 omdOBXUB7+suT6XQMiMrWKNzneGC63uPeaK4Dd76yQgB7vUCWW6YXSk902kGWQEJBF0N iTq4kHXLAKCunqwsr3fv1L7s/Y6hGIJzjFzKcPDw94w1pRj4rDV6vsOVCPUWJ2mcuhxJ GktmLwIqDgdZ9g3+oerlgJLeP12A3OVDM3GfgKXbwhtdnWnb4ragzkhLvmnDw1/ETivD oNjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=TutFGcTUbbtZZeHXA63UR/SNK49qiEmJWb/gtgYEieI=; fh=eORcq9QZmBCYeNUdqYkrhzxtKqHL34KExjMuSyjxCKo=; b=Ag6p6iBesqeRSy92COgOM5wAJCylu28D/hUnVhMbXeaSjhQPmiLMstRiZcXPK8z+y0 tVkw46rw6BC842DzEYktodBQvqRblRl9vULuGlms3C0+9eoAPj4iR7OLxmLKM7SVyJMT CrDA0sWdjBXDnqekPBZLNuYxZTzioRRmIBjNOXa6W+80URbTlUemw+/wkrV0KRZvoA89 Kn6C/HG4Fbo1DK1PXWNImdREwktxIRZKXO93AylL4afB22Kqnis1MbEjW96+vWo3RAnZ 0cct9CwJPbuBtvmW3N0SE7PDRsV/0Cx8e7lHRXwogJW0lm8/x9bKBZJ6H4KfPoLC9sPo WpYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=FbyJVXsJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id v202-20020a6361d3000000b005a1d8816a2bsi1548922pgb.72.2023.11.03.07.31.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 07:31:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=FbyJVXsJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 79CE8826ECB3; Fri, 3 Nov 2023 07:31:13 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377868AbjKCOai (ORCPT + 99 others); Fri, 3 Nov 2023 10:30:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377836AbjKCOaf (ORCPT ); Fri, 3 Nov 2023 10:30:35 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB808D4D; Fri, 3 Nov 2023 07:30:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=TutFGcTUbbtZZeHXA63UR/SNK49qiEmJWb/gtgYEieI=; b=FbyJVXsJzK7XKpDQhQSH2f5bbB EgnQqqd9A9MFrtDCw2kOiVC1DIyBIwkyxlhwtCFXD4kA29mLsIB2wnynfa+ilpkl4TDa+mlRCGUQe bWhB9NrNZ6N8a2BJoYER/YL5yFnOOOynx4Ntax3dLv5EjBGKpDj2bljHRIgrQ+yhvyLmlCKvwtpD5 txs3wPs/dADpxkPkUXf9pmOa/WA3wpJwY3mFWqRJarMd6nYaQf+TRGQvYWVUM5qFNc+hNSK3qeSqU Xor8VEwOvcszB2K2Ci/7a62ltupYnMXN6gdoUfddkshXy82ilrp/FDK4sJRxXmk1Fx8uhoQ2e0Yne T6r8e5EA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qyvBp-005rhq-Os; Fri, 03 Nov 2023 14:30:25 +0000 Date: Fri, 3 Nov 2023 14:30:25 +0000 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, David Hildenbrand , linux-s390@vger.kernel.org Subject: Re: [PATCH rfc 00/18] mm: convert to use folio mm counter Message-ID: References: <20231103140119.2306578-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231103140119.2306578-1-wangkefeng.wang@huawei.com> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 03 Nov 2023 07:31:13 -0700 (PDT) On Fri, Nov 03, 2023 at 10:01:01PM +0800, Kefeng Wang wrote: > Convert mm counter page functions to folio ones. > > mm_counter() -> mm_counter_folio() > mm_counter_file() -> mm_counter_file_folio() > > Maybe it's better to rename folio mm counter function back to mm_counter() > and mm_counter_file() after all conversion? I deliberately didn't do this because it's mostly churn. Once all callers of mm_counter() and mm_counter_file() have been converted to use folios, we can do one big patch to convert all callers to pass a folio instead of a page.