Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp561447rdf; Fri, 3 Nov 2023 08:27:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG2Xw75l6cZwYUkUKBLKd7URxcn4NcBObjBSExy41SjFgtHn70FmbJNd3Yx74JiAwY0DLIO X-Received: by 2002:a05:6358:5925:b0:168:e4e4:b7c9 with SMTP id g37-20020a056358592500b00168e4e4b7c9mr22852820rwf.2.1699025226310; Fri, 03 Nov 2023 08:27:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1699025226; cv=none; d=google.com; s=arc-20160816; b=fi0hvUScwj/900rBchYTzrS2nviJlANdj3IbV+1NqbOVza4uGl8xxf7KVxXIyzG45G TsD6fjm3d+QT9wmvYHic23eDVTdfes5/68sEc5fO+MyoYchgzc9SvDiUU0h/g4K7kmu4 a8dkC5zVjgbf0jpbSuykddQ5TTfGYnKzScjiSm/kYm71RiP5s5ILpUnv9cEyJKY/OMz+ j22qJNDODzvwxJFvtaIxQkPyaqR5cbTaIs1z7hFjOsPBEwW1STNoGrU7EZEXuyjd+CTt vG2uzdJJof3u9VadVaGVEBBy89fH0/i6sXBAOLEh2XR+msFvr2A1LRGtURXDJiUdoWhe M3+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Yo24EHXq/Uvv0vpVWNo3r/AlLrwMYiJIPAKdzL2qcSQ=; fh=2T7ZDwrKtOMFS7KYmwP9oFxXrd2uRH0wh6WhtIKXvPY=; b=PMHB/MH6mPwCC5yoDiI+Q3dx1ZAejsNrHrPKKe8zcP6MhhNgsef4PhMsiuG8CzzxWX slgOWX+M+4XF9t6jOc7fd8dGw8uBpLnD8S+ufXdRqYov7jvlPTwVlHLP7SEVSXJsvmcc ghJOPNdIMkqpUykAm61rRw3T2kLQzicNjedVO68eUM7AJ9y1WEqhIO7JfQesbNQQjzJu RrSL0nMjFey5dkz0OEappjvWheUN0IqucHIjyWLrL0/UzwvcBPgXx9dfIM6TgYO3TstF wgYVfZFG0XHcOfqQhcvdVDl+tJBOykO/YYvtZAWD07gRUEClBzUf9bP81/RWQgvWzulb OmIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="GNn9k/ze"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id r20-20020a6560d4000000b005bd5a50b55bsi128620pgv.695.2023.11.03.08.27.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 08:27:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="GNn9k/ze"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 6D5B7829EA00; Fri, 3 Nov 2023 08:27:01 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233463AbjKCP0u (ORCPT + 99 others); Fri, 3 Nov 2023 11:26:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230110AbjKCP0t (ORCPT ); Fri, 3 Nov 2023 11:26:49 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC689112 for ; Fri, 3 Nov 2023 08:26:43 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 305CDC433C8; Fri, 3 Nov 2023 15:26:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1699025203; bh=XJ7Bs/+V7BeLxlzjtBTK45mi2154iurCY5DvcmsIQPY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GNn9k/ze+T4kYowcJM08Y+Pe5wNT1xDEiVm/6xMgv7d6s140j95A2jv5vgO+LVerr hCJYyxPNv+dqin9hSHFCQDcWzL0HPIWQJ47YC6vKWymA2HMQhw7mvrVG4ebJYT7SOw wu6okgxZ9s/kvQaPe+0YYvseaZxJjwps3V5K2Qmg= Date: Fri, 3 Nov 2023 16:26:37 +0100 From: Greg KH To: Hardik Gajjar Cc: Mathias Nyman , stern@rowland.harvard.edu, mathias.nyman@intel.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, erosca@de.adit-jv.com, s.shtylyov@omp.ru Subject: Re: [PATCH v7 1/2] usb: xhci: Add timeout argument in address_device USB HCD callback Message-ID: <2023110341-decode-atonable-64b4@gregkh> References: <20231027152029.104363-1-hgajjar@de.adit-jv.com> <20231103151822.GA101660@vmlxhi-118.adit-jv.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231103151822.GA101660@vmlxhi-118.adit-jv.com> X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 03 Nov 2023 08:27:01 -0700 (PDT) On Fri, Nov 03, 2023 at 04:18:22PM +0100, Hardik Gajjar wrote: > On Mon, Oct 30, 2023 at 12:45:54PM +0200, Mathias Nyman wrote: > > On 27.10.2023 18.20, Hardik Gajjar wrote: > > > - The HCD address_device callback now accepts a user-defined timeout value > > > in milliseconds, providing better control over command execution times. > > > - The default timeout value for the address_device command has been set > > > to 5000 ms, aligning with the USB 3.2 specification. However, this > > > timeout can be adjusted as needed. > > > - The xhci_setup_device function has been updated to accept the timeout > > > value, allowing it to specify the maximum wait time for the command > > > operation to complete. > > > - The hub driver has also been updated to accommodate the newly added > > > timeout parameter during the SET_ADDRESS request. > > > > > > Signed-off-by: Hardik Gajjar > > > > For the xhci parts > > > > Reviewed-by: Mathias Nyman > > > > > > @Greg KH, Friendly reminder. It is the m iddle of the merge window, my branches are closed for obvious reasons until after -rc1 is out. Please relax and wait for a week or so _after_ -rc1 is out before worrying about anything. thanks, greg k-h