Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <9a1baddd-830d-364b-5106-c33bb64d516f@quicinc.com>
Date:   Fri, 3 Nov 2023 21:00:30 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] soc: qcom: llcc: Fix dis_cap_alloc and retain_on_pc
 configuration
Content-Language: en-US
From:   Mukesh Ojha <quic_mojha@quicinc.com>
To:     Atul Dhudase <quic_adhudase@quicinc.com>, <agross@kernel.org>,
        <andersson@kernel.org>, <konrad.dybcio@linaro.org>,
        <swboyd@chromium.org>, <isaacm@codeaurora.org>,
        <dianders@chromium.org>
CC:     <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20231103105712.1159213-1-quic_adhudase@quicinc.com>
 <c5eb223b-b7b1-c85f-a0d5-ab3cc3e86efa@quicinc.com>
In-Reply-To: <c5eb223b-b7b1-c85f-a0d5-ab3cc3e86efa@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 11/3/2023 4:47 PM, Mukesh Ojha wrote:
> 
> 
> On 11/3/2023 4:27 PM, Atul Dhudase wrote:
>> While programming dis_cap_alloc and retain_on_pc, set a bit
>> corresponding to a specific SCID without disturbing the
>> previously configured bits.
>>
>> Fixes: c14e64b46944 ("soc: qcom: llcc: Support chipsets that can write 
>> to llcc")
>> Signed-off-by: Atul Dhudase <quic_adhudase@quicinc.com>
>> ---
>>   drivers/soc/qcom/llcc-qcom.c | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
>> index 674abd0d6700..509d972c1bd9 100644
>> --- a/drivers/soc/qcom/llcc-qcom.c
>> +++ b/drivers/soc/qcom/llcc-qcom.c
>> @@ -941,15 +941,15 @@ static int _qcom_llcc_cfg_program(const struct 
>> llcc_slice_config *config,
>>           u32 disable_cap_alloc, retain_pc;
>>
>>           disable_cap_alloc = config->dis_cap_alloc << config->slice_id;
>> -        ret = regmap_write(drv_data->bcast_regmap,
>> -                LLCC_TRP_SCID_DIS_CAP_ALLOC, disable_cap_alloc);
>> +        ret = regmap_update_bits(drv_data->bcast_regmap, 
>> LLCC_TRP_SCID_DIS_CAP_ALLOC,
>> +                BIT(config->slice_id), disable_cap_alloc);
>>           if (ret)
>>               return ret;
>>
>>           if (drv_data->version < LLCC_VERSION_4_1_0_0) {
>>               retain_pc = config->retain_on_pc << config->slice_id;
>> -            ret = regmap_write(drv_data->bcast_regmap,
>> -                    LLCC_TRP_PCB_ACT, retain_pc);
>> +            ret = regmap_update_bits(drv_data->bcast_regmap, 
>> LLCC_TRP_PCB_ACT,
>> +                    BIT(config->slice_id), retain_pc);
> 
> Good catch, LGTM

Forgot to tell.,
Please tag this to stable as well.

Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>

-Mukesh

> 
>   Thanks
> -Mukesh
> 
>>               if (ret)
>>                   return ret;
>>           }
>> -- 
>> 2.25.1
>>