Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp604382rdf; Fri, 3 Nov 2023 09:29:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGZhCk1A3s/1YnBotWOWjldZNulyrCkxxMY7ss5Hk4tuL9gE+LXDoKAtFhy1Ceoc58Wial1 X-Received: by 2002:a17:90a:8583:b0:280:a27d:e897 with SMTP id m3-20020a17090a858300b00280a27de897mr10817741pjn.8.1699028985853; Fri, 03 Nov 2023 09:29:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1699028985; cv=none; d=google.com; s=arc-20160816; b=k0Qs0FqUxssEWan3Mcpr4bJoiZAdzek41mlmwB9TzV4ae71RK+LEYWw3JNhKTVlvQM ZuLtE2i6aghvampYaLXHJX1a6ZI7+a9r+SOFs0ttc3uUyHQ+3ErlgYqbSgcyz4etUOHN ttVtM+HKLwLdSdPgcfhDTCWDzUmWfMMG9viuSAlwVs22slujit+9kZfYlB6xMNTzfSc+ wsPIxJc/I7b1QuUWXm1JmReyrhdoXtzlGRrlg4J/kWAihChkgQkjds8kqRE3jUzYbUYv synIQriPM66KWV4e41i9Vdd5ImThqE/COxOunb/i1zTYpfSKy+qZOjdE/6EiZmvRZhYk kiOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=LTnkfaaMf1CLAmf1Rg2wsHS7BcVuqGkZNamaGh2FvQ4=; fh=p9z4nKtYlKY41xg9U/TVEZ3JPwcBQd7/27SVsN5Xhfs=; b=sw9Tf8BuqE6aM5gLTn2tfhpp7oY3dhAbpz0lDJ24jcdsdcYTdvllEx+0hw0AJ3OK6b 8saky4VrtBsaVC3MCDp9M+5NdDq7BrXXZI4PwLQIljIMmZzaOgA0ND73FRYpr1ZMmY4Z 6Sir3qAgP/Du9hYfPjdnr5F+MLlsBmsjWbViCKTFa/zcZ9wKuK8ZngKK+jSzrl0aQyjI UL4q70JSBhXcVc0Z7sCynre32pMBwU9TaCfv5eN0dQsidBdhBBgYZFvw+kxSWBWgKxxE zSg7Sb9kq6aN69cuC1bIrmNcdbZWx5g/lShvLSYZI26ndFKAwYEzrGoKElSh64mxsDDH fHQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=UbsJInSO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id lt13-20020a17090b354d00b0026f4d1e6940si1901193pjb.160.2023.11.03.09.29.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 09:29:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=UbsJInSO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 973478077F8A; Fri, 3 Nov 2023 09:29:41 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345581AbjKCQ0t (ORCPT + 99 others); Fri, 3 Nov 2023 12:26:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345287AbjKCQ0r (ORCPT ); Fri, 3 Nov 2023 12:26:47 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B46E0D6A; Fri, 3 Nov 2023 09:26:25 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-9c53e8b7cf4so335509666b.1; Fri, 03 Nov 2023 09:26:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699028784; x=1699633584; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=LTnkfaaMf1CLAmf1Rg2wsHS7BcVuqGkZNamaGh2FvQ4=; b=UbsJInSOefG71c85sFN7Bv5MY6GB5OP67Kvnhp9H344IpQHR4/IEjCmK9GODo3hH+Z D9lfwHBaaj6YHRIbgZrhFcMKe8/fIb63XbjAm4cSpm064nq4WuMVWLrxpeTL0KiNNTye i8HxNE/FbFeJgtPn6Lo20COmwlJU1xbvw5TqcQeZvqVUebkylipMPpKXad8XW262u+bF 09TumWtKl3EQPRJrZ4SSa9r6Hr/o7KxAipmVAoonPu/5GWZgoxIxEq9ajW1EQBDqPvCe HvD+d57Kyh9BSIJxeHzk4ufy1GWNrt1bcKDQva2JQVb+dgD7DNJoLB2PGEK2C6Ae6IVJ yk1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699028784; x=1699633584; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LTnkfaaMf1CLAmf1Rg2wsHS7BcVuqGkZNamaGh2FvQ4=; b=XnRLCTSEJyYTQmJRTvAcHuzbY4rxZXHDVX7qxP4ltN9Q1mIy5/eOJxb5IXYueMwCRK eHOXidJsvjX1eloVfffhOJ5DTjWj4y4z6/sC+4vhRkBWzDqbBjt2q+BQUEt1/OtKIxMm dUQndXrjgqAuunpB3YIY0gvdLl0SNtqdepwQ/W1tmC7KIPPV+Zd6Ce0LGnn80WJPU9fu ciW1rKF1jMv9MzbntKy7mnK0WY2hGarNL6d97d0Dt75eg5f5oJsy06WoAEyzWw4O2W17 ye6+kenxAWotvdUImMxPtBsO+J+XHUXfJOxUiHBLXV4s8yJCDFoH917+OrWmRT/izA9P TWHg== X-Gm-Message-State: AOJu0Yye/ix8LnEtUe7A2wU2/oFLVBsF7jLCrXFhkZShCK7vCJG2BBbZ dstqzrsA50Hr2tw/cxt23MJa9ujL44p38Q2LQ3jFsq6t X-Received: by 2002:a17:907:3685:b0:9bd:a7a5:3a5a with SMTP id bi5-20020a170907368500b009bda7a53a5amr7824353ejc.36.1699028784033; Fri, 03 Nov 2023 09:26:24 -0700 (PDT) MIME-Version: 1.0 References: <20231103112237.1756288-1-anders.roxell@linaro.org> In-Reply-To: <20231103112237.1756288-1-anders.roxell@linaro.org> From: Andrii Nakryiko Date: Fri, 3 Nov 2023 09:26:12 -0700 Message-ID: Subject: Re: [PATCH] selftests: bpf: xskxceiver: ksft_print_msg: fix format type error To: Anders Roxell Cc: bjorn@kernel.org, magnus.karlsson@intel.com, maciej.fijalkowski@intel.com, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 03 Nov 2023 09:29:41 -0700 (PDT) On Fri, Nov 3, 2023 at 4:23=E2=80=AFAM Anders Roxell wrote: > > Crossbuilding selftests/bpf for architecture arm64, format specifies > type error show up like. > > xskxceiver.c:912:34: error: format specifies type 'int' but the argument > has type '__u64' (aka 'unsigned long long') [-Werror,-Wformat] > ksft_print_msg("[%s] expected meta_count [%d], got meta_count [%d]\n", > ~~ > %llu > __func__, pkt->pkt_nb, meta->count); > ^~~~~~~~~~~ > xskxceiver.c:929:55: error: format specifies type 'unsigned long long' bu= t > the argument has type 'u64' (aka 'unsigned long') [-Werror,-Wformat] > ksft_print_msg("Frag invalid addr: %llx len: %u\n", addr, len); > ~~~~ ^~~~ > With u64s it might be %llx or %lx, depending on architecture, so best is to force cast to (long long) or (unsigned long long) and then use %llx. > Fixing the issues by using the proposed format specifiers by the > compilor. > > Signed-off-by: Anders Roxell > --- > tools/testing/selftests/bpf/xskxceiver.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tools/testing/selftests/bpf/xskxceiver.c b/tools/testing/sel= ftests/bpf/xskxceiver.c > index 591ca9637b23..dc03692f34d8 100644 > --- a/tools/testing/selftests/bpf/xskxceiver.c > +++ b/tools/testing/selftests/bpf/xskxceiver.c > @@ -908,7 +908,7 @@ static bool is_metadata_correct(struct pkt *pkt, void= *buffer, u64 addr) > struct xdp_info *meta =3D data - sizeof(struct xdp_info); > > if (meta->count !=3D pkt->pkt_nb) { > - ksft_print_msg("[%s] expected meta_count [%d], got meta_c= ount [%d]\n", > + ksft_print_msg("[%s] expected meta_count [%d], got meta_c= ount [%llu]\n", > __func__, pkt->pkt_nb, meta->count); > return false; > } > @@ -926,11 +926,11 @@ static bool is_frag_valid(struct xsk_umem_info *ume= m, u64 addr, u32 len, u32 exp > > if (addr >=3D umem->num_frames * umem->frame_size || > addr + len > umem->num_frames * umem->frame_size) { > - ksft_print_msg("Frag invalid addr: %llx len: %u\n", addr,= len); > + ksft_print_msg("Frag invalid addr: %lx len: %u\n", addr, = len); > return false; > } > if (!umem->unaligned_mode && addr % umem->frame_size + len > umem= ->frame_size) { > - ksft_print_msg("Frag crosses frame boundary addr: %llx le= n: %u\n", addr, len); > + ksft_print_msg("Frag crosses frame boundary addr: %lx len= : %u\n", addr, len); > return false; > } > > @@ -1029,7 +1029,7 @@ static int complete_pkts(struct xsk_socket_info *xs= k, int batch_size) > u64 addr =3D *xsk_ring_cons__comp_addr(&xsk->umem= ->cq, idx + rcvd - 1); > > ksft_print_msg("[%s] Too many packets completed\n= ", __func__); > - ksft_print_msg("Last completion address: %llx\n",= addr); > + ksft_print_msg("Last completion address: %lx\n", = addr); > return TEST_FAILURE; > } > > @@ -1513,7 +1513,7 @@ static int validate_tx_invalid_descs(struct ifobjec= t *ifobject) > } > > if (stats.tx_invalid_descs !=3D ifobject->xsk->pkt_stream->nb_pkt= s / 2) { > - ksft_print_msg("[%s] tx_invalid_descs incorrect. Got [%u]= expected [%u]\n", > + ksft_print_msg("[%s] tx_invalid_descs incorrect. Got [%ll= u] expected [%u]\n", > __func__, stats.tx_invalid_descs, > ifobject->xsk->pkt_stream->nb_pkts); > return TEST_FAILURE; > -- > 2.42.0 > >