Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <3fe787bc-f85c-4268-833f-86922415c4d3@linaro.org>
Date:   Fri, 3 Nov 2023 17:30:26 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] thermal: core: Add trip thresholds for trip crossing
 detection
Content-Language: en-US
To:     srinivas pandruvada <srinivas.pandruvada@linux.intel.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Linux PM <linux-pm@vger.kernel.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>,
        Lukasz Luba <lukasz.luba@arm.com>
References: <12317335.O9o76ZdvQC@kreacher>
 <6b22f4715641bc4ffc76eea8a4e6358bcbea9e1c.camel@linux.intel.com>
From:   Daniel Lezcano <daniel.lezcano@linaro.org>
In-Reply-To: <6b22f4715641bc4ffc76eea8a4e6358bcbea9e1c.camel@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 03/11/2023 16:42, srinivas pandruvada wrote:
> On Fri, 2023-11-03 at 15:56 +0100, Rafael J. Wysocki wrote:
>> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>>
>> The trip crossing detection in handle_thermal_trip() does not work
>> correctly in the cases when a trip point is crossed on the way up and
>> then the zone temperature stays above its low temperature (that is,
>> its
>> temperature decreased by its hysteresis).  The trip temperature may
>> be passed by the zone temperature subsequently in that case, even
>> multiple times, but that does not count as the trip crossing as long
>> as
>> the zone temperature does not fall below the trip's low temperature
>> or,
>> in other words, until the trip is crossed on the way down.
> 
> In other words you want to avoid multiple trip UP notifications without
> a corresponding DOWN notification.
> 
> This will reduce unnecessary noise to user space. Is this the
> intention?

Not only reduce noise but give a correct information. Otherwise the 
userspace will have to figure out if there are duplicate events after 
the first event happened. The same happen (less often) when crossing the 
trip point the way down.


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog