Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp633290rdf; Fri, 3 Nov 2023 10:14:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEZCHxGFbavfZa+vFadHca/CQj/kZmAR7Td5TcrboQnfshUWDKNpmwWG/FYBVZfJe3wg4GQ X-Received: by 2002:a05:6808:649:b0:3b2:db24:6384 with SMTP id z9-20020a056808064900b003b2db246384mr22114105oih.38.1699031641184; Fri, 03 Nov 2023 10:14:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1699031641; cv=none; d=google.com; s=arc-20160816; b=PV1KVpD71poE+lVSDoHCVz+ArmD/5vgSpt1AVjZS5VEUwnZSDQBdWDbSUloktNWHoc FtdvH727IjejI7b7yZB3WopqZMb4L9vHYIYQJerYZ06DUjTTi2DIfabdSyoNY4ZbLVPE Au3T5VhDjExWA0zGz6KHx2tjCKeMHf1FewbWkrUwtLw2eyGvwv5dYB/GkuWInXbMRTS0 Xi2l/chdROXgw6AphRZvSYgl8oIw1oepaOnfTgC5XhsFU10xzd3/K3A9h8azG47i08W+ iVt2dd1kpQs5mcolLEuiLNYR9oOW8BvAmbeCdk2XYD4v5BkAFxWI/fUpNms33T1WQhrb QtUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=h+nD4Pgw2evypVGggTd49EnVE5xcgPJPs+ysRzIDo+E=; fh=XoRNUbuwHgBoNI7skjvzta4o2sZnJ7zGzTHGpm+4Fv8=; b=NcC1ujxnGDyp5KQEWRSHYuNVWQERLfDxHQFxANngxOd8hs5i0zQ00dWymSEdfOq96j 2JpojtVS1j0YWRNUhmGxrWuu8YGrGAzGruJ+jomVAs/hcevyiG+P/1ipYCOXnV6OwaZl 3kJZofh/FXtihbhRUWE2dwNM3b7rkwIMUCB91bbAy2TYre4dIljbL/kRGYpg0UXu4oMa hXNaxGKH7TqN4CRyPyZ01g/8hglCY4WlLR09pZ44Cmcca5HUY1rXWzjJRi8aNLpe8Ul5 x+5MQFXERGmY0270gPNd7RySGUuQAZXcJ0nxHk2wlmkLaqPg8HbOyMMt1KjAsUk9Hr9s R2+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="A3+nkL/l"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id w21-20020a9d70d5000000b006ce291abe16si794984otj.53.2023.11.03.10.14.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 10:14:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="A3+nkL/l"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 9C29D832ED21; Fri, 3 Nov 2023 10:13:58 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230185AbjKCRNp (ORCPT + 99 others); Fri, 3 Nov 2023 13:13:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229487AbjKCRNo (ORCPT ); Fri, 3 Nov 2023 13:13:44 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 528B813E; Fri, 3 Nov 2023 10:13:41 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-5079f6efd64so2845562e87.2; Fri, 03 Nov 2023 10:13:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699031619; x=1699636419; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=h+nD4Pgw2evypVGggTd49EnVE5xcgPJPs+ysRzIDo+E=; b=A3+nkL/l8fmcGrlVHMMt4xSOLgv0+wFu6p0LB6mBvgpuomNJ613+zzQ/aFMQlzQS/U LwXWlkWUKHY54RQgVFMsoawqw93M8R5FWLu20TxOQrkERnMCTPowa/gIZOaG3blrZoCO 4svu/C42RHuqLxRCbjzJUkU38uP0QvkIpfqfUJXePIIHO4kqBeDlcn0e+4fv8Eehc6p9 fxhVz1KfXAAz4eG8Zo+H3iJPkjq1dO7DAfeLIM8JQqZbZGNq7AaAZTWaVF+mfh4Vmmg/ RSqoeOTOuxoDqabNDmU911GrhX+UbIBG0qf5jdEqkEisfezhLvzLMSeoPc76KS3v8OE4 NZug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699031619; x=1699636419; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=h+nD4Pgw2evypVGggTd49EnVE5xcgPJPs+ysRzIDo+E=; b=tKHC/1ZjTwzIPCOMb+Cit+jL3wPQSv2NhJ93uXECB5BHfWOJGRTAd34Zzl71T633DP CxUAC3CocPaHmrItKSKKYEaAPRNM2jc0TtitfTdwUe3omABtxP/S9RO7t+LvXIGzVEUp l/pGXSOxUqyEKs2FUhsbfP+oYGMTyUQHz7pq/UJwPZVics1X4dP7a2e0f8TvSwB7HL+l OA3v45rpRXic6LrET6aUProQzywTJ4dR3LB1li1H7k5fiiKpgD5pyWmOgwUPgrQR13OE M9+XdaJkFIxUJY/BIxm9+N2pPFzVYMpZC65eOzHHIYvpJhUW3CunfLLWTSDfPsWs8G5l JBlQ== X-Gm-Message-State: AOJu0YzC4gD44jGX95iBubNH0mjEzdchwCdgcs9fi/iCaet7wWyR3Tnq 4a7bAZwH+KFxeB/0Jdbk+jkM3UKka5Qxp0+WSLCKmLZTlMoghg== X-Received: by 2002:a05:6512:b9c:b0:509:4814:ed7a with SMTP id b28-20020a0565120b9c00b005094814ed7amr5920283lfv.36.1699031619171; Fri, 03 Nov 2023 10:13:39 -0700 (PDT) MIME-Version: 1.0 References: <20231030-fix-rtl8366rb-v2-1-e66e1ef7dbd2@linaro.org> <20231030141623.ufzhb4ttvxi3ukbj@skbuf> <20231030222035.oqos7v7sdq5u6mti@skbuf> <20231030233334.jcd5dnojruo57hfk@skbuf> <20231102103123.hklqlsbb5kbq53mm@skbuf> In-Reply-To: <20231102103123.hklqlsbb5kbq53mm@skbuf> From: Luiz Angelo Daros de Luca Date: Fri, 3 Nov 2023 14:13:27 -0300 Message-ID: Subject: Re: [PATCH net v2] net: dsa: tag_rtl4_a: Bump min packet size To: Vladimir Oltean Cc: Linus Walleij , Andrew Lunn , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 03 Nov 2023 10:13:58 -0700 (PDT) > > Hi Luiz, > > On Wed, Nov 01, 2023 at 09:35:30AM -0300, Luiz Angelo Daros de Luca wrote: > > Hi Linus, > > > > Sorry but I noticed no issues: > > > > From the router: > > > > No. Time Source Destination Protocol Length Info > > 1 0.000000000 192.168.1.1 192.168.1.2 ICMP 1514 Echo (ping) request id=0x0789, seq=23/5888, ttl=64 (reply in 2) > > 2 0.000040094 192.168.1.2 192.168.1.1 ICMP 1514 Echo (ping) reply id=0x0789, seq=23/5888, ttl=64 (request in 1) > > > > From the host: > > > > No. Time Source Destination Protocol Length Info > > 1 0.000000000 192.168.1.2 192.168.1.1 ICMP 1514 Echo (ping) request id=0x0002, seq=8/2048, ttl=64 (reply in 2) > > 2 0.000391800 192.168.1.1 192.168.1.2 ICMP 1514 Echo (ping) reply id=0x0002, seq=8/2048, ttl=64 (request in 1) > > > > If I go over that limit, it fragments the packet as expected. > > Could you run the shell command that sweeps over the entire range, fromhere? > https://lore.kernel.org/netdev/20231030222035.oqos7v7sdq5u6mti@skbuf/ Sure. I might be able to run it on Monday. I'm away from the device and it might have OOM. It has too little RAM to survive too much time by itself. However, I doubt it might fail at a specific packet range as it would hang an interactive SSH session quite easily. Regards, Luiz