Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
From:   Armin Wolf <W_Armin@gmx.de>
To:     jithu.joseph@intel.com, hdegoede@redhat.com, markgross@kernel.org,
        ilpo.jarvinen@linux.intel.com
Cc:     Dell.Client.Kernel@dell.com, platform-driver-x86@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/4] platform/x86: wmi: Add wmidev_block_set()
Date:   Fri,  3 Nov 2023 19:25:23 +0100
Message-Id: <20231103182526.3524-1-W_Armin@gmx.de>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:AO80qY1xqck=;mwIb49Y7ZM/H3DhA3/huyU3Llpb
 y2Qxn7rrnlSrtySjpWGH/NolzUUnPP4OcVF5YvVjg8AGkCND8++dQgqwf3Ns+aTtlsvaTqx3w
 64WKB7dnprdlpsT5cwtG3XrawLA4LE8ppWlTHAYzNOvvf3q41KeZxFiFCC6+B0XymXpYjZxLY
 ot1EiK4+x+LAsyEy8K+Ms1ktdGMHOdMqrWFhUbMy9Mhn+6skBS4VcaV8Mu1Rlokbyn+Sqt/tP
 ULOpGeWYWvMXmLK5W2vh9k/ynWGl6Ex2Hbp3crPjsLnYxO6LQrRwmKKTLwXXta3f3KzQJ62dK
 Tw25PgdKsEMDrakJRf3/zk+mkP+/UNhxHIWqDBRRxpILFk8qKx9vF6oV0NLUNWnv1hfmDDeod
 /qgv6jrPjEfV8iTMbvnj8dA9hV8dlfx9WV9Ka4Te5IoMFrjHqL5DiggjDbiCTD8NJNhRzg3tg
 sHgqFcM+27xj8O3TH/5CsafICilY3o06nKYBKjSjuO9WtuQSIyXyLwkJqaXmrlByQeBuoIFkI
 1tfOuVR9Xv0DQ1FjLa5vmoDHPiOXv4UgV0nPA2iLdoLgL3CSQSFpmzvH1cpDE16H8NARfgDee
 rc/SZl1+nEpoUxNsb5Uie6Uy5v9EXKDEJw0cfB9QO4IsGAJRwxdiyNyfht0EhwliQOCQV2XDU
 d26bCmxy2LU5nlf+UEjyZldFIWoT27b9A+4vp+DaiLesbZpCvAlZZeplQU5oEXxZiVGplz4xV
 azshg5yxA6yRI5UlnIaoYroBgKbVy+BsxojC1g5tNZITK6imJ5SjdLkqkKdfWl+dEhLh/Be6+
 ccdMWPFNsXJEQtbAdxFvdWFVVt5mZCVemC2n+38RhLiLsOKfJT+iq2nJMwYyhk9HvUjZ52pG7
 t+AnTSl56yttvs3Nw4Qay//2CKWfBRHX7vUNYi/ZiS2mjl7+zqdVrEvHS35z/n1f5fN0B6zuC
 GZCLjbVs7tzuM3n3Bq9aCOITGaQ=
Precedence: bulk

Currently, WMI drivers have to use the deprecated GUID-based
interface when setting data blocks. This prevents those
drivers from fully moving away from this interface.

Provide wmidev_block_set() so drivers using wmi_set_block() can
fully migrate to the modern bus-based interface.

Tested with a custom SSDT from the Intel Slim Bootloader project.

Signed-off-by: Armin Wolf <W_Armin@gmx.de>
=2D--
Changes in v2:
- applies on pdx86/for-next
=2D--
 drivers/platform/x86/wmi.c | 64 ++++++++++++++++++++------------------
 include/linux/wmi.h        |  2 ++
 2 files changed, 36 insertions(+), 30 deletions(-)

diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c
index 5c27b4aa9690..9d9a050e7086 100644
=2D-- a/drivers/platform/x86/wmi.c
+++ b/drivers/platform/x86/wmi.c
@@ -536,41 +536,50 @@ EXPORT_SYMBOL_GPL(wmidev_block_query);
  *
  * Return: acpi_status signaling success or error.
  */
-acpi_status wmi_set_block(const char *guid_string, u8 instance,
-			  const struct acpi_buffer *in)
+acpi_status wmi_set_block(const char *guid_string, u8 instance, const str=
uct acpi_buffer *in)
 {
-	struct wmi_block *wblock;
-	struct guid_block *block;
 	struct wmi_device *wdev;
-	acpi_handle handle;
-	struct acpi_object_list input;
-	union acpi_object params[2];
-	char method[WMI_ACPI_METHOD_NAME_SIZE];
 	acpi_status status;

-	if (!in)
-		return AE_BAD_DATA;
-
 	wdev =3D wmi_find_device_by_guid(guid_string);
 	if (IS_ERR(wdev))
 		return AE_ERROR;

-	wblock =3D container_of(wdev, struct wmi_block, dev);
-	block =3D &wblock->gblock;
-	handle =3D wblock->acpi_device->handle;
+	status =3D  wmidev_block_set(wdev, instance, in);
+	wmi_device_put(wdev);

-	if (block->instance_count <=3D instance) {
-		status =3D AE_BAD_PARAMETER;
+	return status;
+}
+EXPORT_SYMBOL_GPL(wmi_set_block);

-		goto err_wdev_put;
-	}
+/**
+ * wmidev_block_set - Write to a WMI block
+ * @wdev: A wmi bus device from a driver
+ * @instance: Instance index
+ * @in: Buffer containing new values for the data block
+ *
+ * Write contents of the input buffer to an ACPI-WMI data block.
+ *
+ * Return: acpi_status signaling success or error.
+ */
+acpi_status wmidev_block_set(struct wmi_device *wdev, u8 instance, const =
struct acpi_buffer *in)
+{
+	struct wmi_block *wblock =3D container_of(wdev, struct wmi_block, dev);
+	acpi_handle handle =3D wblock->acpi_device->handle;
+	struct guid_block *block =3D &wblock->gblock;
+	char method[WMI_ACPI_METHOD_NAME_SIZE];
+	struct acpi_object_list input;
+	union acpi_object params[2];

-	/* Check GUID is a data block */
-	if (block->flags & (ACPI_WMI_EVENT | ACPI_WMI_METHOD)) {
-		status =3D AE_ERROR;
+	if (!in)
+		return AE_BAD_DATA;

-		goto err_wdev_put;
-	}
+	if (block->instance_count <=3D instance)
+		return AE_BAD_PARAMETER;
+
+	/* Check GUID is a data block */
+	if (block->flags & (ACPI_WMI_EVENT | ACPI_WMI_METHOD))
+		return AE_ERROR;

 	input.count =3D 2;
 	input.pointer =3D params;
@@ -582,14 +591,9 @@ acpi_status wmi_set_block(const char *guid_string, u8=
 instance,

 	get_acpi_method_name(wblock, 'S', method);

-	status =3D acpi_evaluate_object(handle, method, &input, NULL);
-
-err_wdev_put:
-	wmi_device_put(wdev);
-
-	return status;
+	return acpi_evaluate_object(handle, method, &input, NULL);
 }
-EXPORT_SYMBOL_GPL(wmi_set_block);
+EXPORT_SYMBOL_GPL(wmidev_block_set);

 static void wmi_dump_wdg(const struct guid_block *g)
 {
diff --git a/include/linux/wmi.h b/include/linux/wmi.h
index 763bd382cf2d..207544968268 100644
=2D-- a/include/linux/wmi.h
+++ b/include/linux/wmi.h
@@ -35,6 +35,8 @@ extern acpi_status wmidev_evaluate_method(struct wmi_dev=
ice *wdev,
 extern union acpi_object *wmidev_block_query(struct wmi_device *wdev,
 					     u8 instance);

+acpi_status wmidev_block_set(struct wmi_device *wdev, u8 instance, const =
struct acpi_buffer *in);
+
 u8 wmidev_instance_count(struct wmi_device *wdev);

 extern int set_required_buffer_size(struct wmi_device *wdev, u64 length);
=2D-
2.39.2