Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
From:   Armin Wolf <W_Armin@gmx.de>
To:     jithu.joseph@intel.com, hdegoede@redhat.com, markgross@kernel.org,
        ilpo.jarvinen@linux.intel.com
Cc:     Dell.Client.Kernel@dell.com, platform-driver-x86@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH v2 4/4] platform/x86/intel/wmi: thunderbolt: Use bus-based WMI interface
Date:   Fri,  3 Nov 2023 19:25:26 +0100
Message-Id: <20231103182526.3524-4-W_Armin@gmx.de>
In-Reply-To: <20231103182526.3524-1-W_Armin@gmx.de>
References: <20231103182526.3524-1-W_Armin@gmx.de>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:q8UMX7KAnko=;4OSPvC/EVc8P4XuVJXRiDEyNCdx
 8QvXoSv3IXtwguCojCI51nzg1QG605jASOAec/CafX/7v/IcMtmuvJlLW5fvU3k7ro5AwOqQW
 GKozNSCkOXcaIPfzkmoU6NWv7xhD6S7ynZGLjxqPMrcROc/lrUEANZ7QsHg9TVKUzsOHltFfF
 ZCHpJO35lgTGp6FD/7XLrILJxgaIMUwaVb9VRI4Ofk8C+DY3PFyQAN4qDuuOMf/Kh3eiuxRih
 mjVKWSeDIxfO+PC0NwYWo0k90yxJz2rsoBy5UgYcgfBLs6lqWhR0pckwTNNvewivVcpBaTC4Q
 DJUY7PVFkc57dyVaWMEcciN/afh9eGbtOZqdBM44hqBVOUWZIAo+GfWDhfld2QIYfD8KTbniw
 GEFhcWcqC5UPdd1XPAQgokRzAf/YVG/aTFD+xldRHOEeRiw1bsoq4RYqsPxefluc+U0B7ez0+
 NcXsNFkwfedlEOAXYIo1FfPOa44V9IxtZwY0X1p4MMt16V1XQ1QyY0Y24d8fSX6pjBjiv0iFO
 rpT6EKyljV82tTYTKetCJfs1YruX84PJaJXzYfarOPcIH65pTDp1/jACSdWNliMeBW/M+5iGh
 Z0lm5Jw7xRJGoMojUQlWhIKNExme+YL1m60jXXVRjHrrbPAA0V/jA7SI95ClTffnpF7WSgt2h
 e2iHI8uBW63TCTwj44/5e75vbL6NOgfU9eqBr62ow1jh1ZzEJVESbiPCKB1iLqEzySdbDuENB
 x9TntJS160+QyjwSpfRu1sw895GEqqf3cxSrCejtfb0TWhlGhR80Wm5HwnDnjSo7qJQIpucSY
 4zYey2bQMyNNhn1hMhznliRwlZrhq0wiJaLOMdXhfqz4uAJ8M4Tk3ILXLr4bBOBxm6AP6vbrM
 4i4ycZ+A+mf+bsWMMqIaQCpXyuslp7M91NZUOd1LxKrtGmqltUlco8BdxrsC3fFwC0BNALg3W
 XwV+nj15MIj5ETQRVsDp8kYQtNk=
Precedence: bulk

Currently, the driver still uses the legacy GUID-based interface
to invoke WMI methods. Use the modern bus-based interface instead.

Tested on a Lenovo E51-80.

Signed-off-by: Armin Wolf <W_Armin@gmx.de>
=2D--
Changes in v2:
- fix spelling issue
=2D--
 drivers/platform/x86/intel/wmi/thunderbolt.c | 3 +--
 drivers/platform/x86/wmi.c                   | 1 +
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/intel/wmi/thunderbolt.c b/drivers/platfo=
rm/x86/intel/wmi/thunderbolt.c
index fc333ff82d1e..e2ad3f46f356 100644
=2D-- a/drivers/platform/x86/intel/wmi/thunderbolt.c
+++ b/drivers/platform/x86/intel/wmi/thunderbolt.c
@@ -32,8 +32,7 @@ static ssize_t force_power_store(struct device *dev,
 	mode =3D hex_to_bin(buf[0]);
 	dev_dbg(dev, "force_power: storing %#x\n", mode);
 	if (mode =3D=3D 0 || mode =3D=3D 1) {
-		status =3D wmi_evaluate_method(INTEL_WMI_THUNDERBOLT_GUID, 0, 1,
-					     &input, NULL);
+		status =3D wmidev_evaluate_method(to_wmi_device(dev), 0, 1, &input, NUL=
L);
 		if (ACPI_FAILURE(status)) {
 			dev_dbg(dev, "force_power: failed to evaluate ACPI method\n");
 			return -ENODEV;
diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c
index 4c4effc883ae..cb7e74f2b009 100644
=2D-- a/drivers/platform/x86/wmi.c
+++ b/drivers/platform/x86/wmi.c
@@ -107,6 +107,7 @@ static const char * const allow_duplicates[] =3D {
 	"05901221-D566-11D1-B2F0-00A0C9062910",	/* wmi-bmof */
 	"8A42EA14-4F2A-FD45-6422-0087F7A7E608",	/* dell-wmi-ddv */
 	"44FADEB1-B204-40F2-8581-394BBDC1B651",	/* intel-wmi-sbl-fw-update */
+	"86CCFD48-205E-4A77-9C48-2021CBEDE341",	/* intel-wmi-thunderbolt */
 	NULL
 };

=2D-
2.39.2