Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp700050rdf; Fri, 3 Nov 2023 12:14:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEaLZTkZYoRWKNXGaAZGTy51TrVuu9EJ6kE00B+BK4sQYmtAF/ZFD4wFwWhHwheK4lNpLCa X-Received: by 2002:a17:903:2283:b0:1cc:6f51:b166 with SMTP id b3-20020a170903228300b001cc6f51b166mr12417575plh.65.1699038860534; Fri, 03 Nov 2023 12:14:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1699038860; cv=none; d=google.com; s=arc-20160816; b=eIp9nkSC/KH39HMTIThKEIg9EgTQn63wsQTaLwZUf8mNPaAIMAlD3dYPPnhA/S/9Xy kJ4CuMKXx9LTiZNjUgMnTu6lNaBGU20oANQHXHz+NTfc5KN+cYRBkTfQ9LF5RfmfuZ41 0L0KeXJXX4Tab/u8I6rcxapxbEBFB0xcqkThBUAdKAxki92vLr8XBHmZPCAtMeeSKVZN aKlKPRQPZiiwyFap71EJHlJtNUdh76Or3AxbcvSEtn8+ZUlCN3hmLbvlV++ij1R4vaEr Tve763JjBVHwgso/mmYV/0dD1FGAMYPgiqBeKQKp6MyKkGyBJTjMpsJ1idhtL18xQogT TYuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=YqSGG3PRTCl3pCDwU0Cdv8eHz8EUQW+Q1dGS28H6GdE=; fh=x7JMiUXMN6lB7KwBf++iy+njuIBkfeBrelQPqsS3hA4=; b=w7zDbdgYw4B7mfzpnPuvH8IWZrCiKZvBNhTsZRrVPm04vNfoBBNIm3jApdI3+08iLP 8eevcj/7vUfyqEo/Y8ztMZIoP/uDWwd3Vm4a7kia0VUuzQSLcOQpRvU8nTf8GDRvO77+ /o0AHyOyqea/9cabNmNjAb0Vj1ek27edIlLzpnUKrqPwtB2fqwVap1VePTAogU1zDQXc FExIMZg31qnFD9n9Fj0e+PIziBdw5qtQiQiN1OpvNlGv/oWnZ4XEVYNa9tuvF95IVLoK c8l1kn6YI+mUBOo4VFdk3pnCl0Rq/Ps1KAaOLuZUWYWrhiukin3oU6F/4+948KDsKgoC 1ifg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=G3nVeqvp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id v17-20020a170902d09100b001cc649af5e7si1959296plv.243.2023.11.03.12.14.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 12:14:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=G3nVeqvp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 9670E82C0F82; Fri, 3 Nov 2023 12:14:01 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345518AbjKCTMT (ORCPT + 99 others); Fri, 3 Nov 2023 15:12:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231204AbjKCTMQ (ORCPT ); Fri, 3 Nov 2023 15:12:16 -0400 Received: from mail-oa1-x2b.google.com (mail-oa1-x2b.google.com [IPv6:2001:4860:4864:20::2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E31DBD for ; Fri, 3 Nov 2023 12:12:10 -0700 (PDT) Received: by mail-oa1-x2b.google.com with SMTP id 586e51a60fabf-1f0820b7657so375386fac.2 for ; Fri, 03 Nov 2023 12:12:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699038729; x=1699643529; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YqSGG3PRTCl3pCDwU0Cdv8eHz8EUQW+Q1dGS28H6GdE=; b=G3nVeqvpjVkqTwJDg1guutHHw3KlgCg2cH3ixjrckAbZI0xV53rjVAwkWH6SzICfGY bFw+OGgcUECIVbBPCpDAYJvYKMA0iMWDkpjt/wvGg+1uji7K5DRTT0YcRwc2zw17V8zm 6Ccff6sygzedcOjAE6D2akFg5pqJLewXlyJBg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699038729; x=1699643529; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YqSGG3PRTCl3pCDwU0Cdv8eHz8EUQW+Q1dGS28H6GdE=; b=nOf5jtgksxb4VXy/EvBwy/iYfOBAQmPMf4WRNsC0eSA+3IHgFQNi2p48JvygprtSKB 1lye/cxOVvYhxjDgi8KWPWMg3t9v+UYY2tYCzGzX9h0mMAv9sbe5A9TLtSBV7pmc+IKu yjomq4RGuIp3e3OVVe5Dx5EaXjZukXqM39gCQrQq39fX+IZcP2nwGajY+SDYDTfnUKiJ hcb7WuCfUX9frdMRE6O4v0uQgrOk7m4AV+hif4WuAPUt20mT1ZpN6mqqB0pCfRjsqbzr 5jKO3Or9L81hT9WaGRmJlLxmjpi3vNXAqsrqNflRxD3rA7a02BPPf/061iVVMOCHGXnc kIwA== X-Gm-Message-State: AOJu0YwXWQWTHDfP98OGvAoi+GALhKifvDKre4llnV2x1hO91gxX4l0M o0XQqSLqf4bmvCVSk88V4QCPUE6iXE3LH7Oc30YzyA== X-Received: by 2002:a05:6870:4202:b0:1ea:7bd1:c48d with SMTP id u2-20020a056870420200b001ea7bd1c48dmr28837428oac.49.1699038729662; Fri, 03 Nov 2023 12:12:09 -0700 (PDT) MIME-Version: 1.0 References: <20231102221309.1971910-1-hsinyi@chromium.org> <20231102221309.1971910-2-hsinyi@chromium.org> In-Reply-To: From: Hsin-Yi Wang Date: Fri, 3 Nov 2023 12:11:43 -0700 Message-ID: Subject: Re: [PATCH v2 1/4] drm/panel-edp: Add several AUO/BOE panels To: Doug Anderson Cc: Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 03 Nov 2023 12:14:01 -0700 (PDT) On Fri, Nov 3, 2023 at 9:02=E2=80=AFAM Doug Anderson wrote: > > Hi, > > On Thu, Nov 2, 2023 at 3:13=E2=80=AFPM Hsin-Yi Wang = wrote: > > > > Add a few generic edp panels used by mt8186 chromebooks. > > Besides, modify the following panel: > > - AUO 0x235c B116XTN02 renamed to B116XTN02.3. > > - AUO 0x405c B116XAK01 adjust the timing of auo_b116xak01. According > > to the datasheet: T3=3D200, T12=3D500, T7_max =3D 50. > > > > Signed-off-by: Hsin-Yi Wang > > --- > > v1->v2: Address comments: update delay for auo_b116xak01, sort entries. > > --- > > drivers/gpu/drm/panel/panel-edp.c | 57 +++++++++++++++++++++++++++++-- > > 1 file changed, 55 insertions(+), 2 deletions(-) > > This seems good to me now. I guess a tiny nit is that the ${SUBJECT} > mentions AUO/BOE panels but a few other model panels are also added, > but it's not a huge issue for me. > Yeah, it should be "drm/panel-edp: Add several generic edp panels", the same as v1. If there are more comments that I need to send a v3, I'll fix that in v3. > Normally I apply patches to this table near-instantly, but since it's > Friday and this touches a lot of panels, I'll probably wait until > sometime next week. > > Reviewed-by: Douglas Anderson