Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp704414rdf; Fri, 3 Nov 2023 12:23:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFcuFuK6tIGGJYCFkOa4Y8FMFAB+XD4QsmhbEROmhc8yt0leeOhFybwyleE4CA9gip8iby0 X-Received: by 2002:a05:6a00:1da8:b0:6c3:3795:dd66 with SMTP id z40-20020a056a001da800b006c33795dd66mr5077462pfw.16.1699039410652; Fri, 03 Nov 2023 12:23:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1699039410; cv=none; d=google.com; s=arc-20160816; b=DKn9epaPYiO+XfSEgIeRIH7yJNVv4HijhNmdTVr8mttQYdT2uxW9Wmb7pEVEBD5VMq wL2oSuX8MFAOMDLMSbmadmjnY+5Ppbuf2jntPTiZZbOftkxIHYva4g1C7NtHc1ZszGap dtfme5+h/5bJ5o07+6ji59aIJWt+bmmcNQp1rgY4UnOA3EHNyU1N8munA4XHZrcBlID6 IsJAtIco3t1uj2axbDfV7R+FLuUY2tOz7jGJKQ8tIKDj7JF3D3wo7Vl4TBaA9G8MUJjG szOnxUSe5t6q5cYjD2ypZX2WvWssuEghpg+LUtdJ/QQPjAT0LkL2s2EGTuD8/CvVWbvZ 3p7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :message-id:subject:cc:to:from:date:dkim-signature; bh=l1C83T1TeWK1vNX1mj72OPs9HazSbS9NGexru/ShBnw=; fh=4pdWGsgi+xIdC/9fOXnWxIcRFQeeMXTHQYJJdEdzXNA=; b=AXzn9b2pCJ24POaRA6ugYszSiX/+C+8T93kno6wdc6PV5Kg0HW4BUIyK2b2X4rzBed sXsq7EgTZnDjDZc6ZlLO2zMp0foRAqebHu+VJ3fs+nOdy+5iR8vcxTbUBTztiXbQDBMt vbW57kpc8Wykb17VOr4IzGqnM2SuRLiBvIwnQG625RFBFFRW7Xb3bm83cEuNb6i+KQKq rTxWWpDML5CTPeZMB/6y02/MWIIqMrpdJ0taDxg8YfuAO2rQK82Hr01NCpPF9j8IhFfB 9YIjA9p9i+m/DLcKpYlKAR6z+lT9nA0zSEVlurkttSWaq7Z/NRfF8ovJCwiNs7zZf96K Xxpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ATOS90CQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id b14-20020a6567ce000000b005b9053cf6f2si2068312pgs.163.2023.11.03.12.23.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 12:23:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ATOS90CQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 86E8C80907A7; Fri, 3 Nov 2023 12:23:13 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234266AbjKCTVK (ORCPT + 99 others); Fri, 3 Nov 2023 15:21:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232839AbjKCTVJ (ORCPT ); Fri, 3 Nov 2023 15:21:09 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 990A4D73; Fri, 3 Nov 2023 12:21:00 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E611AC433C8; Fri, 3 Nov 2023 19:20:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699039260; bh=7MN/U949LXBUJuxhHGoevzr7GxH9ANzavjzuKeHmEFI=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=ATOS90CQjIPKFdQUNME1YOl/ZNO2l4vdA/tAPEX5FuZ7YB0AZw3Rg48H9VhtnnOA7 VtX7UDME19I2utp0+HF+lTQWr1D2hH09nX463+1I6RWUaNBEbWhgPk6cHDBxOANA2/ GbhdCLcNRwLIWfdX1Sj8XI23fCuZmPAunNQ+ynphpjxhJc317uikh3sxlMhff1fqtK FCtukqW5Kj1gGpk6aAglpD5Efco/VWlsxThbznSAwnIfQu5rtd4/zabCMIAZ5h2wrN d43JcoHYz09h5jLLSCD3wjOJ1MfFJa73nnUnofNlVsP2Q8bxmAm1uiL68bvht0+bEj icfdgBagHldvQ== Date: Fri, 3 Nov 2023 14:20:58 -0500 From: Bjorn Helgaas To: Mario Limonciello Cc: Karol Herbst , Lyude Paul , Alex Deucher , Christian =?utf-8?B?S8O2bmln?= , Bjorn Helgaas , Hans de Goede , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , Mika Westerberg , Lukas Wunner , "open list:THUNDERBOLT DRIVER" , "Rafael J . Wysocki" , "open list:PCI SUBSYSTEM" , "open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" , "open list:X86 PLATFORM DRIVERS" , Andreas Noever , David Airlie , Marek =?utf-8?B?QmVow7pu?= , "open list:RADEON and AMDGPU DRM DRIVERS" , "open list:ACPI" , Danilo Krummrich , "open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" , Manivannan Sadhasivam , Michael Jamet , Mark Gross , Xinhui Pan , open list , Daniel Vetter , Yehezkel Bernat , Pali =?utf-8?B?Um9ow6Fy?= , "Maciej W . Rozycki" Subject: Re: [PATCH v2 0/9] Improvements to pcie_bandwidth_available() for eGPUs Message-ID: <20231103192058.GA164718@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231103190758.82911-1-mario.limonciello@amd.com> X-Spam-Status: No, score=-1.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 03 Nov 2023 12:23:13 -0700 (PDT) On Fri, Nov 03, 2023 at 02:07:49PM -0500, Mario Limonciello wrote: > Downstream drivers are getting the wrong values from > pcie_bandwidth_available() which is causing problems for performance > of eGPUs. > > This series overhauls Thunderbolt related device detection and uses > the changes to change the behavior of pcie_bandwidth_available(). > > NOTE: This series is currently based on top of v6.6 + this change that > will be merged for 6.7: > Link: https://patchwork.freedesktop.org/patch/564738/ Thanks, Mario, I'll look at this soon after v6.7-rc1 (probably Nov 12), so the amdgpu patch should be in mainline by then. > v1->v2: > * Rename is_thunderbolt > * Look for _DSD instead of link > * Drop pci_is_thunderbolt_attached() from all drivers > * Adjust links > * Adjust commit messages > * Add quirk for Tiger Lake > > Mario Limonciello (9): > drm/nouveau: Switch from pci_is_thunderbolt_attached() to > dev_is_removable() > drm/radeon: Switch from pci_is_thunderbolt_attached() to > dev_is_removable() > PCI: Drop pci_is_thunderbolt_attached() > PCI: Move the `PCI_CLASS_SERIAL_USB_USB4` definition to common header > PCI: pciehp: Move check for is_thunderbolt into a quirk > PCI: Rename is_thunderbolt to is_tunneled > PCI: ACPI: Detect PCIe root ports that are used for tunneling > PCI: Exclude PCIe ports used for tunneling in > pcie_bandwidth_available() > PCI: Add a quirk to mark 0x8086 : 0x9a23 as supporting PCIe tunneling > > drivers/gpu/drm/nouveau/nouveau_vga.c | 6 +- > drivers/gpu/drm/radeon/radeon_device.c | 4 +- > drivers/gpu/drm/radeon/radeon_kms.c | 2 +- > drivers/pci/hotplug/pciehp_hpc.c | 6 +- > drivers/pci/pci-acpi.c | 16 ++++++ > drivers/pci/pci.c | 76 +++++++++++++++++--------- > drivers/pci/probe.c | 2 +- > drivers/pci/quirks.c | 31 +++++++++++ > drivers/platform/x86/apple-gmux.c | 2 +- > drivers/thunderbolt/nhi.h | 2 - > include/linux/pci.h | 25 +-------- > include/linux/pci_ids.h | 1 + > 12 files changed, 109 insertions(+), 64 deletions(-) > > -- > 2.34.1 >