Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <a07b735c-fffe-4846-a4a2-ac1be397497a@intel.com>
Date:   Fri, 3 Nov 2023 15:49:23 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 05/24] selftests/resctrl: Create cache_size() helper
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
CC:     <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        LKML <linux-kernel@vger.kernel.org>
References: <20231024092634.7122-1-ilpo.jarvinen@linux.intel.com>
 <20231024092634.7122-6-ilpo.jarvinen@linux.intel.com>
 <3849d986-caf4-41ad-85c7-11f11f986e1c@intel.com>
 <12d53aae-177f-ff1f-306a-607eeae17ce3@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <12d53aae-177f-ff1f-306a-607eeae17ce3@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dHpoekZxZzJkeUZmS3luZkxOVTlONDI3a0VwM0VmUzd2TUVUK2hCWUZTbjFT?=
 =?utf-8?B?OGpyZU5LcWRFUlZXS0lLbCtUTGZkMmRnQlZNcjBSSG9lTC9RcTY3amphNGln?=
 =?utf-8?B?cFZGemVJcjFUWmxqQkd5ckU5N3laY092SnNqOTZ2WERiZ1ROWXl2MG5jVlBI?=
 =?utf-8?B?N2FBcnFkY0lyRHZJekc1T0NneXRHVldIQy9oWEUzajNPQ0ZOOXdRU1gvVWxP?=
 =?utf-8?B?NmlDSkRCeE1sNStjd1N5RDExbElYNy96U2VQallseDdFMk84aGRDWWF3YjBS?=
 =?utf-8?B?V1RxUlhXU295VjhCL2M1ODd3bzNJVnhJZHBxZkw5Q2hKU0IzR3BURGN3MzFR?=
 =?utf-8?B?M2lKY2lyb05raXg0NzhkNmJkYkZtYzNKZFFwa05acjVHWW9NaHBNRTNGZ21u?=
 =?utf-8?B?Wm40WXVJK1laYlEyQkdCM0VOYnIwMmgyWGlIdUdpUVNSeFdaUHEzZWYxbnN0?=
 =?utf-8?B?N0dlT2ZCdFRpUWRLdW1xVEpNbm9oOTVZWXlKVUJkdkNxWlBLdzRnQ0U2VEZz?=
 =?utf-8?B?WTBBaVdQdlhXMXZxMkMydXJrdHFrZHE5bXhwc3V6bURLcWxrb0tZMTBRWlNl?=
 =?utf-8?B?WkM5cnpqWk9YK1c1cXN6YTkrNDNvNXZRckR6T1A3ZHRBS3g1R09NSkpITGds?=
 =?utf-8?B?K0NJSzhBdVJSOXNzR2l5bHA5ZW9GSUl6VjdXM2swWTlZOUR2OWpSendhVkRs?=
 =?utf-8?B?V3MwVXAvaG9XbTdYU0kycXJkMTF2aUQxQy9xckd1VEUyMytkdkI1aStybndY?=
 =?utf-8?B?TG9XekRoVjJpc3BVRFgyZUsraSt4eVhYOFhRckNsKzJpUGtuM081K1pUNkxM?=
 =?utf-8?B?UE9KcHprNCtnam1NNTY5eW1DRjVnWGhNZS9JTlhmRTUvWlVRbFVXamJPM1dH?=
 =?utf-8?B?TmxlQ1lhd1NDY0kvR2xMZ1FYd0dnMzY0cjNFQzN5YkJIMXpzcHNiY25TaXJ5?=
 =?utf-8?B?NHRQUEh5Qk5XZUtzNEJ6OWxLdE5YY2Q3NjI0NWFNSEdKcWFxNkhYdU15d1pl?=
 =?utf-8?B?b21iWS9CYkh3OGdQa1Bsc0Q0QkpQaDZrV2xwUUNReS92RG1oTHlzWm04OEpx?=
 =?utf-8?B?VXk4R2V6VFBZK3J5UDB5MlU4bmZLeVpXK09uaERrR3k1YXliYzliMHRNQXB3?=
 =?utf-8?B?SzJxdGk2MGloUnI2WUN6Y1pWS3hLRXRSMTFsbVN2YS9HWTVkSktXazUzM2ZE?=
 =?utf-8?B?bWczZjVablkrWGtLWGkvMFlQYmJNY0pZOUhKWTlTTVRMVmVleS9OczQ4OEFr?=
 =?utf-8?B?bGE3RWFKNUQ2bVE3aW5GUlBMbEp0dWozKzFwUXV0SnlibUR6STQ3RFVURDlS?=
 =?utf-8?B?dnBqc1hxeFArK2owS0lEOFFsUzRJVTliOWV0V0RZU1BVZHZ6UGRVM3lsOGJV?=
 =?utf-8?B?ZS92UkZiV3Q4Rit6RWsyMXVPK0tnUFpYWFk5Z0c2V3JxOU14WHErLzByVkZP?=
 =?utf-8?B?aDZ5Uno2eUlEWlpJb1NYY0xMeE5vY0JldjREUVQxdFBZdVZCWGpDekRTeEI0?=
 =?utf-8?B?T1R3QXkzRWYyclpFMytQTDhVTlhqNUZHd24wbVZoNXBGL0xOMFdXbnMvcnpP?=
 =?utf-8?B?Mk1Fd05RQktheXlDQmE4MDVkQ0xRaENpZU53ZFprWUoyS3V4Tk1ZVnp4TGYv?=
 =?utf-8?B?ZnBXRHlxMUFCc09yS1QrcmtaVGRxai9rYWZRdFQxSHZWSmxneEh3ZEZpOEJH?=
 =?utf-8?B?Y2RvWERucERIZXR2bi9oWnVRdmVKNGR0MmVvS0FFeGJUVENTZXhDQmNhdTVl?=
 =?utf-8?B?ZHk5N0NPT2w5NkFmdkdzNTJzMm8vQjJ2eWVEZ3ZxQjRBekFQeWFOZWNlVVd2?=
 =?utf-8?B?bVBxUlQ3cVE2cS8xM0ZybVdVYzJ0MUNQTG5LdUtpWkpwWWR0bDB5bk44RGhr?=
 =?utf-8?B?SSthM2phS2ZIVlJUbXFxYWVKS3p3Q0JlaHhwQm5NQTc3eUZtRDc2cWFuU0F3?=
 =?utf-8?B?TWtEWXRMQ2l2Ynp2eDNHRXovTUNhOUNid3RNaG81UXRydklJbW1ZZzhOTk9n?=
 =?utf-8?B?TktnTENyOWJMRVFkOUZzOEJxSGVHa0NMbHRMMHhpLzhJdVU1VFQrbm8xbU9G?=
 =?utf-8?B?QXYzOUp2NlN1OC9sWmlTeHpBNTAyQzBhZmltQkFzUm42dEV1QnMxSS9xdHdE?=
 =?utf-8?B?UEFoem1OWnlnY005bnV2SERPQ0ZGUUxNbzk3Uzl6V3AwMW9zcDFuaHJmT1V0?=
 =?utf-8?B?Mmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: dcea1a1e-8cbf-451d-1452-08dbdcbf2121
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2023 22:49:25.9747
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kR8QXIPUcKJW5q4VJK3n9IU3A50guRzzHiIrXuIzWaOSW/+s3yLrHZDnnos57ZIxurnbNsfJ0izshoFfnAF8p272A5jHLMxTNOXgNt+4yPY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8723
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 03 Nov 2023 15:49:34 -0700 (PDT)


Hi Ilpo,

On 11/3/2023 1:53 AM, Ilpo Järvinen wrote:
> 
> Yes, I'm more than happy to rename them. This naming was what you 
> suggested earlier. (I used cache_alloc_size() or something like that
> initially and you were against using "alloc" in the name.)

My apologies for giving poor guidance. I cannot recall the thread behind
that guidance but looking at these changes together the cache_size() and
get_cache_size() naming does seem close enough to cause confusion.

Reinette