Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <81b3a379-f815-48b9-a126-19b12ff63e17@intel.com>
Date:   Fri, 3 Nov 2023 15:50:49 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 18/24] selftests/resctrl: Introduce generalized test
 framework
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
CC:     <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        LKML <linux-kernel@vger.kernel.org>
References: <20231024092634.7122-1-ilpo.jarvinen@linux.intel.com>
 <20231024092634.7122-19-ilpo.jarvinen@linux.intel.com>
 <56769c01-e21d-4775-94f0-ef9f863c1e92@intel.com>
 <ffdeb9a9-c066-19c-9898-c2bdf632cef1@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <ffdeb9a9-c066-19c-9898-c2bdf632cef1@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bWUvK24ra2ZzMlNkL2hiNGU5ak9DVE5zMUdwcDRnVVAzNDhDTUd6UnhRS0pD?=
 =?utf-8?B?U1VnQ0Q5MzBVejErekV0cTQyYTJVZU1UL0E1YjFZKzJVNFZFczRWT2ZZamRK?=
 =?utf-8?B?S2gxMllFcG01WHBJMmV5NDdtL2Q3MzZSRmY0SjRxOGhzSWRmdHpnNG4xVG4v?=
 =?utf-8?B?QTR3OG1UWnZwbFA3bng1UFg1MkNCNitkOFpRK3BEc3V4UjFwZU9sbFZxMzB3?=
 =?utf-8?B?RFBkNWx1b1ZBZG1IVjVVb240QTB0b0xwekFLL3N1NW5abktzS2pyM1NMdytT?=
 =?utf-8?B?ZEtvbkg2VXJlTWNnblpacTViWkRneEN4Z0czUHV3b1owcVpuaGNFeWNWQ0V2?=
 =?utf-8?B?eTJxSEc5YjFmdExWbmNNYm9BSmhuK0lRSWVDQnVrUTVHRFR5SEJXREx1d3cw?=
 =?utf-8?B?WW93ZUhkNDZCdzhZV2NhdGllWityVmhIY3dLc1JIMlgrYTZWZDFyMEFhUmV0?=
 =?utf-8?B?Z1k4Qitpc0ZwUENGVEVYWFEvSkFjYjZIRGNCUi9IYXJwMTNsWjJ4SjhNY0tK?=
 =?utf-8?B?ZmFpc3JqV2lROXpBYmlTRW13TjJldGpJTDJkWUVqNElXSUtFMTFCdFlKNmNr?=
 =?utf-8?B?R1pkSEs5dWlvY1RlSGRtRFFBTGRMdmpKZVkyWjlXbkJwNklhZXhwN2xyWC85?=
 =?utf-8?B?V2U1OGZja0dENDBIcHlXekdZZFZUMUFDaWtRVFBnYmxTRDNNVkU5clZGNjR6?=
 =?utf-8?B?Z3J0U0E3eG9iQUxBejNOaTVOa1R5NHNoV2ZLWjVyczdiS0lFU29DTFByMWtr?=
 =?utf-8?B?Nm5rUzZiK2taUHBabWYrbkNURFNIT2VIS09sakRZZ3pBdUZSTU9RQkZxaGVE?=
 =?utf-8?B?RlBRVGxMSjNhZDZYclVLOElFaFpBTzNEV2JadEhNZitxUFVYbUNpbGttNGs1?=
 =?utf-8?B?SEJMeFRrazhQMG1ROUNpUDVLU2RHK2JheGJPSW5CUnk2SVdSdEpZcG05c3No?=
 =?utf-8?B?U3pRTzRGWTloVGFFam5ldHJzd2hsS1RVT285M0xIOTlrK2ZrcXlsa2FHajE4?=
 =?utf-8?B?NGo5aFNraXJVak1KSnhuRFdEUVJIU2EwQ0JoaFloSnNuY0htNU9XWHNEZGV5?=
 =?utf-8?B?ZnFVTm1WQW83SCtieDFoWDBCSmJtUE15dDI5Z3kydmE0aVg1RlRDL3N1L0xu?=
 =?utf-8?B?MUo2V0JDZ21RUDQvTUYzQWhFblY2STFWZS82YWpKcW9rTXk3c3dWS2dRUkd0?=
 =?utf-8?B?QmVJSnhWbjM0c29vaXFid3IwUmFBVk5KRXErZkw5eG1tN2k1MG8vZ0VQQjRt?=
 =?utf-8?B?M1ZTNzZNVTNZOUY0K0xrNTFUTjZGSEZsOTZyR3Jsd3FFU0hQMWtKMXduamRB?=
 =?utf-8?B?VWNpcGRrR0pUTFVMdlFMVUZZTTUvajQ0Q1RwK2lGN1ZGbmVLNlJsZmw3K2Zt?=
 =?utf-8?B?STJUUmRJSmhad0RJSDVyQmlKUFp6L3NPN1ZPbytka1pvbFdVVm8yVGx0ZFJ5?=
 =?utf-8?B?RHNDVm5sTjBFSlY1Yk42dHMzZG5CSE03c3dVbXMzWGJiTTFWa1hsdDNlNDF3?=
 =?utf-8?B?V2NaUzRiOWdpRzVjQ3NFcjFrcm5KVXRKczR6OVFkaGdpeGRpZWpxWUhhMVBw?=
 =?utf-8?B?N2dQWVpKRThMUkgyTUZJeFp4QTFtSlJBTHZkQVd5R0htTVlmMkUwUWZkQW44?=
 =?utf-8?B?OE12NUpjUlN0a3ZJSFFBZjZJL0F2N1ZPUjhUekR2WFZFeUxxYktHcnh2S3hE?=
 =?utf-8?B?eGdJODFFYktiVUpWMjRFZklBbEVXYTFVNERPUUZCMVBJemQ5aHNlQ013N2Q3?=
 =?utf-8?B?RFZnNEtXcThCeXUyS1VpV2ZjaXBLZ2lIRThEWnpWUFBURCtQaFVUZlJRQkJk?=
 =?utf-8?B?N1BURXRYcFBlTVhvRGowS3ptSEdnVndCbjJBK1ZseStBWk4zTUhCd0lvR3BE?=
 =?utf-8?B?WFYxdXRadGpxSTN0QXRrL3FUYXdNUUJZMWVENG9DVkgxNUlDQndMRTJVS2do?=
 =?utf-8?B?TkkwS2F3dEdYY2Uwb3JDY1ljV2tsZlZtR0t5Tk9MM244WmNJdnk2VWtCbnRH?=
 =?utf-8?B?M1dtNEhpVnQ1TGFrZWZjVFEzVm9HcG9TdUFCeVdnVGtQR0g1Y1hEUVJnanlx?=
 =?utf-8?B?TWhiYVZpWTZnOHpwWmZVN0tpaktMME5wTys5b0gvdldDaW9xZ3FuUUl3TXAv?=
 =?utf-8?B?bVdtckdwbFpFTVlLNUkwSmxoZk9IYm5NUzU2R2tWZlFzNFcvYnh4Z2pqU1pt?=
 =?utf-8?B?T2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a398ad0-9d7c-4ce8-e02a-08dbdcbf53bc
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2023 22:50:50.5832
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +xlxch1TeAR5aXroeZMgDJl8dugooy6AHgBlCN7t0omGszYwNQNLI9bTlzjATACj0+YVRTHcxZkp4EaA6hkhwR89+zWOXdQj/tmoOn79+KI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8723
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 03 Nov 2023 15:51:23 -0700 (PDT)

Hi Ilpo,

On 11/3/2023 2:54 AM, Ilpo Järvinen wrote:
> On Thu, 2 Nov 2023, Reinette Chatre wrote:
>> On 10/24/2023 2:26 AM, Ilpo Järvinen wrote:
>> ...
>>> diff --git a/tools/testing/selftests/resctrl/resctrl.h b/tools/testing/selftests/resctrl/resctrl.h
>>> index ec6efd36f60a..e017adf1390d 100644
>>
>>> @@ -233,25 +183,26 @@ int main(int argc, char **argv)
>>>  		case 't':
>>>  			token = strtok(optarg, ",");
>>>  
>>> -			mbm_test = false;
>>> -			mba_test = false;
>>> -			cmt_test = false;
>>> -			cat_test = false;
>>> +			if (!test_param_seen) {
>>> +				for (i = 0; i < ARRAY_SIZE(resctrl_tests); i++)
>>> +					resctrl_tests[i]->disabled = true;
>>> +				tests = 0;
>>> +				test_param_seen = true;
>>> +			}
>>>  			while (token) {
>>> -				if (!strncmp(token, MBM_STR, sizeof(MBM_STR))) {
>>> -					mbm_test = true;
>>> -					tests++;
>>> -				} else if (!strncmp(token, MBA_STR, sizeof(MBA_STR))) {
>>> -					mba_test = true;
>>> -					tests++;
>>> -				} else if (!strncmp(token, CMT_STR, sizeof(CMT_STR))) {
>>> -					cmt_test = true;
>>> -					tests++;
>>> -				} else if (!strncmp(token, CAT_STR, sizeof(CAT_STR))) {
>>> -					cat_test = true;
>>> -					tests++;
>>> -				} else {
>>> -					printf("invalid argument\n");
>>> +				bool found = false;
>>> +
>>> +				for (i = 0; i < ARRAY_SIZE(resctrl_tests); i++) {
>>> +					if (!strcasecmp(token, resctrl_tests[i]->name)) {
>>> +						if (resctrl_tests[i]->disabled)
>>> +							tests++;
>>> +						resctrl_tests[i]->disabled = false;
>>> +						found = true;
>>> +					}
>>> +				}
>>
>> Could providing multiple "-t" result in the test count not
>> matching the number of tests run?
> 
> bool test_param_seen covers the case with more than one -t parameter.
> Because of it, the code above resets tests and ->disabled only when the 
> first -t is encountered. tests++ is only done when ->disabled is set from 
> true to false.
> 
> I don't see how they could get out of sync but if you had a more specific 
> case in mind, just let me know.
> 

Thank you for your detailed explanation. I can now see how this is safeguarded.

Reinette