Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp803133rdf; Fri, 3 Nov 2023 16:19:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG2abDNFoPVhw/FnDL69Nq/rkldH/Dy8jxE2Fws59C6edcX0K7kvbxktP5ZifzZMKqwsC+D X-Received: by 2002:a05:6a20:12c4:b0:181:275f:3b4f with SMTP id v4-20020a056a2012c400b00181275f3b4fmr10068882pzg.11.1699053542556; Fri, 03 Nov 2023 16:19:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1699053542; cv=none; d=google.com; s=arc-20160816; b=nT67NEDuci89lGZpgXl/eb3W2hUgLB1NrqdEAWUsWy4k/8mRbkDVRR1ks9ML5ezUzs l6pH985epjYxQTsq6MWg7Qtrd5D6cNFtaCLSlKOsJtjXOylrSMbaDQuqzPd3xDwpgfyh 3lICofyCphRiV895ipcPZl0fwNnCkF8FH15+3dlCHEhEBnasPgrCIKdis1lpGuM3J33N S9kNO8lJ5bcvsRa/zDNwQdb/bWa00A0mU+d3IKir1JEg8IfGYAoPHflYHRjk0tpSZZpO 2YfPzqssGtAcJBQzB87wc3t9FUg2Wvp8DFSapeOqjj3nawxKfVF2E1JmYnGyG8blIWH/ 8Q6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=EUmRHvTQc1DzXbF2Te1K0K+hGK6pEUjIwadabL+ZWL0=; fh=kfJf1t2HIp1mvSYgL6hLdsiU+5UKJmbGqT5tKnOGL5A=; b=aLIDSmUqs0dtYk3DIvhXxCzv/hDNazMQT8WthelYQtNM4bdq0j0rPflYuQm2ZQgD3e sE/ouChlVl1jrN/QH9bzK74oABVpNf14MxO6FPcc1jNX7dQpHzkfZTPpTvn7h9midSJL CCVFEFBfpW+aKzfRxTb24vjeFPpZ65D4spmbmDzUflJwzKWqTMYqx2yKJtN1F/kaXzfV XLXAyVTXSgELDjRba/NAePnvrXpBFRDqek69QRpjdl4pbIIJcrfdewBoqG7NO0dVR59i C378pLtslORbDLATSJUoiqUs5vdP/CzChQ61/9JXqeStWhtK27AaOMxIXtShFHmeRLX6 KRwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ERIPyEnC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id v202-20020a6361d3000000b005ac44f928e4si2311436pgb.152.2023.11.03.16.19.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 16:19:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ERIPyEnC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 2ED7481BDBB1; Fri, 3 Nov 2023 16:19:00 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231592AbjKCXSv (ORCPT + 99 others); Fri, 3 Nov 2023 19:18:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230145AbjKCXSu (ORCPT ); Fri, 3 Nov 2023 19:18:50 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D745D5A; Fri, 3 Nov 2023 16:18:48 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-6bcef66f9caso553793b3a.0; Fri, 03 Nov 2023 16:18:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699053527; x=1699658327; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=EUmRHvTQc1DzXbF2Te1K0K+hGK6pEUjIwadabL+ZWL0=; b=ERIPyEnCh0JAWgUhr3LH5Yl06w2QGJSjKWkMefkrqT6BLwKgrj3T49xPbZVTuh89ud OQsBxPXDD0vbBZamvz9Qo+T4Yj0YpSzkKPe+vV0AfXXvfSI9lJDibnpxTPC8HAdNKjfr f/DR6aAGoTOd1izypmkyiQf2Iiw7ZL9KcK099WmGCPoH3tYuqCOiI66vGk5zZ1cG2WBE vm7xN1XynN/9uCnAeoUeTZaXEGeWlh8Q7a1KF4QAWwO4ogOMXbnUbPgOAferfs6Sq+wK AZ/pGoCT9BfpxzCzSlRZSfz2lebomRXu7pJjDKL1Za5OQjYOtF1gFPdS/p5hGdKgIcUR Kaog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699053527; x=1699658327; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EUmRHvTQc1DzXbF2Te1K0K+hGK6pEUjIwadabL+ZWL0=; b=ernqL2vmOJbYnLiJqTPy5ehD34vavYiw6RkDyS+CsIY7M183ic1tMbXDJ7TI5EKIHh BqJCwL7QHBAoOYBmVqyfNloPqzyRlXwG4d4jx2nscnzLWSMPCak3xwGizgplezQKei7g ITGpfUA0iD6gma2wUE0iWMl6Cz83eEaWT2PCAOGIDVRftAS199WiR/0n5UEl3ljeq9x5 qgYVODasJnyI9PEe8OJY26miG6h4JeYYLKiJyKEqgsqR00nZkZxWEe0DxnsE1/9QacKg mFgEQfbfDFFQ4i4ZTTjH6hPbrfBIKCX9K2cGCnRcwhN8aNAo7XXV2dn0mivUEy9rJXXR uHpg== X-Gm-Message-State: AOJu0YzgdMlgcaFiZL1CUyLWKvQ0QKJxqoAS8n5vL3MLvEoTIWBxdR/J UQ66PkE1Ed5gDhcFy8HT3mo= X-Received: by 2002:a05:6a00:468e:b0:6c0:81a3:fe4c with SMTP id de14-20020a056a00468e00b006c081a3fe4cmr24831172pfb.3.1699053527619; Fri, 03 Nov 2023 16:18:47 -0700 (PDT) Received: from hoboy.vegasvil.org ([2601:640:8000:54:e2d5:5eff:fea5:802f]) by smtp.gmail.com with ESMTPSA id y11-20020a62f24b000000b006c067f1b254sm1880560pfl.122.2023.11.03.16.18.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 16:18:47 -0700 (PDT) Date: Fri, 3 Nov 2023 16:18:44 -0700 From: Richard Cochran To: Edward Adam Davis Cc: jeremy@jcline.org, davem@davemloft.net, habetsm.xilinx@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, reibax@gmail.com, syzbot+df3f3ef31f60781fa911@syzkaller.appspotmail.com Subject: Re: [PATCH net-next V3] ptp: fix corrupted list in ptp_open Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 03 Nov 2023 16:19:00 -0700 (PDT) On Fri, Nov 03, 2023 at 09:15:03PM +0800, Edward Adam Davis wrote: > There is no lock protection when writing ptp->tsevqs in ptp_open(), > ptp_release(), which can cause data corruption, use mutex lock to avoid this > issue. The problem is the bogus call to ptp_release() in ptp_read(). Just delete that. No need for another mutex. Thanks, Richard