Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp876692rdf; Fri, 3 Nov 2023 19:45:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEx5bbOojdA6PfY3LWpqf2VV5RXVDFXpsNGO3kfNmkQ90SaMocrzMzTcyOuBZO4zZhPVI+M X-Received: by 2002:a0d:cb95:0:b0:5a1:d63f:5371 with SMTP id n143-20020a0dcb95000000b005a1d63f5371mr4856818ywd.20.1699065922064; Fri, 03 Nov 2023 19:45:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1699065922; cv=none; d=google.com; s=arc-20160816; b=NunXng4q25+nv7f86uJ1MBfm2usLDricSnM0M7XHjEErSO/5Zt425IAYf5JxGc53ug ta0GurNdIyN8aPlI46JGo75BXQiYdC1IvdApgk/qI3xXB4x2WfpbNQE9BPX8ggT2ay9A TttYTp6xZUWxneE670IX/ppywU7wnQagKyN+vJxBcy7y8nKoLdsMtRGsDUnjegMhmOQw WkfTRgn+5wpOMMRyk9puMw6YwcgrXaONumiOxhDsJ/KLuakTp2VhV1DhKE45gmgxfEss Dw5RDRzu+3HSbfKUlM1D4NtnjxV8iBQkJcZuF7LgkvvlzpQlkwB1IRPhXcc6cnUko6zs 7IzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=WKGQz1joPLPha7R6fZ/AtC4HHorloARO2OZK7OLX04w=; fh=+RQi2SkZs68q4MrEfdJetbH1Ug/f3wMFrIqvSdXM9Uc=; b=bD+pBtlKimczMbmfOCZAaRTzSNEzuPlw/p0YpOevmxXKBCr+BtQ2ubyuqk0duesPra 3R/8KgJgjM2ebBJssTWQdqufLcmbUKd1TT4ofgdejYHk5Bi5BCiHCSQjovcvqippGoUh zu8sT94uRaYcRRWQvKYJ6jFwoTX2VtFaySDFNVDzNDIc8yXXWBHRwiRh/8mceMYRkYpS dqjPpSXrCxKmx3ODfTdhnWzCMQLv2WM8Pc44SmTJaStLHbzvbGkawvbL4rWpX2LymKqn RRGl7kCBvfaqAHx57XpM8J02nXupX9OqnAWMB51HlIdKHxrk+x3AbYvmw21mTd2jv5ei RqvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=VL0+3GQi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id y40-20020a056a00182800b006b4c1a2085fsi2803963pfa.168.2023.11.03.19.45.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 19:45:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=VL0+3GQi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id DA6F9832DCEE; Fri, 3 Nov 2023 19:45:04 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230295AbjKDCo6 (ORCPT + 99 others); Fri, 3 Nov 2023 22:44:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229661AbjKDCo5 (ORCPT ); Fri, 3 Nov 2023 22:44:57 -0400 Received: from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com [IPv6:2607:f8b0:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D73D2D44; Fri, 3 Nov 2023 19:44:54 -0700 (PDT) Received: by mail-oi1-x22e.google.com with SMTP id 5614622812f47-3b2b1af964dso1692614b6e.1; Fri, 03 Nov 2023 19:44:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699065894; x=1699670694; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=WKGQz1joPLPha7R6fZ/AtC4HHorloARO2OZK7OLX04w=; b=VL0+3GQixLlL7MRLUACL+gKsfjyuKguKa5QbZfplDOHdswMTSzP/YTZUxy7ffZKNTE GGylS724BFTHYsWpx3mogAZOjwfew/bfJTjXGflawRnIAy+qrkYiggB8DAonbrN6J7ZN zDIdkIMIhDqrI2nAwonYVL7yUZKZkqs7uOOeZmlQXd997s53HOJ5nw3h6LW0onqRARu+ nysfAScqQt6Os20TiT8SmeU145ep9TiwgatMhIS3vTA/QuEN9WjjtUc7aVwhO/T5+8jo g4t1UFCvODzRQuB2u90d3eqeTfZeI9x04VZ2OYq6Tx5amsWZA9YQLrFfiS04NYOSgEQh bIXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699065894; x=1699670694; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WKGQz1joPLPha7R6fZ/AtC4HHorloARO2OZK7OLX04w=; b=ZH5vN4KCsG7SM6q770fe70jQUqE468sm0DGBGtbirLpAf9PAToVYctQUtnm6DVotRF AsRTBCTwkvK8wSaCGFKZnzlMGlg7+hhGn6uMn85w3rqw1PuNw4yOQ/m7aGE6cDeAcVnI OHufH2xqCO0PpJZkILfJHqBPfdP+IxjcUpHh8dcjsYYB9zylMb66zvIFz2748YNZOxPa Q9av89ggodUj2zpLOP0TLi1ilqw1YKj5K9IDTxb6fdPPafNOYWiiTZi9aOwlPxkjgxQ9 +X+mWASFsGQyNgdI/+MzMY/MzjbKg11xcvldLoH+yuIlNLRyL6tUS6NFWyEGqxV7sjcw mirA== X-Gm-Message-State: AOJu0Yz94tCEflEBy0xw/N5ibqL4jtsburo//xRHYZss7kwsfM7aFWHg PH35zSEbX8DknzMpG4o9Kqc= X-Received: by 2002:a54:4492:0:b0:3a7:c13:c8d1 with SMTP id v18-20020a544492000000b003a70c13c8d1mr23004058oiv.17.1699065894105; Fri, 03 Nov 2023 19:44:54 -0700 (PDT) Received: from localhost ([183.247.1.252]) by smtp.gmail.com with ESMTPSA id w19-20020aa78593000000b006b4ac8885b4sm2110862pfn.14.2023.11.03.19.44.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 19:44:53 -0700 (PDT) From: Tao Chen To: song@kernel.org, jolsa@kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, yonghong.song@linux.dev, martin.lau@linux.dev, john.fastabend@gmail.com, haoluo@google.com Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org, chen.dylane@gmail.com Subject: [PATCH] bpf: Use E2BIG instead of ENOENT Date: Sat, 4 Nov 2023 10:44:44 +0800 Message-Id: <20231104024444.385484-1-chen.dylane@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 03 Nov 2023 19:45:05 -0700 (PDT) Use E2BIG instead of ENOENT when the key size beyond the buckets size, it seems more meaningful. Signed-off-by: Tao Chen --- kernel/bpf/stackmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/bpf/stackmap.c b/kernel/bpf/stackmap.c index 458bb80b14d5..b78369bdec8d 100644 --- a/kernel/bpf/stackmap.c +++ b/kernel/bpf/stackmap.c @@ -570,7 +570,7 @@ int bpf_stackmap_copy(struct bpf_map *map, void *key, void *value) u32 id = *(u32 *)key, trace_len; if (unlikely(id >= smap->n_buckets)) - return -ENOENT; + return -E2BIG; bucket = xchg(&smap->buckets[id], NULL); if (!bucket) -- 2.34.1