Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp896968rdf; Fri, 3 Nov 2023 20:59:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH03GabnbQ891o/TmoqyPTvq/7Oljjk7KjvWJk2V/3bDuDvGwkNnX7BCK0j3kOF6L8htKfV X-Received: by 2002:a0d:d5d4:0:b0:5a7:d11c:f0ed with SMTP id x203-20020a0dd5d4000000b005a7d11cf0edmr4541923ywd.33.1699070349703; Fri, 03 Nov 2023 20:59:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1699070349; cv=none; d=google.com; s=arc-20160816; b=crdfClOHJcpBu1LmYUl7uxGDa44rXE6iQzAOC6PSYoKz1BEXtHVdfFdHWBthM5lCJ4 IviyNQqGAovUmXQMJnO8KUl5YvWAgdGXC9HBijqa2rX57f+srQUvElt+wSZwGdcH+y2K nLuImKDsMq8/WL3onlDCRW9iYEKFd6H5CONGBSTzyudOS1F/1/tNpOS705CHvdLUUJRA JReLt8YLmvl03c+OFF0M0HQ9DwEhdWsk2kbtIMdtlDUW19yiTw7eL5p1nX00vNEfFaUj 1Q2ubnNRjrInwW1z2gXchyRzb82745ezk0mdhHbGEp+Qo7oy+ScS5/LYkUnOxGQxc0RP 249A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=7wZOUGy5+jcsD0xoW9rwrp04wZN/LasfoPkwkE+Wdow=; fh=CcJo0L9wfd8BA3NJ4Bp0Ui/21KhdfkaxtXe28o6dgs4=; b=daKqJkK9WdmADZtbowjFpgN91HXRwvAeIch780NoQTFSy+mhG8DXCFcG8Hyx6+FHr4 YtDTB9kkXlkXxDQ8GFzQ48nzYCM5wFg85h7FNmq94QhELaqNliNBHsGKzGTeJmoYdVnv 1r23T7GfzMaGsNsWVRmZBznvVnjKkjKEeVrhC0xMVNMAgVi3Ksno2rcAied1zF9qMELp +aOS7tHljQVBZOm8MdYNaJ8LuHuq8d/6H9TEXrDmojxvTXOMbBtkuyU0WGRtVY3F4XN2 jECXoD3Wi3z/kpwVcUjhLSZlp2IlxxTys/g8/rwdQcAmHlO15l9CvTE1XBnehBLBl4fP yU+A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id e128-20020a636986000000b0057745d87b53si2768033pgc.686.2023.11.03.20.59.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 20:59:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id B653B8208F38; Fri, 3 Nov 2023 20:59:06 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233707AbjKDD7B (ORCPT + 99 others); Fri, 3 Nov 2023 23:59:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377973AbjKDD7A (ORCPT ); Fri, 3 Nov 2023 23:59:00 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C06F21AA; Fri, 3 Nov 2023 20:58:57 -0700 (PDT) Received: from dggpemm100001.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4SMkPQ15y9zVlM1; Sat, 4 Nov 2023 11:58:50 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Sat, 4 Nov 2023 11:58:55 +0800 Message-ID: <61c0f155-1cdd-4865-b047-88fbdc661ac3@huawei.com> Date: Sat, 4 Nov 2023 11:58:55 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH rfc 00/18] mm: convert to use folio mm counter Content-Language: en-US To: Matthew Wilcox CC: Andrew Morton , , , David Hildenbrand , References: <20231103140119.2306578-1-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm100001.china.huawei.com (7.185.36.93) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 03 Nov 2023 20:59:06 -0700 (PDT) On 2023/11/3 22:30, Matthew Wilcox wrote: > On Fri, Nov 03, 2023 at 10:01:01PM +0800, Kefeng Wang wrote: >> Convert mm counter page functions to folio ones. >> >> mm_counter() -> mm_counter_folio() >> mm_counter_file() -> mm_counter_file_folio() >> >> Maybe it's better to rename folio mm counter function back to mm_counter() >> and mm_counter_file() after all conversion? > > I deliberately didn't do this because it's mostly churn. > Once all callers of mm_counter() and mm_counter_file() have been > converted to use folios, we can do one big patch to convert all > callers to pass a folio instead of a page. > I re-order the patches as you say, please help to check v2, thanks.