Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
MIME-Version: 1.0
References: <20231104090603.4253-1-wuqiang.matt@bytedance.com>
In-Reply-To: <20231104090603.4253-1-wuqiang.matt@bytedance.com>
From:   Max Filippov <jcmvbkbc@gmail.com>
Date:   Sat, 4 Nov 2023 02:31:42 -0700
Message-ID: <CAMo8BfK4zDfdh9-WLq+gg1B47ht5hxhvH_j5veEj6JG38meTuw@mail.gmail.com>
Subject: Re: [PATCH v1] locking/atomic: xtensa: define arch_cmpxchg_local as __cmpxchg_local
To:     "wuqiang.matt" <wuqiang.matt@bytedance.com>
Cc:     chris@zankel.net, andi.shyti@linux.intel.com,
        andrzej.hajda@intel.com, palmer@rivosinc.com, geert@linux-m68k.org,
        linux-kernel@vger.kernel.org, mattwu@163.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, Nov 4, 2023 at 2:06=E2=80=AFAM wuqiang.matt <wuqiang.matt@bytedance=
.com> wrote:
>
> The xtensa architecture already has __cmpxchg_local defined upon the
> native __cmpxchg_u32 and __generic_cmpxchg_local

This description does not make clear why this change is needed. Could you
please expand it to cover the 'why' part?

> Signed-off-by: wuqiang.matt <wuqiang.matt@bytedance.com>
> ---
>  arch/xtensa/include/asm/cmpxchg.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/xtensa/include/asm/cmpxchg.h b/arch/xtensa/include/asm/=
cmpxchg.h
> index 675a11ea8de7..956c9925df1c 100644
> --- a/arch/xtensa/include/asm/cmpxchg.h
> +++ b/arch/xtensa/include/asm/cmpxchg.h
> @@ -108,7 +108,7 @@ static inline unsigned long __cmpxchg_local(volatile =
void *ptr,
>   * them available.
>   */
>  #define arch_cmpxchg_local(ptr, o, n)                                   =
      \
> -       ((__typeof__(*(ptr)))__generic_cmpxchg_local((ptr), (unsigned lon=
g)(o),\
> +       ((__typeof__(*(ptr)))__cmpxchg_local((ptr), (unsigned long)(o),  =
      \
>                         (unsigned long)(n), sizeof(*(ptr))))
>  #define arch_cmpxchg64_local(ptr, o, n) __generic_cmpxchg64_local((ptr),=
 (o), (n))
>  #define arch_cmpxchg64(ptr, o, n)    arch_cmpxchg64_local((ptr), (o), (n=
))
> --
> 2.40.1
>


--=20
Thanks.
-- Max