Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <a55f6941-ddf6-2355-271d-5ed0db5a2a62@kot-begemot.co.uk>
Date:   Sat, 4 Nov 2023 09:34:42 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: Missing clobber on alternative use on Linux UM 32-bit
To:     Nadav Amit <nadav.amit@gmail.com>,
        Richard Weinberger <richard@nod.at>,
        linux-um@lists.infradead.org
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>
References: <24BD0906-C6FE-499C-9A4A-00C56E6EE84A@gmail.com>
Content-Language: en-US
From:   Anton Ivanov <anton.ivanov@kot-begemot.co.uk>
In-Reply-To: <24BD0906-C6FE-499C-9A4A-00C56E6EE84A@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 04/11/2023 09:25, Nadav Amit wrote:
> I was reading (again) the x86 C macro of “alternative()” and I was a bit
> surprised it does clobber the flags (“cc”) as a precaution.
> 
>    #define alternative(oldinstr, newinstr, ft_flags) \
> 	asm_inline volatile (ALTERNATIVE(oldinstr, newinstr, ft_flags) : : : "memory")
> 
> Actually there seems to be only one instance of problematic cases - in um/32-bit:
> 
>    #define mb() alternative("lock; addl $0,0(%%esp)", "mfence", X86_FEATURE_XMM2)
>    #define rmb() alternative("lock; addl $0,0(%%esp)", "lfence", X86_FEATURE_XMM2)
>    #define wmb() alternative("lock; addl $0,0(%%esp)", "sfence", X86_FEATURE_XMM)
> 
> Presumably, if XMM or XMM2 are not supported, there would be instances where addl
> would be able to change eflags arithmetic flags without the compiler being aware
> of it.
> 
> As it only affects 32-bit Linux UM - I don’t easily have an environment to test
> the fix. An alternative (word-pun unintended) is to add “cc” as a precaution
> to the alternative macro.
> 
> 
> _______________________________________________
> linux-um mailing list
> linux-um@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-um

Application alternatives in um is presently a NOP. It always uses the 
"blunt and heavy instrument" - the most conservative option.

It is on the TODO list.

-- 
Anton R. Ivanov
https://www.kot-begemot.co.uk/