Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <11739388-1f97-4dd1-91e7-c2b0becfb75e@gmail.com>
Date:   Sat, 4 Nov 2023 18:28:39 +0530
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] reiserfs: UBSAN: array-index-out-of-bounds in
 direntry_create_vi
Content-Language: en-US
To:     reiserfs-devel@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org,
        syzbot+e5bb9eb00a5a5ed2a9a2@syzkaller.appspotmail.com
References: <20231026125616.1859-1-bragathemanick0908@gmail.com>
From:   Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
In-Reply-To: <20231026125616.1859-1-bragathemanick0908@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 26/10/23 18:26, Bragatheswaran Manickavel wrote:
> deh defined as an array of type __u16[], and issue is
> triggered when it's trying to access an element at
> index 1, which is out of bounds because the array
> has only one element at index 0.
>
> Reported-by: syzbot+e5bb9eb00a5a5ed2a9a2@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=e5bb9eb00a5a5ed2a9a2
> Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
> ---
>   fs/reiserfs/item_ops.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/reiserfs/item_ops.c b/fs/reiserfs/item_ops.c
> index 3a5a752d96c7..ccf547c5e8e1 100644
> --- a/fs/reiserfs/item_ops.c
> +++ b/fs/reiserfs/item_ops.c
> @@ -484,7 +484,7 @@ static int direntry_create_vi(struct virtual_node *vn,
>   				  vn->vn_mode);
>   		dir_u->entry_sizes[i] =
>   		    (j ? deh_location(&deh[j - 1]) : ih_item_len(vi->vi_ih)) -
> -		    deh_location(&deh[j]) + DEH_SIZE;
> +		    deh_location(&deh[j - 1]) + DEH_SIZE;
>   	}
>   
>   	size += (dir_u->entry_count * sizeof(short));

Could someone help in reviewing the changes. I see reiserfs was marked with
obsolete but still wanted to know whether this patch is correct and can be
taken (if possible)

Thanks,
Bragathe