Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
MIME-Version: 1.0
Date:   Sat, 04 Nov 2023 14:25:51 +0100
From:   m.brock@vanmierlo.com
To:     Florian Eckert <fe@dev.tdt.de>
Cc:     Eckert.Florian@googlemail.com, gregkh@linuxfoundation.org,
        jirislaby@kernel.org, pavel@ucw.cz, lee@kernel.org,
        kabel@kernel.org, u.kleine-koenig@pengutronix.de,
        linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
        linux-leds@vger.kernel.org
Subject: Re: [Patch v6 3/7] leds: ledtrig-tty: free allocated ttyname buffer
 on deactivate
In-Reply-To: <20231030100447.63477-4-fe@dev.tdt.de>
References: <20231030100447.63477-1-fe@dev.tdt.de>
 <20231030100447.63477-4-fe@dev.tdt.de>
Message-ID: <6be2d8101fb8da3455974ead01721e7e@vanmierlo.com>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Florian Eckert wrote on 2023-10-30 11:04:
> The ttyname buffer for the ledtrig_tty_data struct is allocated in the
> sysfs ttyname_store() function. This buffer must be released on trigger
> deactivation. This was missing and is thus a memory leak.

Shouldn´t there be a Fixes tag here?

And as a side note: you have patches 1..7/7 and a cover letter 0/8 ?

Maarten