Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp1211823rdf; Sat, 4 Nov 2023 10:33:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHhRyZQAbYbBgYmMR1giT9MJhkxsoJE3FzS79h04CHhu0wJAyczoDdbCTa9Ap+4ivtrPTf8 X-Received: by 2002:a05:6a00:22cb:b0:6be:5367:211d with SMTP id f11-20020a056a0022cb00b006be5367211dmr29231342pfj.24.1699119209593; Sat, 04 Nov 2023 10:33:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1699119209; cv=none; d=google.com; s=arc-20160816; b=Zrtj1mOLLVw65KrFAgJm2uU1A6I45vspb1Aka189IJZMRawQ30wfCc+jb/Z7OQ0a22 XLJX0avzxQoChOONq6ugNSpaGTjbChFoB/FXQMGgvdvVp5wCUJKG9c3J8O6Wzg7xTIhW 2JTgfdozKJ05QEPjsVlmzhg9Wzn/GDTZ2uLGCZom7X1KtT6pUCKRkJand5Z7V+zhGbR/ i72oDFw99sKdWOfMaQFSITJse2VUwJixLUYYsSeY9uRaqTIGvMZF7ux677KxlehWkcV+ GolrpQvJRpo31J0KW2KB9fVJQgHydUXAiPVVqpgHmX9rVHoRluCJfLR5KAQu7ROuFxul +pIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=26V+Afez0sCagnaLOWoCDAv+Gdie67yp6kCXAKnn2eQ=; fh=t9vNAffxaAFsqVNm/u4vfPxBbZY1p+ZimXbsRLEAisA=; b=foS9f5px/ANMl3l+89fVtUlFQFHRSgoyrWtb72g9chnCLJ0p55WjxVKRDoiqO3hp31 99GohgnaLjkk4a5CG6RscH4oLWLyBqvlNB+mKxcjxOcH5+XlMaNIa512Jvq2Oa4+4oSQ F3qhW7Ssb5BcjMcGG1d6df8R1OD/EVi1pINta9c5c/+BBrvvR3yF6JQM6GdOqBYX77dc 35cn7vbuveIN82trqW9s0J4TLuDxzjCOzeopsTWO5Mz86AJ6xOg5bLvGdz2wxuKG0cVU is+lxSXL+M7H41aiL94gio/FfhQMYvDHc36jL9zF7SuQxc1RpjH0dOkwwKOFy6fJr9K0 hzWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@weissschuh.net header.s=mail header.b=K8rYY3Uq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id eb16-20020a056a004c9000b006bd018a5bcfsi4291462pfb.340.2023.11.04.10.33.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Nov 2023 10:33:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@weissschuh.net header.s=mail header.b=K8rYY3Uq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id F31AB80968A9; Sat, 4 Nov 2023 10:33:26 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231321AbjKDRdE (ORCPT + 99 others); Sat, 4 Nov 2023 13:33:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229514AbjKDRdD (ORCPT ); Sat, 4 Nov 2023 13:33:03 -0400 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B157D1BF for ; Sat, 4 Nov 2023 10:33:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1699119178; bh=dfkf51YavrShtsViHN2it78NydaNomWdIeuQ4qET9dc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K8rYY3UqyXk+A2iW11irbG84Pbfx1Y/2CtaLyRchBWeNql5vJHtCIxkGiym+2Et6E 9Nah0b643xH5JwEFpqhhqo3zQlu0m80nW4IBveLBfT2U2R0glaqa/u1wBks3iFyK+O oTiQN75v9t04lpJ+t1ROSq0gx7KZq1M7q64/9FIo= Date: Sat, 4 Nov 2023 18:32:57 +0100 From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= To: Greg Kroah-Hartman Cc: Willy Tarreau , Arnd Bergmann , linux-kernel@vger.kernel.org, Zhangjin Wu , Yuan Tan Subject: Re: [PATCH RFC] misc/pvpanic: add support for normal shutdowns Message-ID: References: <20231104-pvpanic-shutdown-v1-1-5ee7c9b3e301@weissschuh.net> <2023110407-unselect-uptight-b96d@gregkh> <365bbe1f-5ee8-40fe-bec0-53d9e7395c18@t-8ch.de> <2023110431-pacemaker-pruning-0e4c@gregkh> <59ed7f70-2953-443e-9fa5-d46c566e4a08@t-8ch.de> <2023110418-unreached-smith-5625@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2023110418-unreached-smith-5625@gregkh> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Sat, 04 Nov 2023 10:33:27 -0700 (PDT) On 2023-11-04 18:07:21+0100, Greg Kroah-Hartman wrote: > On Sat, Nov 04, 2023 at 02:56:34PM +0100, Willy Tarreau wrote: > > On Sat, Nov 04, 2023 at 02:53:37PM +0100, Thomas Weißschuh wrote: > > > > > The real reason probably doesn't matter today as the header propably > > > > > can't be dropped from Linux anyways for compatibility reasons. > > > > > > > > > > > And if they need to be here, why not use the proper BIT() macro for it? > > > > > > > > > > This was for uniformity with the existing code. > > > > > I can send a (standalone?) patch to fix it up. > > > > > > > > If we keep it, sure, that would be nice. But let's try to drop it if > > > > possible :) > > > > > > It will break the mentioned scripts/update-linux-headers.sh from qemu. > > > > > > > > > Note: > > > > > > BIT() is part of include/vdso/bits.h which is not part of the > > > uapi. How is it supposed to work? > > > Some other uapi header also use BIT() but that seems to work by accident > > > as the users have the macro defined themselves. > > > > Be careful here, we don't want to expose this kernel macro to userland, > > it would break programs that define their own (possibly different) BIT > > macro. BIT() is used in kernel headers but we should not presume that > > it is available from userland. > > It's already there :( > > I thought we had a uapi-safe version somewhere, but I can't seem to find > it anymore, so I don't remember what it is called. It seems to be _BITUL() and _BITULL() from include/uapi/linux/const.h. But first we'd need to figure out if we he can drop the pvpanic.h uapi header. I hoped you could give a definitive answer for that. Personally I'd hate to break stuff for qemu. Thomas