Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp1310421rdf; Sat, 4 Nov 2023 15:25:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGNpJK0aQ8llLToGOrg2KwUMZLOdWVh4vBjMSd7k6F2FWXNqOh5S/m/TpHIGGxKW1e77OZU X-Received: by 2002:a05:6358:2908:b0:169:49f7:cb1c with SMTP id y8-20020a056358290800b0016949f7cb1cmr33367413rwb.8.1699136705092; Sat, 04 Nov 2023 15:25:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1699136705; cv=none; d=google.com; s=arc-20160816; b=YHIxvgIvsqKnVoq88BPfxOtpSg2ThjtwAB3s99sTfAX67340ciE2jau1iaFqCQ8Y90 GsGGLXcGfPv3qSvyz8vI25t1TmnDxX7nw47TTOEQTcKxkrnVXZ3M5KKgSldVAsQ4PrhQ bXyA/tsZ6RIv4Dv+KUHtpnB4hN8PSuK20ueeCX5SYckgmA7XiP3JUGm3EnlNl/510uTf KGsbmXpEC25FZSPf61WdQI3wzokMkClJFiF9XKpw/GCBoq1PJ5W76SvcpKc+jwixxOhd FeOlMZV+eRVqkp0N/F+LfhqZWDWdyECTupZOWRnRj2Og8iQv7s5jCZ9sf8Oxp7UUV51C 1ZcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=1xcs2HjG+fgSYQEQB0XJ0QSMbYKmU2xrcdBawACdXBo=; fh=NIkUmD20tf8Q1TwvVg7Fgl05XwBr7RSQ0CFcEyIRH4c=; b=KjHEq8ssII/Y6NdxujmsS156uaLiF9BN8+NcPdS/Nl+9/1LRe12u0B0MJR5UpwEWIo NxalCzBSf8O3ckNTJjRbGUXum3qRGhZn6yMXAaXVAieCViZHxHWTLj2tV9d/VZDdzwNT 1gyIw3A4N2GlrCs3q0Bg8ABGfiNwVMsl0JK6Qk/+n8JhcXvQmWWalM/yMtXEZW8qFk79 u/gWLC/ZwokbHtInDTrrPbv5jEXfow+/LdSozhz8dsASRRVZHgfUs1M18QmR7JAiYwkZ /EZ1F0Pk6f1JJ+4uszFmXWK2Kv2aqgkDvyI4njAQTsH5d5Xwtg35GwE8kjphheOTFRvU mhZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=F+H4peC4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id x185-20020a6386c2000000b00573f885c4easi4432560pgd.753.2023.11.04.15.25.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Nov 2023 15:25:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=F+H4peC4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 78D7C804D7E6; Sat, 4 Nov 2023 15:25:02 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229578AbjKDWYh (ORCPT + 99 others); Sat, 4 Nov 2023 18:24:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229577AbjKDWYg (ORCPT ); Sat, 4 Nov 2023 18:24:36 -0400 Received: from mail-oa1-x30.google.com (mail-oa1-x30.google.com [IPv6:2001:4860:4864:20::30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45FE0D57 for ; Sat, 4 Nov 2023 15:24:34 -0700 (PDT) Received: by mail-oa1-x30.google.com with SMTP id 586e51a60fabf-1ef9f1640a5so1900087fac.3 for ; Sat, 04 Nov 2023 15:24:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699136673; x=1699741473; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1xcs2HjG+fgSYQEQB0XJ0QSMbYKmU2xrcdBawACdXBo=; b=F+H4peC47DpqQUoE1X7qjJ33NKUKOJPgxfTIRBV51YeTsEuTdihzIze1gnV/FqSzNf XYopchOpoQXoksdQt/l33wZP6K8Mu1gxVnm9V0JISDw5o+LAFndwE5ArOpwEnF6/D6w1 iZY3+SeFe75d/5PEGGnKDEECozCtDpTqkqpmVTU8WFf38/F9k670rxU9xOtm42h3SWiN NmZV7OrnGGPZ2ru3KZ2GXgNbtQTVVqmBI8Nj2E8qrLoi4fdpC35EG0FntrhGDPCgGlEa tFCoyrwGOE186MiD736gShuyYi08xvced4XvvIsRns58ncQoStsoeWJGychDfLk4OVmS E3Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699136673; x=1699741473; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1xcs2HjG+fgSYQEQB0XJ0QSMbYKmU2xrcdBawACdXBo=; b=DuUlYEGGeDX9AgU0PbZ2AZ11cF6dYeG8/FFlf+fCX46XNV8KrelwLJOKurHzsYMOss ijcGL3dZJWhBHBzYayuu7l9d7WGxVbunGq4ir20RX29eaaD6xcg9DWk7gCauR924Kc5q 2u3MuifuZnfzTVD8O9o9I9X3JJLoisX6UO2+0YkznMHjwGwWFkpkEDQk/VcdgtO+Ye9H PNgTgNmO6PanSAAu5Lk2LD2nxzRqeCv+aQYemUXjEA9CORK5KY16SHIrBTARzaSbaJ6j fpEEtou8E/OoqEHWFGauKWytEAULUI8ie5N3T+cDFV3oh4J+gRNTwsZLjOxNgOpCXUVl v8iw== X-Gm-Message-State: AOJu0YwsmZARfPwyeIcWPNGHQnUOB33XEh4WuxLn+aWrTswT2BSow12s ms2jAfg3RzaNQQIBl+0rrQsuV7L1DdXri+mzraHuWQ== X-Received: by 2002:a05:6870:1607:b0:1e1:371:c3da with SMTP id b7-20020a056870160700b001e10371c3damr28720679oae.20.1699136673317; Sat, 04 Nov 2023 15:24:33 -0700 (PDT) MIME-Version: 1.0 References: <20231103195310.948327-1-andriy.shevchenko@linux.intel.com> <20231103195310.948327-3-andriy.shevchenko@linux.intel.com> In-Reply-To: <20231103195310.948327-3-andriy.shevchenko@linux.intel.com> From: Linus Walleij Date: Sat, 4 Nov 2023 23:24:22 +0100 Message-ID: Subject: Re: [PATCH v1 3/4] leds: trigger: gpio: Use sysfs_emit() to instead of s*printf() To: Andy Shevchenko Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Pavel Machek , Lee Jones Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Sat, 04 Nov 2023 15:25:02 -0700 (PDT) On Fri, Nov 3, 2023 at 8:53=E2=80=AFPM Andy Shevchenko wrote: > Follow the advice of the Documentation/filesystems/sysfs.rst and show() > should only use sysfs_emit() or sysfs_emit_at() when formatting the > value to be returned to user space. > > Signed-off-by: Andy Shevchenko Reviewed-by: Linus Walleij Yours, Linus Walleij