Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp1310955rdf; Sat, 4 Nov 2023 15:26:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGssdH9V9AepGxGt3noWByTK1pp40A6m1GIyyTtducCNkMbncGLwJCrBWCCMIydsmZtqfqF X-Received: by 2002:a05:6358:881f:b0:168:e479:58bc with SMTP id hv31-20020a056358881f00b00168e47958bcmr32230134rwb.16.1699136788978; Sat, 04 Nov 2023 15:26:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1699136788; cv=none; d=google.com; s=arc-20160816; b=HPpoLpoDOkvBFnt67La5QzdST/ODqnNZIZgbSfIr0lBM/arxH5QsXvU8EBiooNQjbF kHX1YOJ8pmjKbMTBmZoxlliebk8QL10ie7wgAW0u7FLSLWXBH/vFKxlWr/oJywNH5TfL he7z/jm1trQuqmOtajq6FEJLllakpi74Xd/QJhCIKiEwAw8O/bZxCxuQvF8kcUSP5gK2 HYzFKS79sauL43coy0luyHZuRo92Vp3tCbVfW3pKyo8sCmA2sCEJoP1mmqoxI4w5WTK5 CdUM4fGmGsK9dAbCp442H048xOerBBfvH9PmbkT1Z3M0dG4c0SrHML6LnnQXZJyh/ad/ naJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=oFddYtCCcf1uWTg2daUt4KqHC4rRdcekNan46WctVmQ=; fh=NIkUmD20tf8Q1TwvVg7Fgl05XwBr7RSQ0CFcEyIRH4c=; b=qY7F766dD9oaKAbYCYOVpjVIu/jStGKagl75eFnLkFLDKiWGRTORT2U5eJtlKVscn8 TKWZTJbtjLf5me8/eFB4RU48tN6KVw8zxF3UD2heUTIAvdFQ6FwOEHpuU3LX7zKChIbV 3IeWzlZF9pF1u266PxXWcEMcNMvdLMVOOIA3N+GPU84YMHNWOACh1OZP2AauugulIYQx EwBRNuZHJHYq3+c6/2kwBUVGVQ66KwN4r9iszWf5KVJr0m9bB9M/I+BFyOxFWTBunEwE CRWx/pxZWRZMyIfnwwAt99aBN9BbNoAU0r1Aw6w+maUYqGs2//xvR0//cfYkq7De2CjZ e14g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SmhJfnYD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id pg1-20020a17090b1e0100b00268178130a2si4903314pjb.60.2023.11.04.15.26.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Nov 2023 15:26:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SmhJfnYD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id A5A0B8054EE5; Sat, 4 Nov 2023 15:26:26 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229578AbjKDW0W (ORCPT + 99 others); Sat, 4 Nov 2023 18:26:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229577AbjKDW0U (ORCPT ); Sat, 4 Nov 2023 18:26:20 -0400 Received: from mail-yw1-x1136.google.com (mail-yw1-x1136.google.com [IPv6:2607:f8b0:4864:20::1136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F417D6B for ; Sat, 4 Nov 2023 15:26:18 -0700 (PDT) Received: by mail-yw1-x1136.google.com with SMTP id 00721157ae682-5afbdbf3a19so37792917b3.2 for ; Sat, 04 Nov 2023 15:26:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699136777; x=1699741577; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=oFddYtCCcf1uWTg2daUt4KqHC4rRdcekNan46WctVmQ=; b=SmhJfnYD30EwCmksN2U55VxhwW/y1rY0EsJ9UgphxlkK9FvNbn8qIaM0Z75TCb5HxS U/2ns0BUKTO7A4UQ1zWbt29faUKaifyEQPP6xtLok4owMfV6nlf/s7RGINDD8FaSUxNJ aQm/RPCce9GvjKjHtTMuocHOuKsuzkZqVZkucc7xNb0XN4COKTuCpBCDO5MJV4Txhhh5 mUXlhy2XXmGKSfjidz2nYJRefClhl7TF/wGVqxEtmmCI5UBtq5RnhDwcy/nC77nK92Qp 3Qv04nn6FpikbELYmycnbWBzABK5cpvggVqEeHuBNUTuTbBPsCUSFs3978tT/pYrlrb3 P/pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699136777; x=1699741577; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oFddYtCCcf1uWTg2daUt4KqHC4rRdcekNan46WctVmQ=; b=RsvejUbRr1eVTR2EgIEfyWaSnz8FLVaxECwrATx/gTi4YDS75uvnEMs14CAJrd3obG PzIcZFjO2qb5IPfTKi1to869+CLJiYj14sMk9wE9H+Oqc0g8l1wgk1mXW4d45ypr6d3q 0jWTMJ/70XP//oJy2SeVkdY0XitgzOW2+wcIWJFw27NEu0lHs//po82tnCkdPAhJjYQ5 kaS2ruamgaEhp2CYmFjF8/gGgFEZ6cbT13Ld+oUnG/9qca75MXUOBpddne6oL+AqrW/+ ybrecnpOVr2mi8ZSvJ/e0WPI2NYmqmI6rYG3B7grloEHQcHVLD2mnuIhWf26ef+Da3FW m/lg== X-Gm-Message-State: AOJu0YyVPeJdRZ2FLkmG+6AIuWveSowQ/JcCEP21j0w4tQBzawuBX7Ot VsENwnF/3cAz18BmCMTX6bZW+jBA1UnR+k2wJKf+xg== X-Received: by 2002:a81:7984:0:b0:59b:ce0b:7829 with SMTP id u126-20020a817984000000b0059bce0b7829mr6348697ywc.35.1699136777680; Sat, 04 Nov 2023 15:26:17 -0700 (PDT) MIME-Version: 1.0 References: <20231103195310.948327-1-andriy.shevchenko@linux.intel.com> In-Reply-To: <20231103195310.948327-1-andriy.shevchenko@linux.intel.com> From: Linus Walleij Date: Sat, 4 Nov 2023 23:26:06 +0100 Message-ID: Subject: Re: [PATCH v1 1/4] leds: trigger: gpio: Replace custom code for gpiod_get_optional() To: Andy Shevchenko Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Pavel Machek , Lee Jones Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sat, 04 Nov 2023 15:26:26 -0700 (PDT) On Fri, Nov 3, 2023 at 8:53=E2=80=AFPM Andy Shevchenko wrote: > gpiod_get_optional() and currently used fwnode_gpiod_get_index() > are both wrappers against the same engine internally. Since we > have a pointer to struct device there is no reason to use fwnode > type of GPIO call. So, replace the current fwnode call by respective > gpiod ones. > > Signed-off-by: Andy Shevchenko I don't know what I was thinking here. Probably I was thinking that the nodes doesn't always have a device, but hey, it does... Reviewed-by: Linus Walleij Yours, Linus Walleij