Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <06ed13ca-9f52-4b49-9178-aae245bfd958@siemens.com>
Date:   Sun, 5 Nov 2023 10:51:42 +0100
User-Agent: Mozilla Thunderbird
From:   Jan Kiszka <jan.kiszka@siemens.com>
Subject: [PATCH net v2] net: ti: icssg-prueth: Fix error cleanup on failing
 pruss_request_mem_region
Content-Language: en-US
To:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        MD Danish Anwar <danishanwar@ti.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        "Lopes Ivo, Diogo Miguel (T CED IFD-PT)" <diogo.ivo@siemens.com>,
        Nishanth Menon <nm@ti.com>,
        "Su, Bao Cheng (RC-CN DF FA R&D)" <baocheng.su@siemens.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eTI3Y2dSVmVZWlBQZ0VHZURrbTFpQU1mSml1ZmNCSzZlaTh2V2JlYXJRb0dG?=
 =?utf-8?B?QXFiTGwxMGoxQXA3bzhTa2lZZnJzTGIyc2RVNWtWbnV5VElBdDkzcWN0dzVn?=
 =?utf-8?B?Z29TMytoL01qZFVlcDRhVnU4NG5JZklqL1dhdlpOOVVpU2svZUNuZ2x6QmpC?=
 =?utf-8?B?TGNFYkFqNk9wV1RUNUNoQ2tQUzZacVp0aTBPZy9iWTR6aWtIbnNEanIyL29y?=
 =?utf-8?B?YUFTSlNKMUlpQkx2cjE0UEJZQzNnWGZLV1lUMWpBNzRMc0RBUmxVczJhc1lJ?=
 =?utf-8?B?TFZyYjY0RlZkNjdnUS9aakFyd3l2WTlLZWVMR0hBNUp3aitnNkpUWUlhcElW?=
 =?utf-8?B?cWp5T2ZIQkFkWit5eVpOVXBFU21SMk43bzJlUmpuVEFmR3EwN3BpU1dDampY?=
 =?utf-8?B?N3F6WW1TWDhKRkVrT1NGWFphN1ZUa3hjQUNRd1ZQVk1WT1lEdG1BRDR0dXMy?=
 =?utf-8?B?TFdqS29abnc3VU55cGd5VmNMMHU1ZEJCZ2JCVDFvNXR1UkpRTmhlQ3dtYVNy?=
 =?utf-8?B?YW1nd1czdzhYdmthNmVsUkZWaXcvQ3ZkaExDeWtQaGdqU2NFNEd0KzdHNW5M?=
 =?utf-8?B?QVBOMEtFMTJzalh0TXpVSzhTVjhhWlQvSzlmdlhJOEs5OHVzZlF1TlhtYTNR?=
 =?utf-8?B?UWVIMktzelZYZ3pNWk1KdXFweE1LQWFBODZiT0paNjcwQnlDN3hra2dFTFBF?=
 =?utf-8?B?OHhVSHE5RXpuQW1abnc0ZDAzK3U3NXZFVklxTWYveDhXdDJSVE1oYUVKMGFB?=
 =?utf-8?B?bFlZcjA3SHAxMnMrRVlVM1V6enhFVmtvc2FvNFdES2Frc01RSlFnR1M2NjhR?=
 =?utf-8?B?OUlmTGgyYjRvbERTRmlLUUx4OHBaa3pQOWlmVVN5ZDRqbmZzYkFocFpNeTRZ?=
 =?utf-8?B?SVdNSitBMnVjNEVJaDZHK3R1bnlVLytobGU3NXRmQ1NqZ3ViUmRoZkNFMVRX?=
 =?utf-8?B?bHF2ZDhqd1hnQ084SFZ3TVpxdWtZQ2VTODkxeUJUV0Yzc2cyNmRXbVptUXJ3?=
 =?utf-8?B?WnRCVjRtaFhZeUIvM3huejhubFJWclo0cFZtV3JaMzVaQ3NmR0lGQlBQQnhV?=
 =?utf-8?B?Qmg2a2syaXQxUVZSRENvNjlCcFIrOEMzUHhpUW1ydFZiUkRFaXk0QkRZV2da?=
 =?utf-8?B?QnJ6dUI4WmFVeUN4WkNyM0lKU2FmWE1CN0tSeDlwSm00SlhWTHZDMmdoWkZG?=
 =?utf-8?B?L0tadjZSeWlOQktabzZ5RXdYYlRBWkFEOFZPbU9rWk5HMHhxb24wTzRYS1VF?=
 =?utf-8?B?NTVWNW43SkNtS2hYK0IvNUlwOEdWT3pML3Z3cFVqYm95bGNOL2JPclNVQlIx?=
 =?utf-8?B?TFpXRDFJaC9vcWtHYTNWaEl0RDZQRUU4cUJuRWFBdkVXZEJQa0ZSZDlVNGpC?=
 =?utf-8?B?RWJHcHZ1d202U3RWZjhmRTdobFlXc3RBWDVXNWM2c1ZFV2Yxc2NWYk5lOVls?=
 =?utf-8?B?T2JsamxnQ1hwTHBMYXcyZ3I3QjRmajRQSUwzSnVCTC9KZjJFcGM0OW44RXR4?=
 =?utf-8?B?SkxwMlFEem9zUGhXWS9rM0xtYjVab2crcW4wb1NUR0tqQzRsMVFpTHY2UzBs?=
 =?utf-8?B?WDROVUZRUnpnQlBtSFpwWVo2WUhETGNHWXVYVy8xeHgrNVdXN1E2SWF1Wkx1?=
 =?utf-8?B?ZGx4M0daOGdkemU5cG9yNVdJalhaQmxlUGxZN3V5YTgzcXo4WGlBUFRqbjlq?=
 =?utf-8?B?ekJjNzdJUy9pR0hEUHRBdnpTUkZQQW9zZDdENlowSG8wKzJVZzFTMTZCWGV3?=
 =?utf-8?B?SWdCWW84Zm5zVFljREJLUjFyZTMzeGlRV3hlTW1aaTBUZDNBSG5rdkdudDYx?=
 =?utf-8?B?UnIwRDRLd28rYmU2ZjBNNk5uVUYzQUtUNzZab3FFRSs3UGZEOU5QUWhtOHFL?=
 =?utf-8?B?eE5qeG5aQVF4WFNWd0crem5wbjBOOUExK05yZU5hUGpTOHF2NEpuRkh3Q1Fu?=
 =?utf-8?B?K0FuUW1TcG0vNkFUbTMyU3VOWjJaN2pEZC9mTFJzSENpSkg4dWRBYUNCV3NY?=
 =?utf-8?B?ZytyVzRmS0lWdkNXYUpKT0hDdUhCeDlzZVE1VDBtSXl0WGFSanN5ZnZmVU1L?=
 =?utf-8?B?aXk0SHp0KzJveW1UdmJneWNsUllBb3lvdWxMUDRySlQxQkIxOXlQWmtPdDZv?=
 =?utf-8?Q?g2jt0/dd0KiInuRGa7J1yBRzE?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c7fcf9c-0d94-458a-460f-08dbdde4d0f0
X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2023 09:51:43.1869
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zB5cPa2hk/+RH3bCEd3HslDIFKmL/NTJg0UPZrZRTaqiSqhGaf8PjIRRqBMOIOaRNhJiv+J3BofeaIIoOVdPsw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR10MB6309
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,
	URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Sun, 05 Nov 2023 01:52:09 -0800 (PST)

From: Jan Kiszka <jan.kiszka@siemens.com>

We were just continuing in this case, surely not desired.

Fixes: 128d5874c082 ("net: ti: icssg-prueth: Add ICSSG ethernet driver")
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---

Changes in v2:
 - add proper tags

 drivers/net/ethernet/ti/icssg/icssg_prueth.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.c b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
index d119b2bb8158..845e8a782d3a 100644
--- a/drivers/net/ethernet/ti/icssg/icssg_prueth.c
+++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
@@ -2063,7 +2063,7 @@ static int prueth_probe(struct platform_device *pdev)
 				       &prueth->shram);
 	if (ret) {
 		dev_err(dev, "unable to get PRUSS SHRD RAM2: %d\n", ret);
-		pruss_put(prueth->pruss);
+		goto put_pruss;
 	}
 
 	prueth->sram_pool = of_gen_pool_get(np, "sram", 0);
@@ -2215,6 +2215,8 @@ static int prueth_probe(struct platform_device *pdev)
 
 put_mem:
 	pruss_release_mem_region(prueth->pruss, &prueth->shram);
+
+put_pruss:
 	pruss_put(prueth->pruss);
 
 put_cores:
-- 
2.35.3