Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp1510974rdf; Sun, 5 Nov 2023 02:35:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IEu3vpR/Mz0xejRc/xQFsg1EnY1ErARg79N236YoXnZ4ZIiM9X24alophD5WxplgCmG7AMp X-Received: by 2002:a05:6808:689:b0:3b2:ee75:31f with SMTP id k9-20020a056808068900b003b2ee75031fmr28641148oig.49.1699180558671; Sun, 05 Nov 2023 02:35:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699180558; cv=none; d=google.com; s=arc-20160816; b=mMuANiEGSy9XzdRMRRULz68hSCKx2M1kqA0LJsOOvjYklyGPHNKgOAcPvprrSWiLN8 2MtjYaEcE8dcQ08gHuyAmmfZjbTfdm4CeiCKghJtSa0/ztb68NyyoX76d9YymY3fqwxv n751vustj0FHjUkpzsPL/wCUvpuiBqGnX/0ATpdhe+0N5Y0PAOzl+sSZ5mRTBe36aq5j qMjDmHZiyMkZnSOC+mCwmsX6ZJJn2i9EbHv+avTwIwkw/gMPcdcNBnewZfx078VxnGTm 6i1v4CrJRo5s9DVMl1PzDWf3XfpTzNV2lJdLp8qL19GHzQ1MKcD8W5Tj1xk+h7P8Uqpe +Ybg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=nDjMxVjZcvux8sUrDNYyN3PBu1obWU3od9qLSN7InjI=; fh=fVLdaaEf8SRAl+vTtTeUb2psDcIX9nery5aD1AwNoP8=; b=LLIFWO0Z8Ye1JaG6hjOOwuDwkfj0qejD2IBfDL8Zb5rhwD/CGL9F0szMsfzHSwI8H3 O4zAYTUHSXKz3DUf0W4PjQXIh1ZVifGVKKjgvmeK6UQ5rAiY6DfVgFMVez59ARPniZv0 D/5TPjNF2Hq3QZnF+wM6dCzuFCiStPSH9y/UPo3do8E0obLj0hep+gI8PfLt24gZfzYX /C9b2Gd3EtDj4ZH+vso8QArLPeDY1OxzT+Yclb6br8GTRUsWRKDFi0fO+rm/0n1Kq0Dk oPfaaL6P2y1lHkDKdIE71OUh6zRcs0Gt7btsZCUNS+Cg+Lt5moYimJ8XpDITZHzZAKeX lzeQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id k13-20020a056a00134d00b0068e2b901138si5783365pfu.158.2023.11.05.02.35.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Nov 2023 02:35:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 959C1804C215; Sun, 5 Nov 2023 02:35:57 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229638AbjKEKf5 (ORCPT + 99 others); Sun, 5 Nov 2023 05:35:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229447AbjKEKf4 (ORCPT ); Sun, 5 Nov 2023 05:35:56 -0500 Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id EA507F2; Sun, 5 Nov 2023 02:35:52 -0800 (PST) Received: (from willy@localhost) by mail.home.local (8.17.1/8.17.1/Submit) id 3A5AZe6w002725; Sun, 5 Nov 2023 11:35:40 +0100 Date: Sun, 5 Nov 2023 11:35:40 +0100 From: Willy Tarreau To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Shuah Khan , Zhangjin Wu , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 5/6] selftests/nolibc: extraconfig support Message-ID: References: <20231105-nolibc-mips-be-v1-0-6c2ad3e50a1f@weissschuh.net> <20231105-nolibc-mips-be-v1-5-6c2ad3e50a1f@weissschuh.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231105-nolibc-mips-be-v1-5-6c2ad3e50a1f@weissschuh.net> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sun, 05 Nov 2023 02:35:57 -0800 (PST) On Sun, Nov 05, 2023 at 11:09:59AM +0100, Thomas Wei?schuh wrote: > Allow some postprocessing of defconfig files. > > Suggested-by: Zhangjin Wu > Signed-off-by: Thomas Wei?schuh > --- > tools/testing/selftests/nolibc/Makefile | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/tools/testing/selftests/nolibc/Makefile b/tools/testing/selftests/nolibc/Makefile > index f8fea9fa0263..02c074e73a28 100644 > --- a/tools/testing/selftests/nolibc/Makefile > +++ b/tools/testing/selftests/nolibc/Makefile > @@ -81,6 +81,8 @@ DEFCONFIG_s390 = defconfig > DEFCONFIG_loongarch = defconfig > DEFCONFIG = $(DEFCONFIG_$(XARCH)) > > +EXTRACONFIG = $(EXTRACONFIG_$(XARCH)) > + > # optional tests to run (default = all) > TEST = > > @@ -227,6 +229,10 @@ initramfs: nolibc-test > > defconfig: > $(Q)$(MAKE) -C $(srctree) ARCH=$(ARCH) CC=$(CC) CROSS_COMPILE=$(CROSS_COMPILE) mrproper $(DEFCONFIG) prepare > + $(Q)if [ -n "$(EXTRACONFIG)" ]; then \ > + $(srctree)/scripts/config --file $(objtree)/.config $(EXTRACONFIG); \ > + $(MAKE) -C $(srctree) ARCH=$(ARCH) CC=$(CC) CROSS_COMPILE=$(CROSS_COMPILE) oldconfig < /dev/null; \ You should instead use "olddefconfig" for this. It reuses defconfig but uses defaults for new questions. I've already experienced issues from time to time using /dev/null with oldconfig as you did above, with a process looping forever (probably on a non acceptable choice I guess), and never met such issues anymore since I switched to olddefconfig instead. Willy