Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp1602230rdf; Sun, 5 Nov 2023 06:27:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IHDRDr4UsS2Zak0PRQljl/57Gbf/FXJXOhjW5fQ2ngKJUHN6nqBdAKJH5UkaLJF6iTFJXFy X-Received: by 2002:a05:6e02:d09:b0:359:445:845e with SMTP id g9-20020a056e020d0900b003590445845emr21360042ilj.18.1699194443134; Sun, 05 Nov 2023 06:27:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699194443; cv=none; d=google.com; s=arc-20160816; b=dC/2vTALhTMyl+M5HFzlmAeECsCvTO1CKNPOufis3Hpzcr83nmv8dL5E3oJkHqEDxr CxTaw2ICuer0fQkO85cUov/BIIDUTJoq0I+cw+8s5rxVPdBBO7kLpVCZplarQVUP/Yjo M5nA6oleO0UpRzUw7QIpdigzaUF8wAU2uHbZ0zq+Nd2Eh3VGNiPkuVll8r55bHAoNHfM 8fpnBYuXDcASAf0QcD3ypWVK+RwNOO4Z17ucyU67/GTVScjfOcdWXOgRxIBV4a7a+r+2 sTVS7r795JJbNQ2beoZZLykcQ/vPhBSd10YUqNXZKh/LyuCPMNYcSCtCoaVC/mbRAB4N s/eQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=nmQjc9r7DnReAAl33Om9Hww0MSzfkH3u/iRmFRCleO0=; fh=/BVtLbFl6Hwn8bf6AJviCWsBIkb+hTsz3ejK2psM9CI=; b=k2ml0jSNvHUWeiaxzHASD93KB/LMmdjoEVzBS7c9vRrkDsA+Zoj7LNg5q+QzZRdBB9 PSpn2ouF2h8TzkNSMK5HDOuZ9inTH0F1ro+zpwZZlROyY+ytWmYIbxP6/eX9oF53ZPzw PIjJWPGOKs/htzTmgwrIdnUO0TpqAW/4XdeC3VTSGF2+mNn8fjKzhtM3Ss8AzgPzfEIP KSsXjem1UG9p69vn6JAGbd/tCU3eSpO5Kyag1H4LRIDTbrfCZ6D/Z/q4woV84GlsXxFp sVHJJ/BxgsezX5hdMZ+w+jL/TJKkS9zcXbxC74a5jnZNrC+rIEypE5MsKRQc0ETd6rD5 agqw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id cn8-20020a056a020a8800b005b9b68add80si6416618pgb.361.2023.11.05.06.27.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Nov 2023 06:27:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id B7D878061B62; Sun, 5 Nov 2023 06:27:21 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229608AbjKEO1V (ORCPT + 99 others); Sun, 5 Nov 2023 09:27:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbjKEO1V (ORCPT ); Sun, 5 Nov 2023 09:27:21 -0500 Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C523CC0; Sun, 5 Nov 2023 06:27:16 -0800 (PST) Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 3A5ER0F8021222; Sun, 5 Nov 2023 15:27:00 +0100 Date: Sun, 5 Nov 2023 15:27:00 +0100 From: Willy Tarreau To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/nolibc: fix testcase status alignment Message-ID: <20231105142659.GA21217@1wt.eu> References: <20231105-nolibc-align-v1-1-5bfc542cb6ee@weissschuh.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231105-nolibc-align-v1-1-5bfc542cb6ee@weissschuh.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sun, 05 Nov 2023 06:27:21 -0800 (PST) On Sun, Nov 05, 2023 at 03:22:30PM +0100, Thomas Wei?schuh wrote: > Center-align all possible status reports. > Before OK and FAIL were center-aligned in relation to each other but > SKIPPED and FAILED would be left-aligned. > > Before: > > 7 environ_addr = <0x7fffef3e7c50> [OK] > 8 environ_envp = <0x7fffef3e7c58> [FAIL] > 9 environ_auxv [SKIPPED] > 10 environ_total [SKIPPED] > 11 environ_HOME = <0x7fffef3e99bd> [OK] > 12 auxv_addr [SKIPPED] > 13 auxv_AT_UID = 1000 [OK] > > After: > > 7 environ_addr = <0x7ffff13b00a0> [OK] > 8 environ_envp = <0x7ffff13b00a8> [FAIL] > 9 environ_auxv [SKIPPED] > 10 environ_total [SKIPPED] > 11 environ_HOME = <0x7ffff13b19bd> [OK] > 12 auxv_addr [SKIPPED] > 13 auxv_AT_UID = 1000 [OK] > > Signed-off-by: Thomas Wei?schuh Quite frankly for trivial cleanups like this you should not even bother with sending a review, and could queue them directly! Thanks, Willy