Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Sender: james@equiv.tech
Date:   Sun, 5 Nov 2023 10:51:00 -0800
From:   James Seo <james@equiv.tech>
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     Jean Delvare <jdelvare@suse.com>,
        Lukasz Stelmach <l.stelmach@samsung.com>,
        Armin Wolf <W_Armin@gmx.de>, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC] hwmon: (hp-wmi-sensors) Fix failure to load on EliteDesk
 800 G6
Message-ID: <ZUfkFHmrlnL7gbfG@equiv.tech>
References: <20231103181931.677796-1-james@equiv.tech>
 <dec086cc-7403-4a06-b860-aae6daf8f0e7@roeck-us.net>
 <ZUZsPO9aN+E3qAng@equiv.tech>
 <2b48b41d-7d82-470a-a40e-c8f3c9de94dd@roeck-us.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <2b48b41d-7d82-470a-a40e-c8f3c9de94dd@roeck-us.net>
Precedence: bulk

On Sat, Nov 04, 2023 at 09:29:43AM -0700, Guenter Roeck wrote:
> On 11/4/23 09:07, James Seo wrote:
>> 
>> #define HP_WMI_WSTR_INFO(name, wids) {					\
>> 	.matches = {							\
>> 		DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),	\
>> 		DMI_EXACT_MATCH(DMI_BOARD_NAME, (name)),		\
>> 	},								\
>> 	.driver_data = (void *)(wids),					\
>> }
>> 
> 
> Quite frankly, I dislike multi-line macros because they make it (more)
> difficult to understand the code. If that is where you want to go,
> I'd rather keep the current code (or wait until someone else maintains
> the hwmon subsystem).

OK, I'll remove that macro if I end up using a DMI table for this. 

>> Out of curiosity, how would you feel about just adding full raw WMI string
>> support now? It wouldn't take much more work and for various small reasons
>> it's starting to look like a better idea to me.
>> 
> 
> I don't know; I would have to see the code.

I'll submit something in a bit.