Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp1727465rdf; Sun, 5 Nov 2023 11:33:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IELyhCk1WZj0JE2EOEBPOO6h7SKpD1d9PM4SS6y5/l29DJJHhxOTBvVJS2iYcCLG00KEi5n X-Received: by 2002:a05:6e02:b49:b0:350:e9c6:e765 with SMTP id f9-20020a056e020b4900b00350e9c6e765mr33680968ilu.11.1699212802225; Sun, 05 Nov 2023 11:33:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699212802; cv=none; d=google.com; s=arc-20160816; b=ySyR7g8tI/HBXKAUR9Kbf0cU+F85LJTsisA5DIocDj3Ne1FiqsQ99PnwJXKkqBeM+Z nRStPgRyicKrEJYM/ec5QZCH6propaZBnFWdIqQ/W5tT4VLuXfearT5KhvM3TyMfS99E f4S0AaMjuNOFEYZY86YB1YpKLI5rlnUY879B/dCk54ECPhYk6le3xkuH7Z5vACm9+a9S f/Gm5nKx/Ma8x1TxXPS8V3ZsEpT7Bg1pTIsNmiE65xi9+DK7j6IYPC2pZWGEO7NlLgCi C9e4mIPeWIUhyA5H7nEbIafTovx8UQWNSatk/5QzNzsz00GmJtawEeQFNAmNKC18ROJl eXbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Mhf2vnKQsfjPLmbVZzCtYYFeEBGrlXDIX+5XuzOWdU4=; fh=L+v9MCQQxYfwS+LokCy0bfU0HvJSWgeVXX7lRMxIAfw=; b=GqtgiDHbTVm2myCiulftoEg0laeV06RLylO8ylzBsX46rb3ec5cOCiOroUt4pTMBbz 65F+H1UmUTgX7bNysZdjdnNm42lsKGKhLb/5PxTfa5OT+JmNxemOmZmOQtfL3PDJbsNi MbPnJgE6ean6skPLOukDIXKkuE1NnIZC7MGug2BWgNG2P84TcalS86MV4BV/F5vSdasr 18OK05W8LRI6CpLtxFyyR3C4wembh3SBpkbkyVaBFB8yg2adlG3i9r3gOs1rUYxZq0Ij bzgtxyM5eHHDoMeOpK9ta17WEu0ERgWexsTxmR40YHW+Rlr3E5B2lKj8Rq8gfFgfLaNj zVvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MDJkErVA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id u185-20020a6385c2000000b005b8ef498e2fsi6173512pgd.181.2023.11.05.11.33.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Nov 2023 11:33:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MDJkErVA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id AD28680620BD; Sun, 5 Nov 2023 11:33:19 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229594AbjKETdL (ORCPT + 99 others); Sun, 5 Nov 2023 14:33:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229647AbjKETdI (ORCPT ); Sun, 5 Nov 2023 14:33:08 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 916EAE1; Sun, 5 Nov 2023 11:33:05 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C46F5C433C8; Sun, 5 Nov 2023 19:33:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699212785; bh=1ZSn8fX1O+pE4SPZosecaz3eXsXrtCg5RT9YyalLzBo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MDJkErVAgzE5crGSHh9WVGqTANQW6FYwKB+ggVryU3HKPwW3R6wjoQR5CbA4YD9w2 LcJ0Wtwe6qzm6WV2AL8nlOSTNJxfH4Mh3tSVYkhFvn5BM9fvxILPt930TbZS664iwl go2apfOhcyRzx13OulPkXhb4XADFnWT0i48k33wUnfy4a6MMQrc/iTdRTU5rwzbf+M lQId99jXFLhOeJrsgM0D2LoVIJnbHXuppXlxEq3+j17Nzxmiu904HLzLHrLlyjYoOj Y+21BauTD0lf+QjXFD2mIqLdEKNlHOccETUWyRCDMB20gdEZz+/ON/i4SZy9udTirw bfVm9Hmqz8oFA== Date: Sun, 5 Nov 2023 11:33:03 -0800 From: Eric Biggers To: ronnie sahlberg Cc: Steve French , John Sanpe , stfrench@microsoft.com, linkinjeon@kernel.org, pc@manguebit.com, sprasad@microsoft.com, linux-cifs@vger.kernel.org, llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, samba-technical , Jeremy Allison Subject: Re: [PATCH] fs/smb: using crypto lib instead cifs_arc4 Message-ID: <20231105193303.GA91123@sol.localdomain> References: <20231022183917.1013135-1-sanpeqf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Sun, 05 Nov 2023 11:33:19 -0800 (PST) On Mon, Oct 23, 2023 at 05:42:11AM +1000, ronnie sahlberg wrote: > You are right. The reason that arc4 and friend were moved into cifs > was because the crypto guys told us "we will delete these algorithms > from the crypto library" This was suggested for md4 but not for arc4. arc4 still has multiple users in the kernel, so having it as a library makes sense. - Eric