Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp1867432rdf; Sun, 5 Nov 2023 18:28:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IGW2hUEledVgUHF3uQCjKk11vI3mjslCbGUJQITvv6h21YQsm0t2kFrPvM/5nZHz29241Jh X-Received: by 2002:a25:ae8c:0:b0:da0:d029:ca00 with SMTP id b12-20020a25ae8c000000b00da0d029ca00mr26844921ybj.36.1699237703163; Sun, 05 Nov 2023 18:28:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699237703; cv=none; d=google.com; s=arc-20160816; b=lDQ2x72P7Bn4ht7GGD1rpLLBm4zMuf+tcGw9wh9SK1ry5DFIZ12qnIjgIXbkYHT++W wdOlHJH61wP6ZccSSLSmpgEv0N3b8y7jktHKVzK70etH5pnf6ku9HCO+E/GR+S1jMXco x1rF2+5O1HerZVrEvrtMVNE4dAc5+6Z0ou3L2FZSSMzP41pClKb17PdME/EUiC1RrKYI gOPbpFTTGb9V71Nq37lkkt/vMkk5FaXAYGLvk9Ve3Zzgn74RYAVMRGEaWfrGjY3kY9LU ZiHlWmbDBPPUu/242RSCwPk4nXbgCe8z+MM+fYwAwP2mKJc4a//sp6duMRpUjJnKNRHC 074A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:mail-followup-to:message-id:subject:to:from:date :dkim-signature; bh=8ICXDgrUHS6vF/SNPSijdTNrJfbN2u8WpcsExfAzl5Y=; fh=/JlThicHftPdJuBkR1sKOpWfcQm6LEFkZVgEEXzhO2I=; b=BJM3IneLkMDkjfqogmIJLCXnBclGwF0wDV+dne1yqxkmoEvkEA5BnmkIOsmdc0/6tW 4goOLC/zGy6V1Hoe+4cgfnqXkNuLqujWODIgpJuChWpUC6gKq2F9Hp0dIOsIyazLOeKy hA3dZm+vWN/i9uleQ21YAlAaJ4bdu11nEK9+/kkiqZMRHOH18PZVvht7LCIDHgB0JLbH bHl9vlOFYwj2ANH6x4DMJCJtTkol9Th/tXXQP7mqMAqPro/+Fe71Mu8YS3EfyfhmV8JU Rxr7931UNAAmiIzHfTX4cZkBDiGk4hQyzFv1xi8UdRkz4fItk2lvDhRXVMA5D5HMlDgr mYpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=e1o5xTU2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id b38-20020a630c26000000b005b8f60baea9si6959413pgl.801.2023.11.05.18.28.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Nov 2023 18:28:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=e1o5xTU2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id DCE2780AA244; Sun, 5 Nov 2023 18:28:20 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230109AbjKFC2N (ORCPT + 99 others); Sun, 5 Nov 2023 21:28:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229717AbjKFC2M (ORCPT ); Sun, 5 Nov 2023 21:28:12 -0500 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97838FF for ; Sun, 5 Nov 2023 18:28:08 -0800 (PST) Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1ca85ff26afso7747515ad.1 for ; Sun, 05 Nov 2023 18:28:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699237688; x=1699842488; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=8ICXDgrUHS6vF/SNPSijdTNrJfbN2u8WpcsExfAzl5Y=; b=e1o5xTU2yVE18YW1DnaNuNCjKDFO5m3ZS5/vS9lcdpUjkj8FMblQEF6s+J9/7kq9q0 SBd08vzClQdFYQjWsOxTmwiNWMXZCOMSJr+YvTmvgoPGbb//J/h5+QnQj/4qki2UDX+x j/FQM8AERkjkTlYmFA1JG96ixAC/YEQN9/RT3j7VRgb+k9+xKYQm/E1WfJ05BYzAyAhr 2d6saErNaSxfx0lPKfE4LrRn6tIIkckuMvysYpfNhQskUBRDSwYnllT1DSz4KoynpZCo U88xr1xzzZLjRDBGGtRHnakcMrd+INeyJuG1PQi+dXS8yfeIyjcHU11jJ+39hDc+LA1Y Hauw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699237688; x=1699842488; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=8ICXDgrUHS6vF/SNPSijdTNrJfbN2u8WpcsExfAzl5Y=; b=ZJsohXhWYTppzmr7rD/t4/aMo3+qzKphdq1PTVgfXYk0oHlPOy88y6Gl+Jy4FqwShp qtI5DYs2dmPu8Cmook2g69/mzs0bF6OOi9IHK/o+Dtv3fqXa0JNmZ6loAUhloCrNC2Ft TSg78KOJeykRU9wjNgI3njs7CnoWd5EgXn+/y+936gJNhe1XbooS2z48zZmnX07TJEYd hqjv/wto1yRZ/H0dgJJhgl7FVQ18NBdG45peAcPCCUtn1XeiE22q4PI7aWGTkgNHfRCf A8sd+jeBiImgidw2S/Wb2gWtkpA2ynS6Ikn9AJcNREzBLe2BbPXY7gaa6iyQIiwArnwU waxw== X-Gm-Message-State: AOJu0YxBZEwJae7ZPTR0Ov54VJ4J7bKCDaL3dYWpx3+U+HUXlD7criCi SY0//aRWQNMvfoZtsBZ/TAQ1Sw== X-Received: by 2002:a17:902:c649:b0:1cc:3202:dcca with SMTP id s9-20020a170902c64900b001cc3202dccamr23138767pls.2.1699237687807; Sun, 05 Nov 2023 18:28:07 -0800 (PST) Received: from octopus ([2400:4050:c3e1:100:44eb:593c:2134:f5ea]) by smtp.gmail.com with ESMTPSA id jc15-20020a17090325cf00b001cc0d1af177sm4735588plb.229.2023.11.05.18.28.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Nov 2023 18:28:07 -0800 (PST) Date: Mon, 6 Nov 2023 11:28:03 +0900 From: AKASHI Takahiro To: Cristian Marussi , Oleksii Moisieiev , "sudeep.holla@arm.com" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" Subject: Re: [RFC v5 3/5] firmware: arm_scmi: Add SCMI v3.2 pincontrol protocol basic support Message-ID: Mail-Followup-To: AKASHI Takahiro , Cristian Marussi , Oleksii Moisieiev , "sudeep.holla@arm.com" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" References: <7300b8804396075d2ae565f46de51a980ce846e6.1698353854.git.oleksii_moisieiev@epam.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Sun, 05 Nov 2023 18:28:21 -0800 (PST) On Mon, Nov 06, 2023 at 11:26:11AM +0900, AKASHI Takahiro wrote: > On Thu, Nov 02, 2023 at 08:06:41AM +0000, Cristian Marussi wrote: > > On Fri, Oct 27, 2023 at 06:28:10AM +0000, Oleksii Moisieiev wrote: > > > Add basic implementation of the SCMI v3.2 pincontrol protocol. > > > > > > Signed-off-by: Oleksii Moisieiev > > > --- > > > > Hi Oleksii, > > > > the new get/set v3.2 implementation seems finer to me at first sight. > > I'll try to test this next days and give you more feedback. > > I don't think that this version addresses my comment yet: > > https://lkml.iu.edu//hypermail/linux/kernel/2308.2/07483.html > > I hope that it will be fixed in your *final* v5. Oops, this comment should better go against patch#4/5. > -Takahiro Akashi > > > Thanks, > > Cristian